blob: 6ba1d77c394befad4d5d60c626dcbca62e2e1f83 [file] [log] [blame]
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -08001/*
2 * Copyright (C) 2008 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
xunchang24788852019-03-22 16:08:52 -070017#include "install/verifier.h"
Tao Baoac9d94d2016-11-03 11:37:15 -070018
Doug Zongker54e2e862009-08-17 13:21:04 -070019#include <errno.h>
Elliott Hughes26dbad22015-01-28 12:09:05 -080020#include <stdio.h>
Tao Baoac9d94d2016-11-03 11:37:15 -070021#include <stdlib.h>
Elliott Hughes26dbad22015-01-28 12:09:05 -080022#include <string.h>
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -080023
Elliott Hughes8febafa2016-04-13 16:39:56 -070024#include <algorithm>
Tao Baod7bf82e2017-03-18 09:24:11 -070025#include <functional>
Elliott Hughes8febafa2016-04-13 16:39:56 -070026#include <memory>
Tao Bao76fdb242017-03-20 17:09:13 -070027#include <vector>
Elliott Hughes8febafa2016-04-13 16:39:56 -070028
Tianjie Xu7b0ad9c2016-08-05 18:00:04 -070029#include <android-base/logging.h>
Tianjie Xu82566982018-10-10 15:44:17 -070030#include <openssl/bio.h>
David Benjamina86392e2016-04-15 20:22:09 -040031#include <openssl/bn.h>
Elliott Hughes8febafa2016-04-13 16:39:56 -070032#include <openssl/ecdsa.h>
Tianjie Xu82566982018-10-10 15:44:17 -070033#include <openssl/evp.h>
Elliott Hughes8febafa2016-04-13 16:39:56 -070034#include <openssl/obj_mac.h>
Tianjie Xu82566982018-10-10 15:44:17 -070035#include <openssl/pem.h>
36#include <openssl/rsa.h>
Tianjie Xu0dd96852018-10-15 11:44:14 -070037#include <ziparchive/zip_archive.h>
Elliott Hughes8febafa2016-04-13 16:39:56 -070038
Tao Bao09e468f2017-09-29 14:39:33 -070039#include "otautil/print_sha1.h"
xunchang24788852019-03-22 16:08:52 -070040#include "private/asn1_decoder.h"
Doug Zongker211aebc2011-10-28 15:13:10 -070041
Kenny Root7a4adb52013-10-09 10:14:35 -070042/*
43 * Simple version of PKCS#7 SignedData extraction. This extracts the
44 * signature OCTET STRING to be used for signature verification.
45 *
46 * For full details, see http://www.ietf.org/rfc/rfc3852.txt
47 *
48 * The PKCS#7 structure looks like:
49 *
50 * SEQUENCE (ContentInfo)
51 * OID (ContentType)
52 * [0] (content)
53 * SEQUENCE (SignedData)
54 * INTEGER (version CMSVersion)
55 * SET (DigestAlgorithmIdentifiers)
56 * SEQUENCE (EncapsulatedContentInfo)
57 * [0] (CertificateSet OPTIONAL)
58 * [1] (RevocationInfoChoices OPTIONAL)
59 * SET (SignerInfos)
60 * SEQUENCE (SignerInfo)
61 * INTEGER (CMSVersion)
62 * SEQUENCE (SignerIdentifier)
63 * SEQUENCE (DigestAlgorithmIdentifier)
64 * SEQUENCE (SignatureAlgorithmIdentifier)
65 * OCTET STRING (SignatureValue)
66 */
Tao Bao76fdb242017-03-20 17:09:13 -070067static bool read_pkcs7(const uint8_t* pkcs7_der, size_t pkcs7_der_len,
68 std::vector<uint8_t>* sig_der) {
69 CHECK(sig_der != nullptr);
70 sig_der->clear();
Kenny Root7a4adb52013-10-09 10:14:35 -070071
Tao Bao861c53c2017-03-20 17:09:13 -070072 asn1_context ctx(pkcs7_der, pkcs7_der_len);
73
74 std::unique_ptr<asn1_context> pkcs7_seq(ctx.asn1_sequence_get());
75 if (pkcs7_seq == nullptr || !pkcs7_seq->asn1_sequence_next()) {
Tao Bao76fdb242017-03-20 17:09:13 -070076 return false;
77 }
78
Tao Bao861c53c2017-03-20 17:09:13 -070079 std::unique_ptr<asn1_context> signed_data_app(pkcs7_seq->asn1_constructed_get());
80 if (signed_data_app == nullptr) {
81 return false;
Tao Bao76fdb242017-03-20 17:09:13 -070082 }
Kenny Root7a4adb52013-10-09 10:14:35 -070083
Tao Bao861c53c2017-03-20 17:09:13 -070084 std::unique_ptr<asn1_context> signed_data_seq(signed_data_app->asn1_sequence_get());
xunchang24788852019-03-22 16:08:52 -070085 if (signed_data_seq == nullptr || !signed_data_seq->asn1_sequence_next() ||
86 !signed_data_seq->asn1_sequence_next() || !signed_data_seq->asn1_sequence_next() ||
Tao Bao861c53c2017-03-20 17:09:13 -070087 !signed_data_seq->asn1_constructed_skip_all()) {
88 return false;
89 }
90
91 std::unique_ptr<asn1_context> sig_set(signed_data_seq->asn1_set_get());
92 if (sig_set == nullptr) {
93 return false;
94 }
95
96 std::unique_ptr<asn1_context> sig_seq(sig_set->asn1_sequence_get());
xunchang24788852019-03-22 16:08:52 -070097 if (sig_seq == nullptr || !sig_seq->asn1_sequence_next() || !sig_seq->asn1_sequence_next() ||
98 !sig_seq->asn1_sequence_next() || !sig_seq->asn1_sequence_next()) {
Tao Bao861c53c2017-03-20 17:09:13 -070099 return false;
100 }
101
102 const uint8_t* sig_der_ptr;
103 size_t sig_der_length;
104 if (!sig_seq->asn1_octet_string_get(&sig_der_ptr, &sig_der_length)) {
105 return false;
106 }
107
108 sig_der->resize(sig_der_length);
109 std::copy(sig_der_ptr, sig_der_ptr + sig_der_length, sig_der->begin());
110 return true;
Kenny Root7a4adb52013-10-09 10:14:35 -0700111}
112
xunchangf07ed2e2019-02-25 14:14:01 -0800113int verify_file(VerifierInterface* package, const std::vector<Certificate>& keys) {
114 CHECK(package);
115 package->SetProgress(0.0);
Doug Zongker54e2e862009-08-17 13:21:04 -0700116
Tao Bao5e535012017-03-16 17:37:38 -0700117 // An archive with a whole-file signature will end in six bytes:
118 //
119 // (2-byte signature start) $ff $ff (2-byte comment size)
120 //
121 // (As far as the ZIP format is concerned, these are part of the archive comment.) We start by
122 // reading this footer, this tells us how far back from the end we have to start reading to find
123 // the whole comment.
Doug Zongker54e2e862009-08-17 13:21:04 -0700124
125#define FOOTER_SIZE 6
xunchangf07ed2e2019-02-25 14:14:01 -0800126 uint64_t length = package->GetPackageSize();
Doug Zongker54e2e862009-08-17 13:21:04 -0700127
Tao Bao5e535012017-03-16 17:37:38 -0700128 if (length < FOOTER_SIZE) {
129 LOG(ERROR) << "not big enough to contain footer";
130 return VERIFY_FAILURE;
131 }
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800132
xunchangf07ed2e2019-02-25 14:14:01 -0800133 uint8_t footer[FOOTER_SIZE];
134 if (!package->ReadFullyAtOffset(footer, FOOTER_SIZE, length - FOOTER_SIZE)) {
135 LOG(ERROR) << "Failed to read footer";
136 return VERIFY_FAILURE;
137 }
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800138
Tao Bao5e535012017-03-16 17:37:38 -0700139 if (footer[2] != 0xff || footer[3] != 0xff) {
140 LOG(ERROR) << "footer is wrong";
141 return VERIFY_FAILURE;
142 }
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800143
Tao Bao5e535012017-03-16 17:37:38 -0700144 size_t comment_size = footer[4] + (footer[5] << 8);
145 size_t signature_start = footer[0] + (footer[1] << 8);
146 LOG(INFO) << "comment is " << comment_size << " bytes; signature is " << signature_start
147 << " bytes from end";
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800148
Tao Bao553c7bd2017-03-18 07:33:26 -0700149 if (signature_start > comment_size) {
xunchang24788852019-03-22 16:08:52 -0700150 LOG(ERROR) << "signature start: " << signature_start
151 << " is larger than comment size: " << comment_size;
Tao Bao553c7bd2017-03-18 07:33:26 -0700152 return VERIFY_FAILURE;
153 }
Tianjie Xu54ea1362016-12-16 16:24:09 -0800154
Tao Bao5e535012017-03-16 17:37:38 -0700155 if (signature_start <= FOOTER_SIZE) {
156 LOG(ERROR) << "Signature start is in the footer";
157 return VERIFY_FAILURE;
158 }
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800159
Doug Zongker54e2e862009-08-17 13:21:04 -0700160#define EOCD_HEADER_SIZE 22
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800161
Tao Bao5e535012017-03-16 17:37:38 -0700162 // The end-of-central-directory record is 22 bytes plus any comment length.
163 size_t eocd_size = comment_size + EOCD_HEADER_SIZE;
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800164
Tao Bao5e535012017-03-16 17:37:38 -0700165 if (length < eocd_size) {
166 LOG(ERROR) << "not big enough to contain EOCD";
Doug Zongker54e2e862009-08-17 13:21:04 -0700167 return VERIFY_FAILURE;
Tao Bao5e535012017-03-16 17:37:38 -0700168 }
169
170 // Determine how much of the file is covered by the signature. This is everything except the
171 // signature data and length, which includes all of the EOCD except for the comment length field
172 // (2 bytes) and the comment data.
xunchangf07ed2e2019-02-25 14:14:01 -0800173 uint64_t signed_len = length - eocd_size + EOCD_HEADER_SIZE - 2;
Tao Bao5e535012017-03-16 17:37:38 -0700174
xunchangf07ed2e2019-02-25 14:14:01 -0800175 uint8_t eocd[eocd_size];
176 if (!package->ReadFullyAtOffset(eocd, eocd_size, length - eocd_size)) {
177 LOG(ERROR) << "Failed to read EOCD of " << eocd_size << " bytes";
178 return VERIFY_FAILURE;
179 }
Tao Bao5e535012017-03-16 17:37:38 -0700180
181 // If this is really is the EOCD record, it will begin with the magic number $50 $4b $05 $06.
182 if (eocd[0] != 0x50 || eocd[1] != 0x4b || eocd[2] != 0x05 || eocd[3] != 0x06) {
183 LOG(ERROR) << "signature length doesn't match EOCD marker";
184 return VERIFY_FAILURE;
185 }
186
xunchang24788852019-03-22 16:08:52 -0700187 for (size_t i = 4; i < eocd_size - 3; ++i) {
188 if (eocd[i] == 0x50 && eocd[i + 1] == 0x4b && eocd[i + 2] == 0x05 && eocd[i + 3] == 0x06) {
Tao Bao5e535012017-03-16 17:37:38 -0700189 // If the sequence $50 $4b $05 $06 appears anywhere after the real one, libziparchive will
190 // find the later (wrong) one, which could be exploitable. Fail the verification if this
191 // sequence occurs anywhere after the real one.
192 LOG(ERROR) << "EOCD marker occurs after start of EOCD";
193 return VERIFY_FAILURE;
194 }
195 }
196
197 bool need_sha1 = false;
198 bool need_sha256 = false;
199 for (const auto& key : keys) {
200 switch (key.hash_len) {
xunchang24788852019-03-22 16:08:52 -0700201 case SHA_DIGEST_LENGTH:
202 need_sha1 = true;
203 break;
204 case SHA256_DIGEST_LENGTH:
205 need_sha256 = true;
206 break;
Tao Bao5e535012017-03-16 17:37:38 -0700207 }
208 }
209
210 SHA_CTX sha1_ctx;
211 SHA256_CTX sha256_ctx;
212 SHA1_Init(&sha1_ctx);
213 SHA256_Init(&sha256_ctx);
214
xunchangf07ed2e2019-02-25 14:14:01 -0800215 std::vector<HasherUpdateCallback> hashers;
216 if (need_sha1) {
217 hashers.emplace_back(
218 std::bind(&SHA1_Update, &sha1_ctx, std::placeholders::_1, std::placeholders::_2));
219 }
220 if (need_sha256) {
221 hashers.emplace_back(
222 std::bind(&SHA256_Update, &sha256_ctx, std::placeholders::_1, std::placeholders::_2));
223 }
224
Tao Bao5e535012017-03-16 17:37:38 -0700225 double frac = -1.0;
xunchangf07ed2e2019-02-25 14:14:01 -0800226 uint64_t so_far = 0;
Tao Bao5e535012017-03-16 17:37:38 -0700227 while (so_far < signed_len) {
xunchangf07ed2e2019-02-25 14:14:01 -0800228 // On a Nexus 5X, experiment showed 16MiB beat 1MiB by 6% faster for a 1196MiB full OTA and
229 // 60% for an 89MiB incremental OTA. http://b/28135231.
230 uint64_t read_size = std::min<uint64_t>(signed_len - so_far, 16 * MiB);
231 package->UpdateHashAtOffset(hashers, so_far, read_size);
232 so_far += read_size;
Tao Bao5e535012017-03-16 17:37:38 -0700233
xunchangf07ed2e2019-02-25 14:14:01 -0800234 double f = so_far / static_cast<double>(signed_len);
235 if (f > frac + 0.02 || read_size == so_far) {
236 package->SetProgress(f);
237 frac = f;
Tao Bao5e535012017-03-16 17:37:38 -0700238 }
239 }
240
241 uint8_t sha1[SHA_DIGEST_LENGTH];
242 SHA1_Final(sha1, &sha1_ctx);
243 uint8_t sha256[SHA256_DIGEST_LENGTH];
244 SHA256_Final(sha256, &sha256_ctx);
245
Tao Bao76fdb242017-03-20 17:09:13 -0700246 const uint8_t* signature = eocd + eocd_size - signature_start;
Tao Bao5e535012017-03-16 17:37:38 -0700247 size_t signature_size = signature_start - FOOTER_SIZE;
248
xunchang24788852019-03-22 16:08:52 -0700249 LOG(INFO) << "signature (offset: " << std::hex << (length - signature_start)
250 << ", length: " << signature_size << "): " << print_hex(signature, signature_size);
Tao Bao5e535012017-03-16 17:37:38 -0700251
Tao Bao76fdb242017-03-20 17:09:13 -0700252 std::vector<uint8_t> sig_der;
253 if (!read_pkcs7(signature, signature_size, &sig_der)) {
Tao Bao5e535012017-03-16 17:37:38 -0700254 LOG(ERROR) << "Could not find signature DER block";
255 return VERIFY_FAILURE;
256 }
257
258 // Check to make sure at least one of the keys matches the signature. Since any key can match,
259 // we need to try each before determining a verification failure has happened.
260 size_t i = 0;
261 for (const auto& key : keys) {
262 const uint8_t* hash;
263 int hash_nid;
264 switch (key.hash_len) {
265 case SHA_DIGEST_LENGTH:
266 hash = sha1;
267 hash_nid = NID_sha1;
268 break;
269 case SHA256_DIGEST_LENGTH:
270 hash = sha256;
271 hash_nid = NID_sha256;
272 break;
273 default:
274 continue;
275 }
276
277 // The 6 bytes is the "(signature_start) $ff $ff (comment_size)" that the signing tool appends
278 // after the signature itself.
279 if (key.key_type == Certificate::KEY_TYPE_RSA) {
Tao Bao76fdb242017-03-20 17:09:13 -0700280 if (!RSA_verify(hash_nid, hash, key.hash_len, sig_der.data(), sig_der.size(),
281 key.rsa.get())) {
Tao Bao5e535012017-03-16 17:37:38 -0700282 LOG(INFO) << "failed to verify against RSA key " << i;
283 continue;
284 }
285
286 LOG(INFO) << "whole-file signature verified against RSA key " << i;
Tao Bao5e535012017-03-16 17:37:38 -0700287 return VERIFY_SUCCESS;
288 } else if (key.key_type == Certificate::KEY_TYPE_EC && key.hash_len == SHA256_DIGEST_LENGTH) {
Tao Bao76fdb242017-03-20 17:09:13 -0700289 if (!ECDSA_verify(0, hash, key.hash_len, sig_der.data(), sig_der.size(), key.ec.get())) {
Tao Bao5e535012017-03-16 17:37:38 -0700290 LOG(INFO) << "failed to verify against EC key " << i;
291 continue;
292 }
293
294 LOG(INFO) << "whole-file signature verified against EC key " << i;
Tao Bao5e535012017-03-16 17:37:38 -0700295 return VERIFY_SUCCESS;
296 } else {
297 LOG(INFO) << "Unknown key type " << key.key_type;
298 }
299 i++;
300 }
301
302 if (need_sha1) {
303 LOG(INFO) << "SHA-1 digest: " << print_hex(sha1, SHA_DIGEST_LENGTH);
304 }
305 if (need_sha256) {
306 LOG(INFO) << "SHA-256 digest: " << print_hex(sha256, SHA256_DIGEST_LENGTH);
307 }
Tao Bao5e535012017-03-16 17:37:38 -0700308 LOG(ERROR) << "failed to verify whole-file signature";
309 return VERIFY_FAILURE;
The Android Open Source Projectc24a8e62009-03-03 19:28:42 -0800310}
Doug Zongker6c249f72012-11-02 15:04:05 -0700311
Tianjie Xu0dd96852018-10-15 11:44:14 -0700312static std::vector<Certificate> IterateZipEntriesAndSearchForKeys(const ZipArchiveHandle& handle) {
313 void* cookie;
314 ZipString suffix("x509.pem");
315 int32_t iter_status = StartIteration(handle, &cookie, nullptr, &suffix);
316 if (iter_status != 0) {
317 LOG(ERROR) << "Failed to iterate over entries in the certificate zipfile: "
318 << ErrorCodeString(iter_status);
319 return {};
320 }
321
322 std::vector<Certificate> result;
323
324 ZipString name;
325 ZipEntry entry;
326 while ((iter_status = Next(cookie, &entry, &name)) == 0) {
327 std::vector<uint8_t> pem_content(entry.uncompressed_length);
328 if (int32_t extract_status =
329 ExtractToMemory(handle, &entry, pem_content.data(), pem_content.size());
330 extract_status != 0) {
331 LOG(ERROR) << "Failed to extract " << std::string(name.name, name.name + name.name_length);
332 return {};
333 }
334
335 Certificate cert(0, Certificate::KEY_TYPE_RSA, nullptr, nullptr);
336 // Aborts the parsing if we fail to load one of the key file.
337 if (!LoadCertificateFromBuffer(pem_content, &cert)) {
338 LOG(ERROR) << "Failed to load keys from "
339 << std::string(name.name, name.name + name.name_length);
340 return {};
341 }
342
343 result.emplace_back(std::move(cert));
344 }
345
346 if (iter_status != -1) {
347 LOG(ERROR) << "Error while iterating over zip entries: " << ErrorCodeString(iter_status);
348 return {};
349 }
350
351 return result;
352}
353
354std::vector<Certificate> LoadKeysFromZipfile(const std::string& zip_name) {
355 ZipArchiveHandle handle;
356 if (int32_t open_status = OpenArchive(zip_name.c_str(), &handle); open_status != 0) {
357 LOG(ERROR) << "Failed to open " << zip_name << ": " << ErrorCodeString(open_status);
358 return {};
359 }
360
361 std::vector<Certificate> result = IterateZipEntriesAndSearchForKeys(handle);
362 CloseArchive(handle);
363 return result;
364}
365
Tianjie Xub5110de2018-10-23 23:31:43 -0700366bool CheckRSAKey(const std::unique_ptr<RSA, RSADeleter>& rsa) {
367 if (!rsa) {
368 return false;
369 }
370
371 const BIGNUM* out_n;
372 const BIGNUM* out_e;
373 RSA_get0_key(rsa.get(), &out_n, &out_e, nullptr /* private exponent */);
374 auto modulus_bits = BN_num_bits(out_n);
xunchang908ad772019-03-26 09:54:34 -0700375 if (modulus_bits != 2048 && modulus_bits != 4096) {
376 LOG(ERROR) << "Modulus should be 2048 or 4096 bits long, actual: " << modulus_bits;
Tianjie Xub5110de2018-10-23 23:31:43 -0700377 return false;
378 }
379
380 BN_ULONG exponent = BN_get_word(out_e);
381 if (exponent != 3 && exponent != 65537) {
382 LOG(ERROR) << "Public exponent should be 3 or 65537, actual: " << exponent;
383 return false;
384 }
385
386 return true;
387}
388
389bool CheckECKey(const std::unique_ptr<EC_KEY, ECKEYDeleter>& ec_key) {
390 if (!ec_key) {
391 return false;
392 }
393
394 const EC_GROUP* ec_group = EC_KEY_get0_group(ec_key.get());
395 if (!ec_group) {
396 LOG(ERROR) << "Failed to get the ec_group from the ec_key";
397 return false;
398 }
399 auto degree = EC_GROUP_get_degree(ec_group);
400 if (degree != 256) {
401 LOG(ERROR) << "Field size of the ec key should be 256 bits long, actual: " << degree;
402 return false;
403 }
404
405 return true;
406}
407
Tianjie Xu82566982018-10-10 15:44:17 -0700408bool LoadCertificateFromBuffer(const std::vector<uint8_t>& pem_content, Certificate* cert) {
409 std::unique_ptr<BIO, decltype(&BIO_free)> content(
410 BIO_new_mem_buf(pem_content.data(), pem_content.size()), BIO_free);
411
412 std::unique_ptr<X509, decltype(&X509_free)> x509(
413 PEM_read_bio_X509(content.get(), nullptr, nullptr, nullptr), X509_free);
414 if (!x509) {
415 LOG(ERROR) << "Failed to read x509 certificate";
416 return false;
417 }
418
419 int nid = X509_get_signature_nid(x509.get());
420 switch (nid) {
421 // SignApk has historically accepted md5WithRSA certificates, but treated them as
422 // sha1WithRSA anyway. Continue to do so for backwards compatibility.
423 case NID_md5WithRSA:
424 case NID_md5WithRSAEncryption:
425 case NID_sha1WithRSA:
426 case NID_sha1WithRSAEncryption:
427 cert->hash_len = SHA_DIGEST_LENGTH;
428 break;
429 case NID_sha256WithRSAEncryption:
430 case NID_ecdsa_with_SHA256:
431 cert->hash_len = SHA256_DIGEST_LENGTH;
432 break;
433 default:
434 LOG(ERROR) << "Unrecognized signature nid " << OBJ_nid2ln(nid);
435 return false;
436 }
437
438 std::unique_ptr<EVP_PKEY, decltype(&EVP_PKEY_free)> public_key(X509_get_pubkey(x509.get()),
439 EVP_PKEY_free);
440 if (!public_key) {
441 LOG(ERROR) << "Failed to extract the public key from x509 certificate";
442 return false;
443 }
444
445 int key_type = EVP_PKEY_id(public_key.get());
Tianjie Xu82566982018-10-10 15:44:17 -0700446 if (key_type == EVP_PKEY_RSA) {
447 cert->key_type = Certificate::KEY_TYPE_RSA;
448 cert->ec.reset();
449 cert->rsa.reset(EVP_PKEY_get1_RSA(public_key.get()));
Tianjie Xub5110de2018-10-23 23:31:43 -0700450 if (!cert->rsa || !CheckRSAKey(cert->rsa)) {
451 LOG(ERROR) << "Failed to validate the rsa key info from public key";
Tianjie Xu82566982018-10-10 15:44:17 -0700452 return false;
453 }
454 } else if (key_type == EVP_PKEY_EC) {
455 cert->key_type = Certificate::KEY_TYPE_EC;
456 cert->rsa.reset();
457 cert->ec.reset(EVP_PKEY_get1_EC_KEY(public_key.get()));
Tianjie Xub5110de2018-10-23 23:31:43 -0700458 if (!cert->ec || !CheckECKey(cert->ec)) {
459 LOG(ERROR) << "Failed to validate the ec key info from the public key";
Tianjie Xu82566982018-10-10 15:44:17 -0700460 return false;
461 }
462 } else {
463 LOG(ERROR) << "Unrecognized public key type " << OBJ_nid2ln(key_type);
464 return false;
465 }
466
467 return true;
468}