Gitiles
Code Review Sign In
gerrit.twrp.me / android_bootable_recovery / 54ea136fded56810bf475885eb4bd7bf1b11f09c
commit54ea136fded56810bf475885eb4bd7bf1b11f09c[log] [tgz]
authorTianjie Xu <xunchang@google.com>Fri Dec 16 16:24:09 2016 -0800
committerTianjie Xu <xunchang@google.com>Fri Dec 16 16:24:09 2016 -0800
treefe5e271c356a3a6eea24e86bbecd620d87b032e7
parent36acff7d7e88549bbeab6a08488ab48596d7fbc5 [diff]
Add a checker for signature boundary in verifier

The 'signature_start' variable marks the location of the signature
from the end of a zip archive. And a boundary check is missing where
'signature_start' should be within the EOCD comment field. This causes
problems when sideloading a malicious package. Also add a corresponding
test.

Bug: 31914369
Test: Verification fails correctly when sideloading recovery_test.zip on
angler.

Change-Id: I6ea96bf04dac5d8d4d6719e678d504f957b4d5c1
(cherry-picked from f69e6a9475983b2ad46729e44ab58d2b22cd74d0)
1 file changed
tree: fe5e271c356a3a6eea24e86bbecd620d87b032e7
  1. applypatch/
  2. edify/
  3. etc/
  4. fonts/
  5. minadbd/
  6. minui/
  7. minzip/
  8. mtdutils/
  9. res-hdpi/
  10. res-mdpi/
  11. res-xhdpi/
  12. res-xxhdpi/
  13. res-xxxhdpi/
  14. testdata/
  15. tests/
  16. tools/
  17. uncrypt/
  18. updater/
  19. adb_install.cpp
  20. adb_install.h
  21. Android.mk
  22. asn1_decoder.cpp
  23. asn1_decoder.h
  24. bootloader.cpp
  25. bootloader.h
  26. CleanSpec.mk
  27. common.h
  28. default_device.cpp
  29. device.h
  30. fuse_sdcard_provider.c
  31. fuse_sdcard_provider.h
  32. fuse_sideload.c
  33. fuse_sideload.h
  34. install.cpp
  35. install.h
  36. interlace-frames.py
  37. NOTICE
  38. recovery.cpp
  39. roots.cpp
  40. roots.h
  41. screen_ui.cpp
  42. screen_ui.h
  43. ui.cpp
  44. ui.h
  45. verifier.cpp
  46. verifier.h
  47. verifier_test.cpp
  48. verifier_test.sh