Mount system as read-only by default
Mounting system as rw can prevent future OTA updates. The purpose
of this patch set is to prevent TWRP from mounting sytem as rw on
the first boot. Device maintainers should update their twrp.fstab
files on these devices to include an additional line:
/system_image emmc /dev/block/../system
This line will allow TWRP to create a raw system image backup to
ensure that the user can return to an original state for future
OTA updates.
Change-Id: I8929d85bc3a5b96cc564bc7f734b58d5612ec833
diff --git a/gui/devices/landscape/res/landscape.xml b/gui/devices/landscape/res/landscape.xml
index 25b9b17..12c6629 100644
--- a/gui/devices/landscape/res/landscape.xml
+++ b/gui/devices/landscape/res/landscape.xml
@@ -989,6 +989,27 @@
</actions>
</object>
+ <object type="button">
+ <placement x="%col3_x%" y="%row10_text_y%" />
+ <font resource="font" color="%text_color%" />
+ <condition var1="tw_mount_system_ro" op="=" var2="0" />
+ <text>Only mount system read-only</text>
+ <image resource="checkbox_false" />
+ <action function="mountsystemtoggle"></action>
+ </object>
+
+ <object type="button">
+ <placement x="%col3_x%" y="%row10_text_y%" />
+ <font resource="font" color="%text_color%" />
+ <condition var1="tw_mount_system_ro" op="!=" var2="0" />
+ <text>Only mount system read-only</text>
+ <image resource="checkbox_true" />
+ <actions>
+ <action function="set">tw_lifetime_writes=2</action>
+ <action function="page">system_readonly_check</action>
+ </actions>
+ </object>
+
<object type="action">
<touch key="home" />
<action function="page">main</action>
@@ -1035,6 +1056,31 @@
<object type="template" name="footer" />
</page>
+ <page name="system_readonly_check">
+ <object type="action">
+ <action function="checkpartitionlifetimewrites">/system</action>
+ </object>
+
+ <object type="action">
+ <conditions>
+ <condition var1="tw_operation_state" var2="1" />
+ <condition var1="tw_lifetime_writes" var2="1" />
+ </conditions>
+ <action function="page">mount</action>
+ </object>
+
+ <object type="action">
+ <conditions>
+ <condition var1="tw_operation_state" var2="1" />
+ <condition var1="tw_lifetime_writes" var2="0" />
+ </conditions>
+ <actions>
+ <action function="set">tw_back=mount</action>
+ <action function="page">system_readonly</action>
+ </actions>
+ </object>
+ </page>
+
<page name="wipe">
<object type="template" name="header" />
@@ -3596,5 +3642,57 @@
</actions>
</object>
</page>
+
+ <page name="system_readonly">
+ <object type="template" name="header" />
+
+ <object type="text">
+ <placement x="%center_x%" y="%row1_text_y%" placement="5" />
+ <text>TWRP has detected an unmodified system partition.</text>
+ </object>
+
+ <object type="text">
+ <placement x="%center_x%" y="%row2_text_y%" placement="5" />
+ <text>TWRP can leave your system partition unmodified to make it easier for you to take official updates.</text>
+ </object>
+
+ <object type="text">
+ <placement x="%center_x%" y="%row3_text_y%" placement="5" />
+ <text>TWRP will be unable to prevent the stock ROM from replacing TWRP and will not offer to root your device.</text>
+ </object>
+
+ <object type="text">
+ <placement x="%center_x%" y="%row4_text_y%" placement="5" />
+ <text>Installing zips or performing adb operations may still modify the system partition.</text>
+ </object>
+
+ <object type="checkbox">
+ <condition var1="tw_is_encrypted" var2="0" />
+ <placement x="%col1_x%" y="%row5_text_y%" />
+ <text>Never show this screen during boot again</text>
+ <data variable="tw_never_show_system_ro_page" />
+ </object>
+
+ <object type="button">
+ <placement x="%col_center_x%" y="%row7_text_y%" />
+ <text>Keep Read Only</text>
+ <actions>
+ <action function="set">tw_mount_system_ro=1</action>
+ <action function="set">tw_page_done=1</action>
+ <action function="page">%tw_back%</action>
+ </actions>
+ </object>
+
+ <object type="slider">
+ <text>Swipe to Allow Modifications</text>
+ <actions>
+ <action function="set">tw_mount_system_ro=0</action>
+ <action function="set">tw_page_done=1</action>
+ <action function="page">%tw_back%</action>
+ </actions>
+ </object>
+
+ <object type="template" name="footer" />
+ </page>
</pages>
</recovery>