am 6d60667d: Merge "Use a dependency file to replace the list file."
* commit '6d60667de6b8e6bd8a54fb4031901e2935743308':
Use a dependency file to replace the list file.
diff --git a/updater/Android.mk b/updater/Android.mk
index f8ccb76..2211113 100644
--- a/updater/Android.mk
+++ b/updater/Android.mk
@@ -50,18 +50,19 @@
inc := $(call intermediates-dir-for,PACKAGING,updater_extensions)/register.inc
-# During the first pass of reading the makefiles, we dump the list of
-# extension libs to a temp file, then copy that to the ".list" file if
-# it is different than the existing .list (if any). The register.inc
-# file then uses the .list as a prerequisite, so it is only rebuilt
-# (and updater.o recompiled) when the list of extension libs changes.
-
-junk := $(shell mkdir -p $(dir $(inc));\
- echo $(TARGET_RECOVERY_UPDATER_LIBS) > $(inc).temp;\
- diff -q $(inc).temp $(inc).list 2>/dev/null || cp -f $(inc).temp $(inc).list)
+# Encode the value of TARGET_RECOVERY_UPDATER_LIBS into the filename of the dependency.
+# So if TARGET_RECOVERY_UPDATER_LIBS is changed, a new dependency file will be generated.
+# Note that we have to remove any existing depency files before creating new one,
+# so no obsolete dependecy file gets used if you switch back to an old value.
+inc_dep_file := $(inc).dep.$(subst $(space),-,$(sort $(TARGET_RECOVERY_UPDATER_LIBS)))
+$(inc_dep_file): stem := $(inc).dep
+$(inc_dep_file) :
+ $(hide) mkdir -p $(dir $@)
+ $(hide) rm -f $(stem).*
+ $(hide) touch $@
$(inc) : libs := $(TARGET_RECOVERY_UPDATER_LIBS)
-$(inc) : $(inc).list
+$(inc) : $(inc_dep_file)
$(hide) mkdir -p $(dir $@)
$(hide) echo "" > $@
$(hide) $(foreach lib,$(libs),echo "extern void Register_$(lib)(void);" >> $@;)
@@ -72,6 +73,9 @@
$(call intermediates-dir-for,EXECUTABLES,updater)/updater.o : $(inc)
LOCAL_C_INCLUDES += $(dir $(inc))
+inc :=
+inc_dep_file :=
+
LOCAL_MODULE := updater
LOCAL_FORCE_STATIC_EXECUTABLE := true