commit de6735e80cc65be50381388640d94f1b1d0f20fa
author Tianjie Xu <xunchang@google.com> Mon Jul 10 15:13:33 2017 -0700
committer Tianjie Xu <xunchang@google.com> Wed Jul 19 12:17:41 2017 -0700
tree bdcda7cd5a4e2baa1f45c66f6a1698df47119175
parent 8155a8ba74bce27626f3ce3f088951298c44776d

Fix the android-cloexec-* warnings in bootable/recovery

Add the O_CLOEXEC or 'e' accordingly.

Bug: 63510015
Test: recovery tests pass
Change-Id: I7094bcc6af22c9687eb535116b2ca6a59178b303

install.cpp

diff --git a/install.cpp b/install.cpp
index 7ba8f01..7fbf5c0 100644
--- a/install.cpp
+++ b/install.cpp
@@ -265,7 +265,7 @@
   }
 
   unlink(binary_path.c_str());
-  int fd = creat(binary_path.c_str(), 0755);
+  int fd = open(binary_path.c_str(), O_CREAT | O_WRONLY | O_TRUNC | O_CLOEXEC, 0755);
   if (fd == -1) {
     PLOG(ERROR) << "Failed to create " << binary_path;
     return INSTALL_ERROR;