Gitiles
Code Review Sign In
gerrit.twrp.me / android_bootable_recovery / c89d1e7e2a6a8a07bb336db35db88f5452d8a51d
commitc89d1e7e2a6a8a07bb336db35db88f5452d8a51d[log] [tgz]
authorTianjie Xu <xunchang@google.com>Mon Aug 28 14:15:07 2017 -0700
committerTianjie Xu <xunchang@google.com>Mon Aug 28 21:56:33 2017 -0700
treebb13d2572bc220a73808f455c5191e62e64c368a
parente9605b8ca01fba6b0ed2d01677815882d6371a53 [diff]
Turn on -Wall for recovery modules

Turn on -Wall for all modules. Also remove the obsolete file_cmp() in
apply_patch test and now() in wear_ui.

The only exception is lib_edify due to the unused functions in the
intermediate cpp files generated from the lex files. It will be handled
in a seperate CL.

Bug: 64939312
Test: mma, unit tests pass
Change-Id: Ic53f76b60b6401ab20db3d98130d674c08e3702f
12 files changed
tree: bb13d2572bc220a73808f455c5191e62e64c368a
  1. applypatch/
  2. boot_control/
  3. bootloader_message/
  4. edify/
  5. etc/
  6. fonts/
  7. minadbd/
  8. minui/
  9. otafault/
  10. otautil/
  11. private/
  12. res-hdpi/
  13. res-mdpi/
  14. res-xhdpi/
  15. res-xxhdpi/
  16. res-xxxhdpi/
  17. tests/
  18. tools/
  19. uncrypt/
  20. update_verifier/
  21. updater/
  22. res-560dpi ⇨ res-xxxhdpi
  23. .clang-format
  24. adb_install.cpp
  25. adb_install.h
  26. Android.bp
  27. Android.mk
  28. asn1_decoder.cpp
  29. asn1_decoder.h
  30. bootloader.h
  31. CleanSpec.mk
  32. common.h
  33. default_device.cpp
  34. device.cpp
  35. device.h
  36. error_code.h
  37. fuse_sdcard_provider.cpp
  38. fuse_sdcard_provider.h
  39. fuse_sideload.cpp
  40. fuse_sideload.h
  41. install.cpp
  42. install.h
  43. interlace-frames.py
  44. mounts.cpp
  45. mounts.h
  46. NOTICE
  47. OWNERS
  48. print_sha1.h
  49. rangeset.h
  50. README.md
  51. recovery-persist.cpp
  52. recovery-persist.rc
  53. recovery-refresh.cpp
  54. recovery-refresh.rc
  55. recovery.cpp
  56. roots.cpp
  57. roots.h
  58. rotate_logs.cpp
  59. rotate_logs.h
  60. screen_ui.cpp
  61. screen_ui.h
  62. stub_ui.h
  63. ui.cpp
  64. ui.h
  65. verifier.cpp
  66. verifier.h
  67. vr_device.cpp
  68. vr_ui.cpp
  69. vr_ui.h
  70. wear_device.cpp
  71. wear_ui.cpp
  72. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test

Running the manual tests

recovery-refresh and recovery-persist executables exist only on systems without /cache partition. And we need to follow special steps to run tests for them.

  • Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.

  • Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.

ResourceTest validates whether the png files are qualified as background text image under recovery.

1. `adb sync data` to make sure the test-dir has the images to test.
2. The test will automatically pickup and verify all `_text.png` files in
   the test dir.