commit bb687f4b13ef818d4eddf4a08662820e888576fd
author Andrew Dodd <atd7@cornell.edu> Sun Jun 29 18:24:35 2014 -0400
committer Andrew Dodd <atd7@cornell.edu> Sun Jun 29 21:14:06 2014 -0400
tree 6f4a109adb7267536d2b42e75379f3cf4935cf92
parent 5eac222cfe65ea7458bb715e009841e1d15240c5

minui: Do not return true from target_has_overlay() if MSM_BSP is not set

Since target_has_overlay() was not ifdefed with MSM_BSP,
it would return true on some devices even if MSM_BSP was unset,
breaking LPM and some other minui functions.

Change-Id: Ic6b524fa0b5e36fc9ffe67d53e2bf33e9d4fd2d3

minui/graphics_overlay.c

diff --git a/minui/graphics_overlay.c b/minui/graphics_overlay.c
index 02ef0b9..5677ad7 100644
--- a/minui/graphics_overlay.c
+++ b/minui/graphics_overlay.c
@@ -77,7 +77,6 @@
 #endif
     return format;
 }
-#endif // #ifdef MSM_BSP
 
 static bool overlay_supported = false;
 
@@ -103,8 +102,6 @@
     return overlay_supported;
 }
 
-#ifdef MSM_BSP
-
 int free_ion_mem(void) {
     if (!overlay_supported)
         return -EINVAL;
@@ -284,6 +281,10 @@
 
 #else
 
+bool target_has_overlay(char *version) {
+    return false;
+}
+
 int free_ion_mem(void) {
     return -EINVAL;
 }

minuitwrp/graphics_overlay.c

diff --git a/minuitwrp/graphics_overlay.c b/minuitwrp/graphics_overlay.c
index 961ae27..05c5472 100644
--- a/minuitwrp/graphics_overlay.c
+++ b/minuitwrp/graphics_overlay.c
@@ -80,7 +80,6 @@
 #endif
     return format;
 }
-#endif // #ifdef MSM_BSP
 
 static bool overlay_supported = false;
 static bool isMDP5 = false;
@@ -104,7 +103,7 @@
             isMDP5 = true;
         }
     }
-if (overlay_supported) printf("Using qcomm overlay\n");
+    if (overlay_supported) printf("Using qcomm overlay\n");
     return overlay_supported;
 }
 
@@ -116,8 +115,6 @@
     return false;
 }
 
-#ifdef MSM_BSP
-
 int free_ion_mem(void) {
     if (!overlay_supported)
         return -EINVAL;
@@ -426,6 +423,14 @@
 
 #else
 
+bool target_has_overlay(char *version) {
+    return false;
+}
+
+bool isTargetMdp5() {
+    return false;
+}
+
 int free_ion_mem(void) {
     return -EINVAL;
 }