commit 97eda9db705f0435dd049e1fa93bd878defa747c
author Damien Bargiacchi <drb@google.com> Fri Sep 09 07:14:08 2016 -0700
committer Tao Bao <tbao@google.com> Tue Nov 15 16:40:32 2016 -0800
tree 32d4c6357560d1fcbaa9545d98b61f78d1d55d65
parent d5d34d70a5d9c24e214855bb7e1e5402a96ec7cc

Have gr_init_font alloc memory for the font

Change-Id: I8ccf369d52011bc5d07d8e041fe558ce734a78fc
(cherry picked from commit d00f5eb63a8e4690f9bef1e943d539d052444d9b)

minui/graphics.cpp

diff --git a/minui/graphics.cpp b/minui/graphics.cpp
index 43ec83f..ab56a6f 100644
--- a/minui/graphics.cpp
+++ b/minui/graphics.cpp
@@ -264,33 +264,41 @@
     return surface->height;
 }
 
-int gr_init_font(const char* name, GRFont* dest) {
-    int res = res_create_alpha_surface(name, &(dest->texture));
+int gr_init_font(const char* name, GRFont** dest) {
+    GRFont* font = reinterpret_cast<GRFont*>(calloc(1, sizeof(*gr_font)));
+    if (font == nullptr) {
+        return -1;
+    }
+
+    int res = res_create_alpha_surface(name, &(font->texture));
     if (res < 0) {
+        free(font);
         return res;
     }
 
     // The font image should be a 96x2 array of character images.  The
     // columns are the printable ASCII characters 0x20 - 0x7f.  The
     // top row is regular text; the bottom row is bold.
-    dest->char_width = dest->texture->width / 96;
-    dest->char_height = dest->texture->height / 2;
+    font->char_width = font->texture->width / 96;
+    font->char_height = font->texture->height / 2;
+
+    *dest = font;
 
     return 0;
 }
 
 static void gr_init_font(void)
 {
-    gr_font = reinterpret_cast<GRFont*>(calloc(sizeof(*gr_font), 1));
-
-    int res = gr_init_font("font", gr_font);
+    int res = gr_init_font("font", &gr_font);
     if (res == 0) {
         return;
     }
 
     printf("failed to read font: res=%d\n", res);
 
+
     // fall back to the compiled-in font.
+    gr_font = reinterpret_cast<GRFont*>(calloc(1, sizeof(*gr_font)));
     gr_font->texture = reinterpret_cast<GRSurface*>(malloc(sizeof(*gr_font->texture)));
     gr_font->texture->width = font.width;
     gr_font->texture->height = font.height;

minui/minui.h

diff --git a/minui/minui.h b/minui/minui.h
index f6b42c6..78890b8 100644
--- a/minui/minui.h
+++ b/minui/minui.h
@@ -55,7 +55,7 @@
 void gr_texticon(int x, int y, GRSurface* icon);
 
 const GRFont* gr_sys_font();
-int gr_init_font(const char* name, GRFont* dest);
+int gr_init_font(const char* name, GRFont** dest);
 void gr_text(const GRFont* font, int x, int y, const char *s, bool bold);
 int gr_measure(const GRFont* font, const char *s);
 void gr_font_size(const GRFont* font, int *x, int *y);