commit 8b23811d2ac5c056ff49f2ab4fca3447a9fdca42
author Chih-Hung Hsieh <chh@google.com> Fri Aug 26 14:54:29 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Fri Aug 26 14:54:29 2016 -0700
tree b2d9b2cab10667fdd08f2de84db84dc86845477a
parent b3ddc0a4bf4334fa114d2b1716675d29a7024c1f

Fix clang-tidy warnings in bootable/recovery.

* Use const reference type for read-only parameters.
Bug: 30407689
* Use faster overloaded string find function.
Bug: 30411878
* Add parentheses around macro parameters.
Bug: 28705665

Test: build with WITH_TIDY=1
Change-Id: I4e8e5748bfa4ae89871f1fb5fa4624d372530d75

tests/component/applypatch_test.cpp

diff --git a/tests/component/applypatch_test.cpp b/tests/component/applypatch_test.cpp
index b44ddd1..2f7cb02 100644
--- a/tests/component/applypatch_test.cpp
+++ b/tests/component/applypatch_test.cpp
@@ -65,7 +65,7 @@
     return c1 == c2;
 }
 
-static std::string from_testdata_base(const std::string fname) {
+static std::string from_testdata_base(const std::string& fname) {
     return android::base::StringPrintf("%s%s%s/%s",
             &DATA_PATH[0],
             &NATIVE_TEST_PATH[0],