commit 897385bfe29a362c0ae541c9e09d58fe3563a77d
author Treehugger Robot <treehugger-gerrit@google.com> Wed Apr 25 02:38:11 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Apr 25 02:38:11 2018 +0000
tree 9d7a401095d6fcc1bb6af50e49b0d4e4b39c5c3a
parent fe527cced417916bb6867178d0a57200747f169e
parent 3b4d516151c622b4015fb14af4ea3223ed57f2e0

Merge "Wipe the metadata partition when we wipe data."

recovery.cpp

diff --git a/recovery.cpp b/recovery.cpp
index 910cd82..ceb1941 100644
--- a/recovery.cpp
+++ b/recovery.cpp
@@ -108,6 +108,7 @@
 static const char *CONVERT_FBE_FILE = "/tmp/convert_fbe/convert_fbe";
 static const char *CACHE_ROOT = "/cache";
 static const char *DATA_ROOT = "/data";
+static const char* METADATA_ROOT = "/metadata";
 static const char *SDCARD_ROOT = "/sdcard";
 static const char *TEMPORARY_LOG_FILE = "/tmp/recovery.log";
 static const char *TEMPORARY_INSTALL_FILE = "/tmp/last_install";
@@ -752,11 +753,19 @@
     modified_flash = true;
 
     ui->Print("\n-- Wiping data...\n");
-    bool success =
-        device->PreWipeData() &&
-        erase_volume("/data") &&
-        (has_cache ? erase_volume("/cache") : true) &&
-        device->PostWipeData();
+    bool success = device->PreWipeData();
+    if (success) {
+      success &= erase_volume(DATA_ROOT);
+      if (has_cache) {
+        success &= erase_volume(CACHE_ROOT);
+      }
+      if (volume_for_mount_point(METADATA_ROOT) != nullptr) {
+        success &= erase_volume(METADATA_ROOT);
+      }
+    }
+    if (success) {
+      success &= device->PostWipeData();
+    }
     ui->Print("Data wipe %s.\n", success ? "complete" : "failed");
     return success;
 }