Gitiles
Code Review Sign In
gerrit.twrp.me / android_bootable_recovery / 8569142147f8ba7ec6a3431f96aa00d66b45db61
commit8569142147f8ba7ec6a3431f96aa00d66b45db61[log] [tgz]
authorJohan Harvyl <johan.harvyl@sonymobile.com>Fri Aug 05 15:42:59 2016 +0200
committerJohan Redestig <johan.redestig@sonymobile.com>Mon Aug 08 08:28:30 2016 +0200
treec2f0d66fee901caecd5954f4d2b0aea101be4264
parent61240f88ead5c68424eab72194641a2310e59c3b [diff]
Handle error from fopen_path in finish_recovery

The fopen_path will fail here e.g. if /cache is corrupt and could
not be mounted. Not properly handling an error code from
fopen_path() results in a boot loop into recovery as fwrite() on
a NULL FILE object will crash the recovery app.

Change-Id: I1ccff5a8cb620a32f32adfe97a3fae8e5e908f39
1 file changed
tree: c2f0d66fee901caecd5954f4d2b0aea101be4264
  1. applypatch/
  2. edify/
  3. etc/
  4. fonts/
  5. minadbd/
  6. minui/
  7. minzip/
  8. otafault/
  9. res-hdpi/
  10. res-mdpi/
  11. res-xhdpi/
  12. res-xxhdpi/
  13. res-xxxhdpi/
  14. tests/
  15. tools/
  16. uncrypt/
  17. update_verifier/
  18. updater/
  19. res-560dpi ⇨ res-xxhdpi
  20. adb_install.cpp
  21. adb_install.h
  22. Android.mk
  23. asn1_decoder.cpp
  24. asn1_decoder.h
  25. bootloader.cpp
  26. bootloader.h
  27. CleanSpec.mk
  28. common.h
  29. default_device.cpp
  30. device.cpp
  31. device.h
  32. fuse_sdcard_provider.cpp
  33. fuse_sdcard_provider.h
  34. fuse_sideload.cpp
  35. fuse_sideload.h
  36. install.cpp
  37. install.h
  38. interlace-frames.py
  39. mounts.cpp
  40. mounts.h
  41. NOTICE
  42. print_sha1.h
  43. README.md
  44. recovery-persist.cpp
  45. recovery-persist.rc
  46. recovery-refresh.cpp
  47. recovery-refresh.rc
  48. recovery.cpp
  49. roots.cpp
  50. roots.h
  51. screen_ui.cpp
  52. screen_ui.h
  53. ui.cpp
  54. ui.h
  55. verifier.cpp
  56. verifier.h
  57. wear_ui.cpp
  58. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test