commit 7b87949ae148510e3c30a9879e6cb884228f8179
author Treehugger Robot <treehugger-gerrit@google.com> Thu Aug 08 01:24:29 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Aug 08 01:24:29 2019 +0000
tree eaa86f25080a33de712f5e6777dde0467d1a3629
parent c34e4e7fb58d335ed985e561752e300168b1db4c
parent e94b64ae864e5109d612ad31e78d4d9b2ac29435

Merge "bootloader_message: Remove global std::string"

bootloader_message/bootloader_message.cpp

diff --git a/bootloader_message/bootloader_message.cpp b/bootloader_message/bootloader_message.cpp
index e684abb..b15a9b9 100644
--- a/bootloader_message/bootloader_message.cpp
+++ b/bootloader_message/bootloader_message.cpp
@@ -20,6 +20,7 @@
 #include <fcntl.h>
 #include <string.h>
 
+#include <optional>
 #include <string>
 #include <string_view>
 #include <vector>
@@ -37,7 +38,7 @@
 using android::fs_mgr::Fstab;
 using android::fs_mgr::ReadDefaultFstab;
 
-static std::string g_misc_device_for_test;
+static std::optional<std::string> g_misc_device_for_test;
 
 // Exposed for test purpose.
 void SetMiscBlockDeviceForTest(std::string_view misc_device) {
@@ -45,8 +46,8 @@
 }
 
 static std::string get_misc_blk_device(std::string* err) {
-  if (!g_misc_device_for_test.empty()) {
-    return g_misc_device_for_test;
+  if (g_misc_device_for_test.has_value() && !g_misc_device_for_test->empty()) {
+    return *g_misc_device_for_test;
   }
   Fstab fstab;
   if (!ReadDefaultFstab(&fstab)) {