Gitiles
Code Review Sign In
gerrit.twrp.me / android_bootable_recovery / 71e182bc3879a53f04a50de9d25c333163cb7c76
commit71e182bc3879a53f04a50de9d25c333163cb7c76[log] [tgz]
authorTianjie Xu <xunchang@google.com>Wed Aug 31 18:06:33 2016 -0700
committerTianjie Xu <xunchang@google.com>Wed Aug 31 19:11:41 2016 -0700
tree4f116fad73bb81476238deb9a70313f54cd68246
parent818394869d36b9db1bf4984585a062d4bb91310f [diff]
Check an edge case when read(2) returns 0

We might end up in an infinite loop if read(2) reached EOF unexpectedly.
The problematic code in uncrypt mentioned in the bug has been fixed
by switching to libbase ReadFully(). So I grepped through the recovery
code and fixed some other occurences of the issue.

Bug: 31073201
Change-Id: Ib867029158ba23363b8f85d61c25058a635c5a6b
3 files changed
tree: 4f116fad73bb81476238deb9a70313f54cd68246
  1. applypatch/
  2. edify/
  3. etc/
  4. fonts/
  5. minadbd/
  6. minui/
  7. minzip/
  8. otafault/
  9. res-hdpi/
  10. res-mdpi/
  11. res-xhdpi/
  12. res-xxhdpi/
  13. res-xxxhdpi/
  14. tests/
  15. tools/
  16. uncrypt/
  17. update_verifier/
  18. updater/
  19. res-560dpi ⇨ res-xxxhdpi
  20. adb_install.cpp
  21. adb_install.h
  22. Android.mk
  23. asn1_decoder.cpp
  24. asn1_decoder.h
  25. bootloader.cpp
  26. bootloader.h
  27. CleanSpec.mk
  28. common.h
  29. default_device.cpp
  30. device.cpp
  31. device.h
  32. error_code.h
  33. fuse_sdcard_provider.cpp
  34. fuse_sdcard_provider.h
  35. fuse_sideload.cpp
  36. fuse_sideload.h
  37. install.cpp
  38. install.h
  39. interlace-frames.py
  40. mounts.cpp
  41. mounts.h
  42. NOTICE
  43. print_sha1.h
  44. README.md
  45. recovery-persist.cpp
  46. recovery-persist.rc
  47. recovery-refresh.cpp
  48. recovery-refresh.rc
  49. recovery.cpp
  50. roots.cpp
  51. roots.h
  52. screen_ui.cpp
  53. screen_ui.h
  54. ui.cpp
  55. ui.h
  56. verifier.cpp
  57. verifier.h
  58. wear_touch.cpp
  59. wear_touch.h
  60. wear_ui.cpp
  61. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test