commit 69608fe7548727ee765c89f69a6861479f391487
author Sami Tolvanen <samitolvanen@google.com> Tue Jun 09 21:15:15 2015 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Jun 09 21:17:20 2015 +0000
tree 46d64e674bd137408ae0cc04eb6ea74075af2050
parent 3f9db6af3d8f8659637da7288e9e2bceda4366d0
parent 96392b97f6bf1670d478494fb6df89a3410e53fa

Merge "Zero blocks before BLKDISCARD"

updater/blockimg.c

diff --git a/updater/blockimg.c b/updater/blockimg.c
index 5d0f156..dfba7e4 100644
--- a/updater/blockimg.c
+++ b/updater/blockimg.c
@@ -39,11 +39,6 @@
 
 #define BLOCKSIZE 4096
 
-// Set this to 0 to interpret 'erase' transfers to mean do a
-// BLKDISCARD ioctl (the normal behavior).  Set to 1 to interpret
-// erase to mean fill the region with zeroes.
-#define DEBUG_ERASE  0
-
 #ifndef BLKDISCARD
 #define BLKDISCARD _IO(0x12,119)
 #endif
@@ -1283,8 +1278,7 @@
     }
 
     if (params->cmdname[0] == 'z') {
-        // Update only for the zero command, as the erase command will call
-        // this if DEBUG_ERASE is defined.
+        // Update only for the zero command, as the erase command will call this
         params->written += tgt->size;
     }
 
@@ -1470,8 +1464,10 @@
     struct stat st;
     uint64_t blocks[2];
 
-    if (DEBUG_ERASE) {
-        return PerformCommandZero(params);
+    // Always zero the blocks first to work around possibly flaky BLKDISCARD
+    // Bug: 20881595
+    if (PerformCommandZero(params) != 0) {
+        goto pceout;
     }
 
     if (!params) {