otautil: Remove the aborts in RangeSet::Parse().

We used to CHECK and abort on parsing errors. While it works fine for
the updater use case (because recovery starts updater in a forked
process and collects the process exit code), it's difficult for other
clients to use RangeSet as a library (e.g. update_verifier).

This CL switches the aborts to returning empty RangeSet instead. Callers
need to check the parsing results explicitly.

The CL also separates RangeSet::PushBack() into a function, and moves
SortedRangeSet::Clear() into RangeSet.

Test: recovery_unit_test
Test: Sideload an OTA package with the new updater on angler.
Test: Sideload an OTA package with injected range string errors. The
      updater aborts from the explicit checks.
Change-Id: If2b7f6f41dc93af917a21c7877a83e98dc3fd016
4 files changed
tree: 521c5e1d88928db38f3a7aaa8e3dea76e307e78d
  1. applypatch/
  2. boot_control/
  3. bootloader_message/
  4. edify/
  5. etc/
  6. fonts/
  7. minadbd/
  8. minui/
  9. otafault/
  10. otautil/
  11. private/
  12. res-hdpi/
  13. res-mdpi/
  14. res-xhdpi/
  15. res-xxhdpi/
  16. res-xxxhdpi/
  17. tests/
  18. tools/
  19. uncrypt/
  20. update_verifier/
  21. updater/
  22. .clang-format
  23. adb_install.cpp
  24. adb_install.h
  25. Android.bp
  26. Android.mk
  27. asn1_decoder.cpp
  28. asn1_decoder.h
  29. bootloader.h
  30. CleanSpec.mk
  31. common.h
  32. default_device.cpp
  33. device.cpp
  34. device.h
  35. fuse_sdcard_provider.cpp
  36. fuse_sdcard_provider.h
  37. fuse_sideload.cpp
  38. fuse_sideload.h
  39. install.cpp
  40. install.h
  41. interlace-frames.py
  42. mounts.cpp
  43. mounts.h
  44. NOTICE
  45. OWNERS
  46. PREUPLOAD.cfg
  47. README.md
  48. recovery-persist.cpp
  49. recovery-persist.rc
  50. recovery-refresh.cpp
  51. recovery-refresh.rc
  52. recovery.cpp
  53. roots.cpp
  54. roots.h
  55. rotate_logs.cpp
  56. rotate_logs.h
  57. screen_ui.cpp
  58. screen_ui.h
  59. stub_ui.h
  60. ui.cpp
  61. ui.h
  62. verifier.cpp
  63. verifier.h
  64. vr_device.cpp
  65. vr_ui.cpp
  66. vr_ui.h
  67. wear_device.cpp
  68. wear_ui.cpp
  69. wear_ui.h

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test

Running the manual tests

recovery-refresh and recovery-persist executables exist only on systems without /cache partition. And we need to follow special steps to run tests for them.

  • Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.

  • Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.

ResourceTest validates whether the png files are qualified as background text image under recovery.

1. `adb sync data` to make sure the test-dir has the images to test.
2. The test will automatically pickup and verify all `_text.png` files in
   the test dir.