commit 619ec2f3aadb814cd09e412e832d94d5c4665ea6
author Jay Freeman (saurik) <saurik@saurik.com> Mon Nov 17 01:56:05 2008 +0000
committer Jean-Baptiste Queru <jbq@google.com> Tue Aug 25 12:53:40 2009 -0700
tree 531ff4e39ee3622cdf7e3fc3a99ef85fcc6ce82d
parent 34109de24e124dff020b26552d46b20299d779fd

Not all failures to fopen_root_path() are serious.
Example: E:Can't open /cache/recovery/command.

recovery.c

diff --git a/recovery.c b/recovery.c
index 0408abf..0ff5d94 100644
--- a/recovery.c
+++ b/recovery.c
@@ -129,7 +129,6 @@
     if (strchr("wa", mode[0])) dirCreateHierarchy(path, 0777, NULL, 1);
 
     FILE *fp = fopen(path, mode);
-    if (fp == NULL) LOGE("Can't open %s\n", path);
     return fp;
 }
 
@@ -218,7 +217,9 @@
     // By this point, we're ready to return to the main system...
     if (send_intent != NULL) {
         FILE *fp = fopen_root_path(INTENT_FILE, "w");
-        if (fp != NULL) {
+        if (fp == NULL) {
+            LOGE("Can't open %s\n", INTENT_FILE);
+        } else {
             fputs(send_intent, fp);
             check_and_fclose(fp, INTENT_FILE);
         }
@@ -226,7 +227,9 @@
 
     // Copy logs to cache so the system can find out what happened.
     FILE *log = fopen_root_path(LOG_FILE, "a");
-    if (log != NULL) {
+    if (log == NULL) {
+        LOGE("Can't open %s\n", LOG_FILE);
+    } else {
         FILE *tmplog = fopen(TEMPORARY_LOG_FILE, "r");
         if (tmplog == NULL) {
             LOGE("Can't open %s\n", TEMPORARY_LOG_FILE);