commit 5fa2e576f9b922675b364afc58f34e11ec7f7ce7
author Tianjie Xu <xunchang@google.com> Fri Feb 03 22:12:19 2017 +0000
committer android-build-merger <android-build-merger@google.com> Fri Feb 03 22:12:19 2017 +0000
tree 142570fc6ca714cb049538cbf13e8660cc617530
parent d40cd0e7cf4a4b5072b1c6994658024f79aaf399
parent 0f275ae56e2017db5ba2a712f84b710e8a9de99e

Merge "Avoid to call UI functions in child process"
am: 0f275ae56e

Change-Id: Ia1a735d6ca5c966e6e84c5fe67456c3b5142632e

install.cpp

diff --git a/install.cpp b/install.cpp
index 959a742..91e4875 100644
--- a/install.cpp
+++ b/install.cpp
@@ -382,7 +382,11 @@
     umask(022);
     close(pipefd[0]);
     execv(chr_args[0], const_cast<char**>(chr_args));
-    PLOG(ERROR) << "Can't run " << chr_args[0];
+    // Bug: 34769056
+    // We shouldn't use LOG/PLOG in the forked process, since they may cause
+    // the child process to hang. This deadlock results from an improperly
+    // copied mutex in the ui functions.
+    fprintf(stdout, "E:Can't run %s (%s)\n", chr_args[0], strerror(errno));
     _exit(-1);
   }
   close(pipefd[1]);