commit 5eaf3cd966f76a8d6676b2b949ae97ecc505b300
author Tianjie Xu <xunchang@google.com> Fri Feb 03 22:16:19 2017 +0000
committer android-build-merger <android-build-merger@google.com> Fri Feb 03 22:16:19 2017 +0000
tree 9a763722edac743ffc04fd1b8781b647f3a65fd8
parent f15097c98a97f73908757c3ec54239dfcd10b96a
parent 15ab95bb63d443a2576bf7837467706ac4962229

Merge "Avoid to call UI functions in child process" am: 0f275ae56e am: 5fa2e576f9
am: 15ab95bb63

Change-Id: Ifedf5d53d6ff11ecfeda4a8a1fe7f4e802c9e152

install.cpp

diff --git a/install.cpp b/install.cpp
index 553ebae..248a133 100644
--- a/install.cpp
+++ b/install.cpp
@@ -382,7 +382,11 @@
     umask(022);
     close(pipefd[0]);
     execv(chr_args[0], const_cast<char**>(chr_args));
-    PLOG(ERROR) << "Can't run " << chr_args[0];
+    // Bug: 34769056
+    // We shouldn't use LOG/PLOG in the forked process, since they may cause
+    // the child process to hang. This deadlock results from an improperly
+    // copied mutex in the ui functions.
+    fprintf(stdout, "E:Can't run %s (%s)\n", chr_args[0], strerror(errno));
     _exit(-1);
   }
   close(pipefd[1]);