Gitiles
Code Review Sign In
gerrit.twrp.me / android_bootable_recovery / 4f7faac8d705317271e1d6aa773f00f05ca70848
commit4f7faac8d705317271e1d6aa773f00f05ca70848[log] [tgz]
authorRahul Chaudhry <rahulchaudhry@google.com>Tue Nov 08 16:06:13 2016 -0800
committerRahul Chaudhry <rahulchaudhry@google.com>Tue Nov 08 16:34:01 2016 -0800
treeb1c1b9cd076b26723d7455b3880052250d270ac8
parentb66b94c56c476fbe7bf8a6e8328caffe9fd44b8f [diff]
Use static_cast to cast pointers returned by malloc/calloc/realloc/mmap.

static_cast is preferable to reinterpret_cast when casting from void*
pointers returned by malloc/calloc/realloc/mmap calls.

Discovered while looking at compiler warnings (b/26936282).

Test: WITH_TIDY=1 WITH_STATIC_ANALYZER=1 mma
Change-Id: I151642d5a60c94f312d0611576ad0143c249ba3d
6 files changed
tree: b1c1b9cd076b26723d7455b3880052250d270ac8
  1. applypatch/
  2. bootloader_message/
  3. edify/
  4. etc/
  5. fonts/
  6. minadbd/
  7. minui/
  8. otafault/
  9. otautil/
  10. res-hdpi/
  11. res-mdpi/
  12. res-xhdpi/
  13. res-xxhdpi/
  14. res-xxxhdpi/
  15. tests/
  16. tools/
  17. uncrypt/
  18. update_verifier/
  19. updater/
  20. res-560dpi ⇨ res-xxxhdpi
  21. adb_install.cpp
  22. adb_install.h
  23. Android.mk
  24. asn1_decoder.cpp
  25. asn1_decoder.h
  26. bootloader.h
  27. CleanSpec.mk
  28. common.h
  29. default_device.cpp
  30. device.cpp
  31. device.h
  32. error_code.h
  33. fuse_sdcard_provider.cpp
  34. fuse_sdcard_provider.h
  35. fuse_sideload.cpp
  36. fuse_sideload.h
  37. install.cpp
  38. install.h
  39. interlace-frames.py
  40. mounts.cpp
  41. mounts.h
  42. NOTICE
  43. print_sha1.h
  44. README.md
  45. recovery-persist.cpp
  46. recovery-persist.rc
  47. recovery-refresh.cpp
  48. recovery-refresh.rc
  49. recovery.cpp
  50. roots.cpp
  51. roots.h
  52. rotate_logs.cpp
  53. rotate_logs.h
  54. screen_ui.cpp
  55. screen_ui.h
  56. ui.cpp
  57. ui.h
  58. verifier.cpp
  59. verifier.h
  60. wear_touch.cpp
  61. wear_touch.h
  62. wear_ui.cpp
  63. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test

Running the manual tests

recovery-refresh and recovery-persist executables exist only on systems without /cache partition. And we need to follow special steps to run tests for them.

  • Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.

  • Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.