commit 486dc73135bd22ef7e6805dcee930e22a8511916
author Paul Crowley <paulcrowley@google.com> Tue Apr 24 20:03:05 2018 -0700
committer android-build-merger <android-build-merger@google.com> Tue Apr 24 20:03:05 2018 -0700
tree cc62dfe270c6a3ef015f2be0c02cf88360e25fbe
parent 482d722f5beca025b72a9efa8e327ce39ce0a0c0
parent bd56ab163a4afd6dd02c042206ad1abc721f54dc

Merge "Wipe the metadata partition when we wipe data." am: 897385bfe2 am: 62fd21b9bb
am: bd56ab163a

Change-Id: I76d9b121644deb382dca26906e98768f982b31d6

recovery.cpp

diff --git a/recovery.cpp b/recovery.cpp
index e266d93..15af9f0 100644
--- a/recovery.cpp
+++ b/recovery.cpp
@@ -108,6 +108,7 @@
 static const char *CONVERT_FBE_FILE = "/tmp/convert_fbe/convert_fbe";
 static const char *CACHE_ROOT = "/cache";
 static const char *DATA_ROOT = "/data";
+static const char* METADATA_ROOT = "/metadata";
 static const char *SDCARD_ROOT = "/sdcard";
 static const char *TEMPORARY_LOG_FILE = "/tmp/recovery.log";
 static const char *TEMPORARY_INSTALL_FILE = "/tmp/last_install";
@@ -752,11 +753,19 @@
     modified_flash = true;
 
     ui->Print("\n-- Wiping data...\n");
-    bool success =
-        device->PreWipeData() &&
-        erase_volume("/data") &&
-        (has_cache ? erase_volume("/cache") : true) &&
-        device->PostWipeData();
+    bool success = device->PreWipeData();
+    if (success) {
+      success &= erase_volume(DATA_ROOT);
+      if (has_cache) {
+        success &= erase_volume(CACHE_ROOT);
+      }
+      if (volume_for_mount_point(METADATA_ROOT) != nullptr) {
+        success &= erase_volume(METADATA_ROOT);
+      }
+    }
+    if (success) {
+      success &= device->PostWipeData();
+    }
     ui->Print("Data wipe %s.\n", success ? "complete" : "failed");
     return success;
 }