Gitiles
Code Review Sign In
gerrit.twrp.me / android_bootable_recovery / 3a8d98dd902da8b69cff731b3db03c75b176b751
commit3a8d98dd902da8b69cff731b3db03c75b176b751[log] [tgz]
authorTianjie Xu <xunchang@google.com>Mon Apr 03 20:01:17 2017 -0700
committerTianjie Xu <xunchang@google.com>Fri Apr 07 17:19:46 2017 -0700
treeaae8c6d44aea111c2c4813e4caae27cd2c4db5ce
parent3cd630a5a8d5a19dda9429af5494f19625bc2fa0 [diff]
Abort the update if there's not enough new data

Right now the update stuck in a deadlock if there's less new data than
expection. Add some checkers and abort the update if such case happens.
Also add a corresponding test.

Bug: 36787146
Test: update aborts correctly on bullhead && recovery_component_test passes
Change-Id: I914e4a2a4cf157b99ef2fc65bd21c6981e38ca47
2 files changed
tree: aae8c6d44aea111c2c4813e4caae27cd2c4db5ce
  1. applypatch/
  2. boot_control/
  3. bootloader_message/
  4. edify/
  5. etc/
  6. fonts/
  7. minadbd/
  8. minui/
  9. otafault/
  10. otautil/
  11. res-hdpi/
  12. res-mdpi/
  13. res-xhdpi/
  14. res-xxhdpi/
  15. res-xxxhdpi/
  16. tests/
  17. tools/
  18. uncrypt/
  19. update_verifier/
  20. updater/
  21. res-560dpi ⇨ res-xxxhdpi
  22. .clang-format
  23. adb_install.cpp
  24. adb_install.h
  25. Android.mk
  26. asn1_decoder.cpp
  27. asn1_decoder.h
  28. bootloader.h
  29. CleanSpec.mk
  30. common.h
  31. default_device.cpp
  32. device.cpp
  33. device.h
  34. error_code.h
  35. fuse_sdcard_provider.cpp
  36. fuse_sdcard_provider.h
  37. fuse_sideload.cpp
  38. fuse_sideload.h
  39. install.cpp
  40. install.h
  41. interlace-frames.py
  42. mounts.cpp
  43. mounts.h
  44. NOTICE
  45. print_sha1.h
  46. README.md
  47. recovery-persist.cpp
  48. recovery-persist.rc
  49. recovery-refresh.cpp
  50. recovery-refresh.rc
  51. recovery.cpp
  52. roots.cpp
  53. roots.h
  54. rotate_logs.cpp
  55. rotate_logs.h
  56. screen_ui.cpp
  57. screen_ui.h
  58. stub_ui.h
  59. ui.cpp
  60. ui.h
  61. verifier.cpp
  62. verifier.h
  63. wear_touch.cpp
  64. wear_touch.h
  65. wear_ui.cpp
  66. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test

Running the manual tests

recovery-refresh and recovery-persist executables exist only on systems without /cache partition. And we need to follow special steps to run tests for them.

  • Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.

  • Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.

ResourceTest validates whether the png files are qualified as background text image under recovery.

1. `adb sync data` to make sure the test-dir has the images to test.
2. The test will automatically pickup and verify all `_text.png` files in
   the test dir.