commit 2e947ea55eb2a6bd18351237bb3d83a4ad3df62c
author Yabin Cui <yabinc@google.com> Fri Feb 19 14:44:37 2016 -0800
committer Yabin Cui <yabinc@google.com> Fri Feb 19 17:54:25 2016 -0800
tree dcbdc2c4a8ad6021d18f7cb424ff31793a9edd2d
parent a029c9a45888141a2fa382e0b1868e55db1f36d2

Check each value read from block map file.

Bug: 26960931
Change-Id: I50b266ecb899db043831f528c2518bea76168c88

minzip/SysUtil.c

diff --git a/minzip/SysUtil.c b/minzip/SysUtil.c
index 491951c..de47edf 100644
--- a/minzip/SysUtil.c
+++ b/minzip/SysUtil.c
@@ -78,7 +78,7 @@
     if (blksize != 0) {
         blocks = ((size-1) / blksize) + 1;
     }
-    if (size == 0 || blksize == 0 || blocks > SIZE_MAX / blksize) {
+    if (size == 0 || blksize == 0 || blocks > SIZE_MAX / blksize || range_count == 0) {
         LOGE("invalid data in block map file: size %zu, blksize %u, range_count %u\n",
              size, blksize, range_count);
         return -1;
@@ -100,9 +100,6 @@
         return -1;
     }
 
-    pMap->ranges[range_count-1].addr = reserve;
-    pMap->ranges[range_count-1].length = blocks * blksize;
-
     int fd = open(block_dev, O_RDONLY);
     if (fd < 0) {
         LOGE("failed to open block device %s: %s\n", block_dev, strerror(errno));
@@ -112,28 +109,46 @@
     }
 
     unsigned char* next = reserve;
+    size_t remaining_size = blocks * blksize;
+    bool success = true;
     for (i = 0; i < range_count; ++i) {
-        int start, end;
-        if (fscanf(mapf, "%d %d\n", &start, &end) != 2) {
+        size_t start, end;
+        if (fscanf(mapf, "%zu %zu\n", &start, &end) != 2) {
             LOGE("failed to parse range %d in block map\n", i);
-            munmap(reserve, blocks * blksize);
-            free(pMap->ranges);
-            return -1;
+            success = false;
+            break;
+        }
+        size_t length = (end - start) * blksize;
+        if (end <= start || ((end - start) > SIZE_MAX / blksize) || length > remaining_size) {
+            LOGE("unexpected range in block map: %zu %zu\n", start, end);
+            success = false;
+            break;
         }
 
-        void* addr = mmap64(next, (end-start)*blksize, PROT_READ, MAP_PRIVATE | MAP_FIXED, fd, ((off64_t)start)*blksize);
+        void* addr = mmap64(next, length, PROT_READ, MAP_PRIVATE | MAP_FIXED, fd, ((off64_t)(start*blksize)));
         if (addr == MAP_FAILED) {
             LOGE("failed to map block %d: %s\n", i, strerror(errno));
-            munmap(reserve, blocks * blksize);
-            free(pMap->ranges);
-            return -1;
+            success = false;
+            break;
         }
         pMap->ranges[i].addr = addr;
-        pMap->ranges[i].length = (end-start)*blksize;
+        pMap->ranges[i].length = length;
 
-        next += pMap->ranges[i].length;
+        next += length;
+        remaining_size -= length;
+    }
+    if (success && remaining_size != 0) {
+        LOGE("ranges in block map are invalid: remaining_size = %zu\n", remaining_size);
+        success = false;
+    }
+    if (!success) {
+        close(fd);
+        munmap(reserve, blocks * blksize);
+        free(pMap->ranges);
+        return -1;
     }
 
+    close(fd);
     pMap->addr = reserve;
     pMap->length = size;
 
@@ -156,6 +171,7 @@
 
         if (sysMapBlockFile(mapf, pMap) != 0) {
             LOGE("Map of '%s' failed\n", fn);
+            fclose(mapf);
             return -1;
         }