Merge "Use flags = 0 to avoid fd closing for child updater process"
am: 50bda24f1e
Change-Id: I0ddb3f3cb29d63922f0c3972e5800f03bd5a85ac
diff --git a/install.cpp b/install.cpp
index b7fb788..ffa39e4 100644
--- a/install.cpp
+++ b/install.cpp
@@ -342,7 +342,9 @@
// The updater in child process writes to the pipe to communicate with recovery.
android::base::unique_fd pipe_read, pipe_write;
- if (!android::base::Pipe(&pipe_read, &pipe_write)) {
+ // Explicitly disable O_CLOEXEC using 0 as the flags (last) parameter to Pipe
+ // so that the child updater process will recieve a non-closed fd.
+ if (!android::base::Pipe(&pipe_read, &pipe_write, 0)) {
PLOG(ERROR) << "Failed to create pipe for updater-recovery communication";
return INSTALL_CORRUPT;
}