commit 0f275ae56e2017db5ba2a712f84b710e8a9de99e
author Treehugger Robot <treehugger-gerrit@google.com> Fri Feb 03 22:06:49 2017 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Feb 03 22:06:50 2017 +0000
tree 142570fc6ca714cb049538cbf13e8660cc617530
parent c44c4791979a4b2d87ef6b37dc1f7c3439425ddc
parent ab1abae59ccca2b5f1685ab7d279a0273ff9278b

Merge "Avoid to call UI functions in child process"

install.cpp

diff --git a/install.cpp b/install.cpp
index 959a742..91e4875 100644
--- a/install.cpp
+++ b/install.cpp
@@ -382,7 +382,11 @@
     umask(022);
     close(pipefd[0]);
     execv(chr_args[0], const_cast<char**>(chr_args));
-    PLOG(ERROR) << "Can't run " << chr_args[0];
+    // Bug: 34769056
+    // We shouldn't use LOG/PLOG in the forked process, since they may cause
+    // the child process to hang. This deadlock results from an improperly
+    // copied mutex in the ui functions.
+    fprintf(stdout, "E:Can't run %s (%s)\n", chr_args[0], strerror(errno));
     _exit(-1);
   }
   close(pipefd[1]);