commit 0b78610085aef48aa9ea422106be92337695d3e6
author Tao Bao <tbao@google.com> Thu May 28 00:09:06 2015 +0000
committer Android Git Automerger <android-git-automerger@android.com> Thu May 28 00:09:06 2015 +0000
tree 1740d5e309610ce3dc8c808b508450ff6eb34009
parent f505e7035c225284a6af71466ea56f5151f8c0e1
parent d026a28c22dfb15728b6db88d5b8e9b093de2fd7

am d026a28c: am 9a5e2a26: am f272b9e7: Merge "Clean up the sleep()\'s after poking init services"

* commit 'd026a28c22dfb15728b6db88d5b8e9b093de2fd7':
  Clean up the sleep()'s after poking init services

recovery.cpp

diff --git a/recovery.cpp b/recovery.cpp
index 80a8c7b..bfc6895 100644
--- a/recovery.cpp
+++ b/recovery.cpp
@@ -31,24 +31,24 @@
 #include <time.h>
 #include <unistd.h>
 
+#include <adb.h>
 #include <base/file.h>
 #include <base/stringprintf.h>
+#include <cutils/android_reboot.h>
+#include <cutils/properties.h>
 
+#include "adb_install.h"
 #include "bootloader.h"
 #include "common.h"
-#include "cutils/properties.h"
-#include "cutils/android_reboot.h"
+#include "device.h"
+#include "fuse_sdcard_provider.h"
+#include "fuse_sideload.h"
 #include "install.h"
 #include "minui/minui.h"
 #include "minzip/DirUtil.h"
 #include "roots.h"
 #include "ui.h"
 #include "screen_ui.h"
-#include "device.h"
-#include "adb_install.h"
-#include "adb.h"
-#include "fuse_sideload.h"
-#include "fuse_sdcard_provider.h"
 
 struct selabel_handle *sehandle;
 
@@ -1119,6 +1119,9 @@
             property_set(ANDROID_RB_PROPERTY, "reboot,");
             break;
     }
-    sleep(5); // should reboot before this finishes
+    while (true) {
+      pause();
+    }
+    // Should be unreachable.
     return EXIT_SUCCESS;
 }

ui.cpp

diff --git a/ui.cpp b/ui.cpp
index d88cbfe..2efb759 100644
--- a/ui.cpp
+++ b/ui.cpp
@@ -176,7 +176,7 @@
           case RecoveryUI::REBOOT:
             if (reboot_enabled) {
                 property_set(ANDROID_RB_PROPERTY, "reboot,");
-                while(1) { pause(); }
+                while (true) { pause(); }
             }
             break;
 

uncrypt/uncrypt.cpp

diff --git a/uncrypt/uncrypt.cpp b/uncrypt/uncrypt.cpp
index 11766f1..d71271d 100644
--- a/uncrypt/uncrypt.cpp
+++ b/uncrypt/uncrypt.cpp
@@ -40,18 +40,20 @@
 // file data to use as an update package.
 
 #include <errno.h>
+#include <fcntl.h>
+#include <linux/fs.h>
+#include <stdarg.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <stdarg.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
-#include <linux/fs.h>
 #include <sys/mman.h>
+#include <unistd.h>
 
 #define LOG_TAG "uncrypt"
 #include <log/log.h>
+#include <cutils/android_reboot.h>
 #include <cutils/properties.h>
 #include <fs_mgr.h>
 
@@ -376,7 +378,9 @@
 static void reboot_to_recovery() {
     ALOGI("rebooting to recovery");
     property_set("sys.powerctl", "reboot,recovery");
-    sleep(10);
+    while (true) {
+      pause();
+    }
     ALOGE("reboot didn't succeed?");
 }