)]}'
{"id":"android_vendor_twrp~7634","triplet_id":"android_vendor_twrp~android-14~I2b1644479788cb5c9568cac738202b1d55fc28d7","project":"android_vendor_twrp","branch":"android-14","hashtags":[],"change_id":"I2b1644479788cb5c9568cac738202b1d55fc28d7","subject":"kernel: Handle GKI modules","status":"MERGED","created":"2024-08-28 19:24:34.000000000","updated":"2024-09-07 13:46:49.000000000","submitted":"2024-09-07 13:46:49.000000000","submitter":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7689","meta_rev_id":"4bd01294e6acdfefb9d20ed14ceef5a52efa3ba2","_number":7634,"virtual_id_number":7634,"owner":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"all":[{"tag":"autogenerated:gerrit:newPatchSet","value":2,"date":"2024-09-07 13:45:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":38,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm"}],"REVIEWER":[{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-28 19:24:34.000000000","updated_by":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"reviewer":{"_account_id":38,"name":"Bruno Martins","email":"bgcngm@gmail.com","username":"bgcngm"},"state":"CC"}],"messages":[{"id":"9458abbfb89d1e76ae166e96a6332cb7c37bdd2b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"date":"2024-08-28 19:24:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f68efb15e7e2ae23dfa49cc8d620528cc34de908","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"date":"2024-09-07 13:45:56.000000000","message":"Uploaded patch set 2: Code-Review+2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"4bd01294e6acdfefb9d20ed14ceef5a52efa3ba2","tag":"autogenerated:gerrit:merged","author":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"date":"2024-09-07 13:46:49.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"34e56e636fc458af68c021c56b05825ae04ad538","revisions":{"22a4f78155f0e8d861e79e9dc90493c50c7c8cd8":{"kind":"REWORK","_number":1,"created":"2024-08-28 19:24:34.000000000","uploader":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"ref":"refs/changes/34/7634/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_vendor_twrp","ref":"refs/changes/34/7634/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/1 \u0026\u0026 git checkout -b change-7634 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/1","Reset To":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2084b3b0d5d0423e276ab60dedbf67f04ca1b37c","subject":"kernel: Support copying modules to recovery"}],"author":{"name":"Bruno Martins","email":"bgcngm@gmail.com","date":"2023-09-09 14:56:40.000000000","tz":60},"committer":{"name":"nebrassy","email":"nebras30@gmail.com","date":"2024-05-04 00:22:22.000000000","tz":120},"subject":"kernel: Handle GKI modules","message":"kernel: Handle GKI modules\n\nAll devices lauching with Android 13 (and above) must include\na system_dlkm partition, where GKI modules should reside.\n\nAndroid 13 build system only supports providing prebuilt modules,\nby pointing BOARD_SYSTEM_DLKM_SRC to the modules source folder.\nGoogle will introduce BOARD_SYSTEM_KERNEL_MODULES for Android 14,\nso take a step forward and use that macro to exclude the listed\nmodules from the usual vendor DLKM partition and place them into\nthe GKI module partition.\n\nNote that the GKI modules are placed into lib/modules/androidX-Y.Z,\nas defined by Google and observed in system_dlkm_modprobe script.\n\nChange-Id: I2b1644479788cb5c9568cac738202b1d55fc28d7\n"},"branch":"refs/heads/android-14"},"34e56e636fc458af68c021c56b05825ae04ad538":{"kind":"NO_CHANGE","_number":2,"created":"2024-09-07 13:45:56.000000000","uploader":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"ref":"refs/changes/34/7634/2","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_vendor_twrp","ref":"refs/changes/34/7634/2","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/2 \u0026\u0026 git checkout -b change-7634 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/2","Reset To":"git fetch https://gerrit.twrp.me/android_vendor_twrp refs/changes/34/7634/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f4ffe3018f153e822fbfc072da67d13c08b13305","subject":"kernel: Support copying modules to recovery"}],"author":{"name":"Bruno Martins","email":"bgcngm@gmail.com","date":"2023-09-09 14:56:40.000000000","tz":60},"committer":{"name":"nebrassy","email":"nebras30@gmail.com","date":"2024-09-07 13:45:39.000000000","tz":120},"subject":"kernel: Handle GKI modules","message":"kernel: Handle GKI modules\n\nAll devices lauching with Android 13 (and above) must include\na system_dlkm partition, where GKI modules should reside.\n\nAndroid 13 build system only supports providing prebuilt modules,\nby pointing BOARD_SYSTEM_DLKM_SRC to the modules source folder.\nGoogle will introduce BOARD_SYSTEM_KERNEL_MODULES for Android 14,\nso take a step forward and use that macro to exclude the listed\nmodules from the usual vendor DLKM partition and place them into\nthe GKI module partition.\n\nNote that the GKI modules are placed into lib/modules/androidX-Y.Z,\nas defined by Google and observed in system_dlkm_modprobe script.\n\nChange-Id: I2b1644479788cb5c9568cac738202b1d55fc28d7\n"},"branch":"refs/heads/android-14"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[],"atom_explanations":{}}}]}