)]}'
{"id":"android_device_samsung_beyond1lte~1269","triplet_id":"android_device_samsung_beyond1lte~android-9.0~I8358b5549f3f51d159d10a766d5cc0ff8e1e442d","project":"android_device_samsung_beyond1lte","branch":"android-9.0","hashtags":[],"change_id":"I8358b5549f3f51d159d10a766d5cc0ff8e1e442d","subject":"Use /system_root instead of /system as system block device mount point.","status":"MERGED","created":"2019-08-18 10:26:24.000000000","updated":"2019-08-18 11:23:06.000000000","submitted":"2019-08-18 10:55:34.000000000","submitter":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"271-1566125734354-7aad6c8","meta_rev_id":"ee127190e14fab9c251b452685da0a8c8e603ed0","_number":1269,"virtual_id_number":1269,"owner":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"all":[{"value":2,"date":"2019-08-18 10:55:20.000000000","_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":145,"name":"ivanmeler","email":"i_ivan@windowslive.com","username":"ivanmeler"}],"reviewers":{"CC":[{"_account_id":3,"name":"jenkins","username":"jenkins"}],"REVIEWER":[{"_account_id":145,"name":"ivanmeler","email":"i_ivan@windowslive.com","username":"ivanmeler"},{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-18 10:26:24.000000000","updated_by":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"reviewer":{"_account_id":145,"name":"ivanmeler","email":"i_ivan@windowslive.com","username":"ivanmeler"},"state":"REVIEWER"},{"updated":"2019-08-18 11:22:36.000000000","updated_by":{"_account_id":3,"name":"jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"jenkins","username":"jenkins"},"state":"CC"}],"messages":[{"id":"2e73ebc1d7ce876d70c987373ce252140f33eddf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"date":"2019-08-18 10:26:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3afb7f823194424f94db204c4dc54d6ff347cf60","author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"date":"2019-08-18 10:55:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6ba1a791fe013a7405ac69ef321114e1bfb7d2bc","tag":"autogenerated:gerrit:merged","author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"date":"2019-08-18 10:55:34.000000000","message":"Change has been successfully merged by Ian Macdonald","accounts_in_message":[],"_revision_number":1},{"id":"a7d2f90d77e4a41bc7ff306d5e7a7a2bbf1d032d","author":{"_account_id":3,"name":"jenkins","username":"jenkins"},"date":"2019-08-18 11:22:36.000000000","message":"Patch Set 1:\n\nBuild Started http://jenkins.twrp.me/job/Build%20Test%20Image/927/","accounts_in_message":[],"_revision_number":1},{"id":"ee127190e14fab9c251b452685da0a8c8e603ed0","author":{"_account_id":3,"name":"jenkins","username":"jenkins"},"date":"2019-08-18 11:23:06.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://jenkins.twrp.me/job/Build%20Test%20Image/927/ : Please check https://jenkins.twrp.me/view/test/ for the test image.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"102135c265846064310fb04708255e70c6c271cf","revisions":{"102135c265846064310fb04708255e70c6c271cf":{"kind":"REWORK","_number":1,"created":"2019-08-18 10:26:24.000000000","uploader":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"ref":"refs/changes/69/1269/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_device_samsung_beyond1lte","ref":"refs/changes/69/1269/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_device_samsung_beyond1lte refs/changes/69/1269/1 \u0026\u0026 git checkout -b change-1269 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_device_samsung_beyond1lte refs/changes/69/1269/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_device_samsung_beyond1lte refs/changes/69/1269/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_device_samsung_beyond1lte refs/changes/69/1269/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_device_samsung_beyond1lte refs/changes/69/1269/1","Reset To":"git fetch https://gerrit.twrp.me/android_device_samsung_beyond1lte refs/changes/69/1269/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7ef64a2bb91359cec983df6d374f8c68115bb4c1","subject":"Version 3.3.1-5_ianmacd."}],"author":{"name":"ivanmeler","email":"i_ivan@windowslive.com","date":"2019-08-11 17:54:27.000000000","tz":0},"committer":{"name":"Ian Macdonald","email":"ian@caliban.org","date":"2019-08-17 10:33:56.000000000","tz":120},"subject":"Use /system_root instead of /system as system block device mount point.","message":"Use /system_root instead of /system as system block device mount point.\n\nRationale by Ian Macdonald \u003cian@caliban.org\u003e:\n\nThis is a major change from previous versions of TWRP for the S10 range\nof devices and breaks compatibility with those versions.\n\nIf you create flashable zip files for the S10 range, please read on.\n\nrecovery.cpp contains the following code:\n\ncase Device::MOUNT_SYSTEM:\n  // For a system image built with the root directory\n  // (i.e. system_root_image \u003d\u003d \"true\"), we mount it to /system_root,\n  // and symlink /system to /system_root/system to make adb shell\n  // work (the symlink is created through the build system). (Bug: 22855115)\n  if (android::base::GetBoolProperty(\"ro.build.system_root_image\", false)) {\n    if (ensure_path_mounted_at(\"/\", \"/system_root\") !\u003d -1) {\n      ui-\u003ePrint(\"Mounted /system.\\n\");\n    }\n  } else {\n    if (ensure_path_mounted(\"/system\") !\u003d -1) {\n      ui-\u003ePrint(\"Mounted /system.\\n\");\n    }\n  }\n\nThis indicates that we should be mounting the system block device on\n/system_root, because the S10 range of devices are system-as-root\ndevices.\n\nUntil now, however, the system block device was mounted on /system. The\nSystem files were to be found one level deeper at /system/system.\n\nAs of this commit, the system block device is mounted on /system_root.\n/system is now a symlink to /system_root/system.\n\nThis is an incompatible change, because any flashable zip file\ncontaining installer code that attempts to `mount /system` will now\n(perhaps silently) fail, as will any code that expects /system to\ncontain the system-as-root files and /system/system to contain the\nactual System files.\n\nAll such code MUST now be modified to work with the new and intended\nfile-system structure.\n\nZip packages known to break with this commit include the the\nmulti-disabler-g97x \u003c v1.3, libsecure_storage-g97x \u003c v1.1 and\nAppLock-g97x \u003c v1.1.\n\nNew versions of these zips will be issued that work with versions of\nTWRP built either WITH or WITHOUT this commit.\n\nFinally, this patch also solves the following problem:\n\nbeyond2lte: /external_sd # ls -la /system/bin/\nls: /system/bin/: Too many symbolic links encountered\n\nChange-Id: I8358b5549f3f51d159d10a766d5cc0ff8e1e442d\n"},"branch":"refs/heads/android-9.0"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}