)]}'
{"id":"android_device_qcom_twrp-common~4265","triplet_id":"android_device_qcom_twrp-common~android-11~Ia18614b92fbbad18d5e55ef83920ee07bdca8ae2","project":"android_device_qcom_twrp-common","branch":"android-11","hashtags":[],"change_id":"Ia18614b92fbbad18d5e55ef83920ee07bdca8ae2","subject":"twrp-common: updates for Android 11","status":"MERGED","created":"2021-08-21 00:46:09.000000000","updated":"2021-08-22 19:07:40.000000000","submitted":"2021-08-21 03:39:02.000000000","submitter":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"total_comment_count":6,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"4265","meta_rev_id":"4b9d6980a3ca90389ea7305b83fa6d708dee2335","_number":4265,"virtual_id_number":4265,"owner":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"all":[{"value":2,"date":"2021-08-21 03:38:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":3,"name":"jenkins","username":"jenkins"},{"_account_id":720,"name":"russel5","username":"russel5"}],"REVIEWER":[{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-21 03:39:12.000000000","updated_by":{"_account_id":3,"name":"jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"jenkins","username":"jenkins"},"state":"CC"},{"updated":"2021-08-21 18:56:51.000000000","updated_by":{"_account_id":720,"name":"russel5","username":"russel5"},"reviewer":{"_account_id":720,"name":"russel5","username":"russel5"},"state":"CC"}],"messages":[{"id":"40ed516fd32a09869890b2e6fb0786c06832b69b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-21 00:46:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1265c1626fdc0cce764026df0f225acfc54e725e","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-21 03:38:56.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"271a67fe2792b35d73e707c8ac7ef60cb54c04e9","tag":"autogenerated:gerrit:merged","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-21 03:39:02.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"3efba5295ae9d8ffd99b21c87bca133e0afee88e","author":{"_account_id":3,"name":"jenkins","username":"jenkins"},"date":"2021-08-21 03:39:12.000000000","message":"Patch Set 1:\n\nBuild Started http://jenkins.twrp.me/job/Build%20Test%20Image/2059/","accounts_in_message":[],"_revision_number":1},{"id":"97c78e64aba7b9a91588956141deb27138ee1065","author":{"_account_id":3,"name":"jenkins","username":"jenkins"},"date":"2021-08-21 03:39:12.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://jenkins.twrp.me/job/Build%20Test%20Image/2059/ : Please check https://jenkins.twrp.me/view/test/ for the test image.","accounts_in_message":[],"_revision_number":1},{"id":"5c826be1c68df3e0aa1301e01f5bbe5d8ef6fa5a","author":{"_account_id":720,"name":"russel5","username":"russel5"},"date":"2021-08-21 18:56:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bb6b070c185de0d46b18c6d448988a7c34b89e7a","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-21 19:43:07.000000000","message":"Patch Set 1:\n\nThat means you\u0027re missing a service in one of your manifests. But this just adjusts the path to the one that A11 expects. Both A10 and A11 look in this path, so you may want to confirm the actual issue in logcat.","accounts_in_message":[],"_revision_number":1},{"id":"0df35f8693004343da597552735ca37911034c80","author":{"_account_id":720,"name":"russel5","username":"russel5"},"date":"2021-08-22 13:36:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cd289f705738dbac17a420a30f6aa4cbddaa06f9","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-22 13:42:31.000000000","message":"Patch Set 1:\n\nYou don\u0027t have any services in system/etc/vintf/manifest.xml and vendor/etc/vintf/manifest.xml in your OUT folder? Or are those files missing?","accounts_in_message":[],"_revision_number":1},{"id":"9c6c13628551f0548e1c200607c6975831e48b0a","author":{"_account_id":720,"name":"russel5","username":"russel5"},"date":"2021-08-22 15:44:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"536d831c2e5723b983bd5ce498e4bc1801c28729","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-22 15:52:33.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n \u003e \n \u003e (1 comment)\n\nDo you have that manifest in your device tree? It seems like that\u0027s what\u0027s missing. The one from twrp-common only writes what\u0027s found in the output folder, but if you have a manifest with more services that are needed, then you should have it in your device tree and that\u0027ll overwrite the created one. I\u0027m not sure where the \"missing\" one is in your tree. The system/manifest.xml is just getting ignored without this patch. Can you link your device tree?","accounts_in_message":[],"_revision_number":1},{"id":"39528b13082528c3e057981fe95fd81c8e1f9617","author":{"_account_id":720,"name":"russel5","username":"russel5"},"date":"2021-08-22 16:01:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"941a7a777d13347fe8827170f27d3f52e46f7848","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-22 16:04:44.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n \u003e \n \u003e (1 comment)\n\nI already told you what to do. Put the missing manifests in the correct location in the device tree and it\u0027ll take care of the issue.","accounts_in_message":[],"_revision_number":1},{"id":"11fd92dd4d14816e10c89183b97903e66e47a5e1","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-22 16:12:31.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n \u003e \n \u003e (1 comment)\n\nWhen I have time later I\u0027ll add a patch to only create the manifest if the file doesn\u0027t already exist. That should solve the problem, but putting the file in the device tree will workaround it in the meantime.","accounts_in_message":[],"_revision_number":1},{"id":"2487946fab0ac34530dff4ddc6afa2a4ccd924c9","author":{"_account_id":720,"name":"russel5","username":"russel5"},"date":"2021-08-22 16:21:55.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3b4ffdefa666c38dbde66d8ad945bb1864bfa586","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-22 16:30:29.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n \u003e \n \u003e (1 comment)\n\nThe code wasn\u0027t working before - it was putting the manifest in a place it wasn\u0027t used. This patch fixes it. A side effect of that is that it\u0027s deleting the manifest created by the build system, I guess, so I gave you a workaround to fix it until I can push the patch I mentioned to check for the existence of the file first. But the patch is necessary for devices that aren\u0027t using a build-system-generated manifest.","accounts_in_message":[],"_revision_number":1},{"id":"4b9d6980a3ca90389ea7305b83fa6d708dee2335","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2021-08-22 19:07:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1acce21123d73b2a93905d63a8da7827556628f7","revisions":{"1acce21123d73b2a93905d63a8da7827556628f7":{"kind":"REWORK","_number":1,"created":"2021-08-21 00:46:09.000000000","uploader":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"ref":"refs/changes/65/4265/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_device_qcom_twrp-common","ref":"refs/changes/65/4265/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_device_qcom_twrp-common refs/changes/65/4265/1 \u0026\u0026 git checkout -b change-4265 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_device_qcom_twrp-common refs/changes/65/4265/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_device_qcom_twrp-common refs/changes/65/4265/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_device_qcom_twrp-common refs/changes/65/4265/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_device_qcom_twrp-common refs/changes/65/4265/1","Reset To":"git fetch https://gerrit.twrp.me/android_device_qcom_twrp-common refs/changes/65/4265/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94b67cc5f69a38ecbca60c9c94ae5774c6b40a26","subject":"Merge \"twrp-common: fix derp\" into android-11"}],"author":{"name":"Captain Throwback","email":"captainthrowback@hotmail.com","date":"2021-08-21 00:43:48.000000000","tz":-240},"committer":{"name":"Captain Throwback","email":"captainthrowback@hotmail.com","date":"2021-08-21 00:43:48.000000000","tz":-240},"subject":"twrp-common: updates for Android 11","message":"twrp-common: updates for Android 11\n\n- Allow overriding for patchlevel and loglevel via\n  props set in device tree for prepdecrypt\n- Set manifest folder to etc/vintf\n\nChange-Id: Ia18614b92fbbad18d5e55ef83920ee07bdca8ae2\n"},"branch":"refs/heads/android-11"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}