)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"c42976d7e2a7e608295450606f5b8ad51869ffba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"83042f4b_553e3725","updated":"2021-12-19 20:42:23.000000000","message":"This will create a zip for any AB devices with these flags included. For recoveryimage target, the entire recovery.img will be included, and for bootimage, recovery-ramdisk.cpio will be included.\n\nI don\u0027t know if we actually want to merge this, but I made it available so at least people can create installer zips for local builds.","commit_id":"05a7baff7b3c3587f4d751357212453a482bdc93"},{"author":{"_account_id":28,"name":"Marc Bourgoin","email":"themard85@gmail.com","username":"ThEMarD"},"change_message_id":"bc5b4e0e61335f84a096c806e377b6fb77825301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6fa7c1b7_c9b3e15b","updated":"2021-12-20 04:38:21.000000000","message":"Tested with both make bootimage and make recoveryimage and both work now on patchset 8","commit_id":"19e1047482b810413725c4977b968bb7c5d5f06e"},{"author":{"_account_id":361,"name":"osm0sis","email":"osm0sis@outlook.com","username":"osm0sis"},"change_message_id":"736186551e137143a4ad8d8d0bbd3d6d5597f57a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"48abba77_412554f2","updated":"2021-12-20 17:47:33.000000000","message":"The patch description doesn\u0027t seem to explain that it\u0027s now also for recovery_a/_b devices, as it still talks about them only being for devices without dedicated recovery partitions.\n\nAny way to ensure it syncs up with the template at build time? We wouldn\u0027t want them getting out of sync like they have in the past when maintainers built their own, or before Jenkins kept it synced.\n\nAlso it\u0027s not actually necessary for the ramdisk to be uncompressed; in the boot-as-recovery/RECOVERY_AS_BOOT scenario, provided the underlying kernel supports it, a compressed ramdisk could be included and magiskboot automatically accepts it in a recognized format instead of recompressing.","commit_id":"19e1047482b810413725c4977b968bb7c5d5f06e"},{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"96be99d53b82e087cea8171abb671292655bb3a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6eee371a_f9e3e489","updated":"2021-12-20 16:18:15.000000000","message":"Updates are working fine for me.","commit_id":"19e1047482b810413725c4977b968bb7c5d5f06e"},{"author":{"_account_id":361,"name":"osm0sis","email":"osm0sis@outlook.com","username":"osm0sis"},"change_message_id":"ada88a93fb1d8cb0593844daaa3192ce39155b06","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1260e135_fbadc08e","updated":"2021-12-21 02:40:25.000000000","message":"\u003e Patch Set 10:\n\u003e \n\u003e \u003e Patch Set 10:\n\u003e  \u003e \n\u003e  \u003e (1 comment)\n\u003e \n\u003e I think what you\u0027re suggesting will just make this more complicated, tbh. Not sure what the issue is with the way its presently being done in the patch?\n\nI thought it would actually make the process simplified, since then you wouldn\u0027t need to build the ramdisk twice anymore (once compressed for the .img and once uncompressed for the .zip), you could just build it once (compressed) for the .img and then copy it over for the .zip.\n\nBut suit yourselves, just providing more info on how magiskboot works in case it was helpful. :)","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":539,"name":"Mohammad Afaneh","display_name":"afaneh92","username":"mohammad92"},"change_message_id":"e7d8f6adf3e384f9e597c7b494f5464a748f683f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"059dc7e0_1151e34f","updated":"2021-12-20 18:48:31.000000000","message":"\u003e Patch Set 10:\n\u003e \n\u003e \u003e Patch Set 10:\n\u003e  \u003e \n\u003e  \u003e (1 comment)\n\u003e \n\u003e You can rebase your patch on this one.\n\u003e \n\u003e I\u0027m confused, are you saying you need this on an A-only device? Because that\u0027s not the purpose of this zip installer. What you\u0027re describing is for something else.\nNo, Im saying this commit doesn\u0027t belong to me, but conflict with my commit. so if ramdisk not needed to be uncompressed then we can solve the conflict. \n","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":361,"name":"osm0sis","email":"osm0sis@outlook.com","username":"osm0sis"},"change_message_id":"02936bcc7a59b6d6e96c68f23a2acb6473aa1639","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6224f31a_669e13b1","updated":"2021-12-20 19:08:49.000000000","message":"\u003e Patch Set 8: -Code-Review\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e  \u003e \n\u003e  \u003e (1 comment)\n\u003e This is only for local builds. This is unrelated to Jenkins, so we can\u0027t control whether or not the builder is syncing the template before building.\n\u003e \n\u003e The compressed ramdisk isn\u0027t in cpio format, which is why the uncompressed is used. Are you saying we could instead include ramdisk-recovery.img and the zip template would handle it fine?\n\nI\u0027m not familiar with the whole build process here, but if recovery-ramdisk.img is really in the format of ramdisk.cpio.gz or ramdisk.cpio.lzma or whatever, then yes, magiskboot happily accepts these without recompressing, to allow changing the compassion format of a ramdisk in an image, it just still needs to be named ramdisk.cpio for magiskboot itself to find it.\n\nSo, long story short, no need to separately pack uncompressed cpio as long as the kernel can handle whatever the format is (lz4, lzma or whatever), as long as it\u0027s named ramdisk-twrp.cpio or ramdisk-recovery.cpio for inclusion in the twrp_abtemplate zip. :)","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":487,"name":"DarthJabba9","email":"darthjabba9@gmail.com","username":"DarthJabba9"},"change_message_id":"e26d02a97397db4bdd6027799705d1187a164843","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9a8adc18_cdf8d354","updated":"2021-12-23 12:12:12.000000000","message":"If you want to identify the specific device, just change all occurrences of \"recovery-installer\" to \"$(PRODUCT_DEVICE)-recovery-installer\" (or to \"$(PRODUCT_NAME)-recovery-installer\"), and you are done.","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":539,"name":"Mohammad Afaneh","display_name":"afaneh92","username":"mohammad92"},"change_message_id":"22ddb89bdbbc85c05a168a40d897a5fd0b786c0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e302410f_44b19a0d","updated":"2021-12-20 18:40:09.000000000","message":"agreed with osm0sis, I dont have A/B devices. Samsung A only.\nCan you update to not conflict with BOARD_CUSTOM_BOOTIMG_MK support.\nI would like to use mkbootimg to resize the final recovery.img then make it flashable tarball\n ","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":739,"name":"infectedmushi","display_name":"infectedmushi","email":"zzitoz@gmail.com","username":"infectedmushi"},"change_message_id":"594de3c65dfa9b5f0f7c91375aec695f39a31610","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2b28fa8c_cf8150ce","updated":"2021-12-21 21:12:26.000000000","message":"working like a charme here.\n\n/home/infected_/Out/twrp/target/product/instantnoodle/recovery-installer.zip\n\nis it possible to rename the created zip at the time of creation?","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"e0995dafe0edaf9d4a693d0bb519adb8bc636d95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f33b0c86_1fc92671","in_reply_to":"1260e135_fbadc08e","updated":"2021-12-21 20:02:40.000000000","message":"If someone wants to test and see if the compressed ramdisk works, be my guest. But I know it\u0027s working presently, so I\u0027ll leave that up to others.","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":28,"name":"Marc Bourgoin","email":"themard85@gmail.com","username":"ThEMarD"},"change_message_id":"67a1f9813f42963c16a743c55c319bbf021f94ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f966325c_a3397b97","in_reply_to":"2b28fa8c_cf8150ce","updated":"2021-12-21 21:31:52.000000000","message":"yes it would be possible, we would need to change it up in this commit on how it would be named but tbh I\u0027m lazy and I just rename it manually afterwards for my test builds I send to my users","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":361,"name":"osm0sis","email":"osm0sis@outlook.com","username":"osm0sis"},"change_message_id":"ada88a93fb1d8cb0593844daaa3192ce39155b06","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4ed4a6f6_c28cb496","in_reply_to":"6224f31a_669e13b1","updated":"2021-12-21 02:40:25.000000000","message":"s/compassion/compression ;)","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"},{"author":{"_account_id":487,"name":"DarthJabba9","email":"darthjabba9@gmail.com","username":"DarthJabba9"},"change_message_id":"e26d02a97397db4bdd6027799705d1187a164843","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e856b04f_fc5ec80f","in_reply_to":"f966325c_a3397b97","updated":"2021-12-23 12:12:12.000000000","message":"If you want to identify the specific device, just change all occurrences of \"recovery-installer\" to \"$(PRODUCT_DEVICE)-recovery-installer\" (or to \"$(PRODUCT_NAME)-recovery-installer\"), and you are done.","commit_id":"1bd6f8c6f6b5d6f3e50a6919587997bb05f48784"}],"core/Makefile":[{"author":{"_account_id":28,"name":"Marc Bourgoin","email":"themard85@gmail.com","username":"ThEMarD"},"change_message_id":"2043404453f3f68500022bb0f2d167d945fddb52","unresolved":true,"context_lines":[{"line_number":2309,"context_line":"ifeq ($(AB_OTA_UPDATER),true)"},{"line_number":2310,"context_line":"ifeq ($(USE_RECOVERY_INSTALLER),true)"},{"line_number":2311,"context_line":"ifneq ($(RECOVERY_INSTALLER_PATH),)"},{"line_number":2312,"context_line":"\tcp -fr $(RECOVERY_INSTALLER_PATH) $(PRODUCT_OUT)/installer \u0026\u0026 cp -f $(recovery_uncompressed_ramdisk) $(PRODUCT_OUT)/installer \u0026\u0026 cd $(PRODUCT_OUT)/installer \u0026\u0026 zip -qr recovery-installer META-INF magiskboot ramdisk-recovery.cpio \u0026\u0026 cp -f $(PRODUCT_OUT)/installer/recovery-installer.zip $(PRODUCT_OUT) \u0026\u0026 rm $(PRODUCT_OUT)/installer/recovery-installer.zip \u0026\u0026 rm $(PRODUCT_OUT)/installer/ramdisk-recovery.cpio"},{"line_number":2313,"context_line":"\t$(call pretty,\"Making recovery installer for A/B devices: $(PRODUCT_OUT)/recovery-installer.zip\")"},{"line_number":2314,"context_line":"endif"},{"line_number":2315,"context_line":"endif"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9090dc40_5a8e0e42","line":2312,"range":{"start_line":2312,"start_character":130,"end_line":2312,"end_character":157},"updated":"2021-12-20 04:42:48.000000000","message":"I had to make that patchset 8 because of this cd before the zip creation.","commit_id":"05a7baff7b3c3587f4d751357212453a482bdc93"},{"author":{"_account_id":28,"name":"Marc Bourgoin","email":"themard85@gmail.com","username":"ThEMarD"},"change_message_id":"2043404453f3f68500022bb0f2d167d945fddb52","unresolved":true,"context_lines":[{"line_number":2322,"context_line":"ifeq ($(AB_OTA_UPDATER),true)"},{"line_number":2323,"context_line":"ifeq ($(USE_RECOVERY_INSTALLER),true)"},{"line_number":2324,"context_line":"ifneq ($(RECOVERY_INSTALLER_PATH),)"},{"line_number":2325,"context_line":"\tcp -fr $(RECOVERY_INSTALLER_PATH) $(PRODUCT_OUT)/installer \u0026\u0026 cp -f $(INSTALLED_RECOVERYIMAGE_TARGET) $(PRODUCT_OUT)/installer \u0026\u0026 cd $(PRODUCT_OUT)/installer \u0026\u0026 zip -qr recovery-installer META-INF magiskboot recovery.img \u0026\u0026 cp -f recovery-installer.zip ../ \u0026\u0026 rm recovery-installer.zip \u0026\u0026 rm recovery.img"},{"line_number":2326,"context_line":"\t$(call pretty,\"Making recovery installer for A/B devices: $(PRODUCT_OUT)/recovery-installer.zip\")"},{"line_number":2327,"context_line":"endif"},{"line_number":2328,"context_line":"endif"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"0b6ea321_afa013dc","line":2325,"range":{"start_line":2325,"start_character":69,"end_line":2325,"end_character":102},"updated":"2021-12-20 04:42:48.000000000","message":"I also decided to use this to ensure it properly found the ramdisk.img","commit_id":"19e1047482b810413725c4977b968bb7c5d5f06e"},{"author":{"_account_id":28,"name":"Marc Bourgoin","email":"themard85@gmail.com","username":"ThEMarD"},"change_message_id":"2043404453f3f68500022bb0f2d167d945fddb52","unresolved":true,"context_lines":[{"line_number":2322,"context_line":"ifeq ($(AB_OTA_UPDATER),true)"},{"line_number":2323,"context_line":"ifeq ($(USE_RECOVERY_INSTALLER),true)"},{"line_number":2324,"context_line":"ifneq ($(RECOVERY_INSTALLER_PATH),)"},{"line_number":2325,"context_line":"\tcp -fr $(RECOVERY_INSTALLER_PATH) $(PRODUCT_OUT)/installer \u0026\u0026 cp -f $(INSTALLED_RECOVERYIMAGE_TARGET) $(PRODUCT_OUT)/installer \u0026\u0026 cd $(PRODUCT_OUT)/installer \u0026\u0026 zip -qr recovery-installer META-INF magiskboot recovery.img \u0026\u0026 cp -f recovery-installer.zip ../ \u0026\u0026 rm recovery-installer.zip \u0026\u0026 rm recovery.img"},{"line_number":2326,"context_line":"\t$(call pretty,\"Making recovery installer for A/B devices: $(PRODUCT_OUT)/recovery-installer.zip\")"},{"line_number":2327,"context_line":"endif"},{"line_number":2328,"context_line":"endif"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"49b57ec9_6d8fa4d9","line":2325,"range":{"start_line":2325,"start_character":290,"end_line":2325,"end_character":305},"updated":"2021-12-20 04:42:48.000000000","message":"and just like the rm on the ramdisk-recovery.cpio on make bootimage, we should nuke the installer/ramdisk.img to ensure any dirty builds won\u0027t have to risk dealing with it","commit_id":"19e1047482b810413725c4977b968bb7c5d5f06e"}]}