)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"efdccfa091a75ee926ffd5b3dd790dadd0675aac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b11c29f_3bd7c776","updated":"2024-02-09 21:15:41.000000000","message":"What exactly does this fix?","commit_id":"b3d575b476fe1d16f1043817e302ed011940ab1a"},{"author":{"_account_id":783,"name":"sekaiacg","email":"sekaiacg@gmail.com","username":"sekaiacg"},"change_message_id":"fda6ea3611eba519dc2d93242293ae7642779467","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92a79afc_9fba2528","in_reply_to":"2876c335_91f8a51c","updated":"2024-02-10 17:11:37.000000000","message":"printf(\"ramdisk_format\u003d%s\\n\", ramdisk_format.c_str());\nramdisk_format\u003dgzip","commit_id":"b3d575b476fe1d16f1043817e302ed011940ab1a"},{"author":{"_account_id":783,"name":"sekaiacg","email":"sekaiacg@gmail.com","username":"sekaiacg"},"change_message_id":"10236a10644f9a2103a3bb6f2ca07155abea7ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85c04e50_938d2374","in_reply_to":"5b11c29f_3bd7c776","updated":"2024-02-10 12:57:47.000000000","message":"Incorrect results in new version of magiskboot:\nramdisk_format\u003dgzipunexpectedASN.1DERtag:expectedSEQUENCE,gotAPPLICATION1(primitive)VBMETA","commit_id":"b3d575b476fe1d16f1043817e302ed011940ab1a"},{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"0c390fd1c0e5f4ff108c71056bb6096c078a113e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2876c335_91f8a51c","in_reply_to":"85c04e50_938d2374","updated":"2024-02-10 16:37:40.000000000","message":"And what does the correct output look like?","commit_id":"b3d575b476fe1d16f1043817e302ed011940ab1a"},{"author":{"_account_id":487,"name":"DarthJabba9","email":"darthjabba9@gmail.com","username":"DarthJabba9"},"change_message_id":"eb618af4b4b8107c3c8c564a9e67d51687be3fa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45d120cc_0f92274b","updated":"2024-02-10 19:55:10.000000000","message":"I get this:\n\nRAMDISK_FMT     [lz4_legacy]\nunknown/unsupported ASN.1 DER tag: 0x00","commit_id":"e67d39d485d8ec3e41400b89b147d8453285ba34"},{"author":{"_account_id":487,"name":"DarthJabba9","email":"darthjabba9@gmail.com","username":"DarthJabba9"},"change_message_id":"655b413e044bae237f4de591f50009044a16d7d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83799b37_9679bc17","updated":"2024-02-11 20:02:22.000000000","message":"The example code runs correctly when compiled standalone (incidentally, with g++, as clang wouldn\u0027t compile it). It is fine for it to run correctly when compiled as a standalone program on linux - nevertheless, my TWRP builds (on alioth) still show that error.","commit_id":"e67d39d485d8ec3e41400b89b147d8453285ba34"},{"author":{"_account_id":487,"name":"DarthJabba9","email":"darthjabba9@gmail.com","username":"DarthJabba9"},"change_message_id":"ae118530ba278c730432ccbb2361aa447dea4a8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3442a3fc_5172d078","updated":"2024-02-11 07:29:15.000000000","message":"With the patch.","commit_id":"e67d39d485d8ec3e41400b89b147d8453285ba34"},{"author":{"_account_id":487,"name":"DarthJabba9","email":"darthjabba9@gmail.com","username":"DarthJabba9"},"change_message_id":"8fe4b6559ec17ae42760435e1b230396af2ffb29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc336092_1a129b49","updated":"2024-02-13 16:54:21.000000000","message":"magisk_unpack_output\u003dParsing boot image: [/tmp/repackorig/boot.img]\nHEADER_VER      [3]\nKERNEL_SZ       [46622736]\nRAMDISK_SZ      [33292193]\nOS_VERSION      [14.0.0]\nOS_PATCH_LEVEL  [2023-12]\nPAGESIZE        [4096]\nCMDLINE         []\nKERNEL_FMT      [raw]\nRAMDISK_FMT     [lz4_legacy]\nunknown/unsupported ASN.1 DER tag: 0x00","commit_id":"e67d39d485d8ec3e41400b89b147d8453285ba34"},{"author":{"_account_id":783,"name":"sekaiacg","email":"sekaiacg@gmail.com","username":"sekaiacg"},"change_message_id":"8c37660fe2e9a12f03a1dc61502a8c4c77f22de3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b242e15d_759c37cf","in_reply_to":"3442a3fc_5172d078","updated":"2024-02-11 12:59:06.000000000","message":"Is there a bug in this patch? I\u0027ve provided a test example.\n\n#include \u003cstdio.h\u003e\n#include \u003calgorithm\u003e\n#include \u003cstring\u003e\n\nusing namespace std;\n\nint main(int argc, char *argv[]) {\n\tstd::string magisk_unpack_output \u003d \"\"\n\t\t\"Parsing boot image: [recovery.img]\\n\"\n\t\t\"HEADER_VER      [4]\\n\"\n\t\t\"KERNEL_SZ       [0]\\n\"\n\t\t\"RAMDISK_SZ      [25648818]\\n\"\n\t\t\"PAGESIZE        [4096]\\n\"\n\t\t\"CMDLINE         []\\n\"\n\t\t\"RAMDISK_FMT     [lz4_legacy]\\n\"\n\t\t\"unexpected ASN.1 DER tag: expected SEQUENCE, got APPLICATION [1] (primitive)\\n\"\n\t\t\"VBMETA\\n\";\n\tstd::string txt_to_find \u003d \"RAMDISK_FMT\";\n\tstd::string ramdisk_format;\n\tauto pos \u003d magisk_unpack_output.find(txt_to_find);\n\tif (pos !\u003d std::string::npos) {\n\t\tauto start \u003d magisk_unpack_output.find(\u0027[\u0027, pos + txt_to_find.size());\n\t\t\tif (start !\u003d std::string::npos) {\n\t\t\t\tauto end \u003d magisk_unpack_output.find(\u0027]\u0027, start);\n\t\t\t\tif (end !\u003d std::string::npos) {\n\t\t\t\t\tramdisk_format \u003d std::move(magisk_unpack_output.substr(start + 1, end - start - 1));\n\t\t\t\t}\n\t\t}\n\t}\n\tprintf(\"ramdisk_format\u003d%s\\n\", ramdisk_format.c_str());\n\treturn 0;\n}\n\nclang -o example example.cpp -lstdc++ -std\u003dc++20","commit_id":"e67d39d485d8ec3e41400b89b147d8453285ba34"},{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"518896c88a0c8cc7d6a76d4159d9b62a14488583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff1e48a7_c4779640","in_reply_to":"45d120cc_0f92274b","updated":"2024-02-11 00:35:44.000000000","message":"Is that with the patch or without it?","commit_id":"e67d39d485d8ec3e41400b89b147d8453285ba34"},{"author":{"_account_id":783,"name":"sekaiacg","email":"sekaiacg@gmail.com","username":"sekaiacg"},"change_message_id":"26a8bb60137b39575936c8877e2f379dfe7392ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f727dd1_f6155fb7","in_reply_to":"83799b37_9679bc17","updated":"2024-02-12 01:45:09.000000000","message":"This is just the find and substr functions in string, I don\u0027t think there will be any different behavior.\nIf possible, please provide the content of magisk_unpack_output and I will analyze it.","commit_id":"e67d39d485d8ec3e41400b89b147d8453285ba34"}]}