)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"fd2c41e02c40d2da032be1f5f6dcefdb0aa87f69","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c71f2ab6_9ae4c15e","updated":"2023-11-20 05:52:05.000000000","message":"\u003e Does it work if fstab filesystem is set to vfat?\n\nNope, exact same issue.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"820b7b6b29908a9475bc36f6e3d97217c214ed00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fef53c9_1171c711","updated":"2023-11-20 19:56:06.000000000","message":"I checked again without any patch, and with this patch only, and confirm it _triggers_ this issue when external SD is the already selected storage while booting recovery. \n\nIssue does not occur when Internal SD is the already selected storage while booting recovery ; it that case external sd is mounted ok.\n\n\n\u003e fuse: mountpoint is not empty\n\u003e fuse: if you are sure this is safe, use the \u0027nonempty\u0027 mount option\n\nIn External sd mount point (/sdcard1 here), there\u0027s only an empty TWRP directory.\nDeleting it makes external sd mountable again.\n\nSo i guess /sdcard1/TWRP is created sooner than without the patch, or it is created but it should not.\n\nMaybe some adaptations and/or conditional tests could be added to https://github.com/TeamWin/android_bootable_recovery/blob/android-12.1/twrp-functions.cpp#L1414 but i don\u0027t think i can suggest more as i don\u0027t know TWRP code structure and logic... maybe i already crossed my ignorance line a few lines ago :)","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"ef5d8efe248cdca45f11e4f3609278dc92564c60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29b81831_ac49e223","updated":"2023-11-03 20:35:25.000000000","message":"This seems important.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"6b944320ceaea7705705b82ea48bd0c338df6322","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8bf2b8ed_0b2ffc77","updated":"2023-11-20 05:34:43.000000000","message":"With this change, on sdm660 with disabled crypto support, settings are saved.\n\nBut : \n- if internal SD is the selected storage before booting to recovery, i can select external SD and use it.\n\n- if external SD is the selected storage before booting to recovery, external sdcard can\u0027t be mounted.\nIn dmesg : \n[   83.959657] FAT-fs (mmcblk1p1): bogus number of reserved sectors\n[   83.959668] FAT-fs (mmcblk1p1): Can\u0027t find a valid FAT filesystem\n\nIn fstab external sd fs is set to \"auto\".\nhttps://github.com/pix106/android_device_xiaomi_clover/blob/fox_12.1-4.19/recovery/root/system/etc/twrp.flags#L36","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1180,"name":"ghazzor","username":"ghazzor"},"change_message_id":"9d27d171f3a0bd01e2ee225956363d18c069a555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aabbe837_ab0c4750","updated":"2023-10-25 13:25:06.000000000","message":"nice , works for me on my exynos device with fbe","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"f5debec639c4da6e14ba2ecc2c4359b2bbf3bcec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2c94445_21a98583","in_reply_to":"0fef53c9_1171c711","updated":"2023-11-20 20:25:23.000000000","message":"Looking at the code, the check needs to be done here https://github.com/TeamWin/android_bootable_recovery/blob/android-12.1/twrp-functions.cpp#L1453 to prevent the folder from being created when an external card is chosen. My device doesn\u0027t have an external card, but I\u0027ll see if I can simulate the same error with an USB-OTG and try to find a solution. Thanks for the update.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"10ac7063791babb3626bd792b8ce5d7f8153c410","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cde0645d_57279e08","in_reply_to":"18c949eb_a1692b59","updated":"2023-11-22 16:34:20.000000000","message":"So I was wrong, lol… I apologize, everyone. @Pix106 and @brigudav, I’ve uploaded a new patch, could you test it again?","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":336,"name":"brigudav","display_name":"brigudav","username":"brigudav"},"change_message_id":"b05590542ecde9d56e45bb66db480169f688af0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8035200c_ef2f42d9","in_reply_to":"242279bb_4a5826ee","updated":"2023-11-24 10:24:04.000000000","message":"With this change, the settings are saved in /data/recovery/.twrps, but when you reboot twrp does not load its settings, as if they are not there, but in fact the file itself is present.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":336,"name":"brigudav","display_name":"brigudav","username":"brigudav"},"change_message_id":"0241be224c8466be534c0a5e81902fd9f619ec3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"338041c6_e5411f69","in_reply_to":"29e23d80_ade91c46","updated":"2023-11-24 11:08:53.000000000","message":"https://github.com/brigudav/android_device_xiaomi_surya_twrp/actions\nCompilation takes place on the server. Loads all the latest changes, and I also add patches from here. Regarding the problem - your patch is now working and the external card is being mounted. The settings begin to load if you change the twrp folder to your own. The question can be closed. Thanks for corrections.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"3d4ef1cd47d9b1f998636907c2f67bd4681afce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4fb0bc82_8bbaa0ad","in_reply_to":"338041c6_e5411f69","updated":"2023-11-24 11:33:26.000000000","message":"Ok, anyway, I\u0027m going to run some tests to see if I can simulate that extra slash, and I\u0027ll let you know if I find out. Thank you very much for helping me with these fixes.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"a7fd7a83876d8775397cf6660de6dcc097d6d8bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f40874c0_eaa59d95","in_reply_to":"379f32fb_cf38c0fb","updated":"2023-11-20 15:30:51.000000000","message":"yes, but i had this issue with this patch way before using exfat 1.3.0 patch.\n\nI\u0027ve had this issue since the day after it was pushed here, but did not report before because of gerrit asking too much permissions when joining (i posted it in zulip yesterday, bigbiff fixed gerrit config)","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"b8c100878d83cfd34e532c958154d86d3c86891e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29e23d80_ade91c46","in_reply_to":"37e2b4d8_38d0a48b","updated":"2023-11-24 10:56:25.000000000","message":"Weird, I don\u0027t see that extra slash in my logs. Are you using the latest patch (5) and the Teamwin bootable/recovery repo?","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"a7fd7a83876d8775397cf6660de6dcc097d6d8bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"786a3d43_c152905f","in_reply_to":"5c3e6497_e74ac5b9","updated":"2023-11-20 15:30:51.000000000","message":"yes, removing this patch, and no other, fixes the issue in my builds","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"3b654711ffa2440beb4bb5590c22e548e6ce319f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c3e6497_e74ac5b9","in_reply_to":"5de57af6_84e0e236","updated":"2023-11-20 11:09:33.000000000","message":"Are you sure it\u0027s this patch causing these errors? Because there\u0027s no change in the mounting of any partition in it. After identifying this error, did you try building again without the \"TW_INCLUDE_CRYPTO\" flag and without this patch?","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"f814e6771b32c1428c4a8059ea3436094f085150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37e2b4d8_38d0a48b","in_reply_to":"8035200c_ef2f42d9","updated":"2023-11-24 10:39:36.000000000","message":"Have you reboot to recovery again after the settings were saved in /data/recovery?","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":336,"name":"brigudav","display_name":"brigudav","username":"brigudav"},"change_message_id":"c14520718829140ccc4a6cd04e82c6b43e332835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"762dadb0_7e49a1e8","in_reply_to":"8035200c_ef2f42d9","updated":"2023-11-24 10:37:46.000000000","message":"Here is part of the log:\nI:No recovery folder found. Using default folder.\nI:InfoManager saving \u0027/data/recovery//.twrps\u0027\nI:Saved settings file values to \u0027/data/recovery//.twrps\u0027\nI:Attempt to load settings from settings file...\nI:InfoManager loading from \u0027/data/recovery/.twrps\u0027.\nI:No recovery folder found. Using default folder.\nI:InfoManager saving \u0027/data/recovery/.twrps\u0027\nI:Saved settings file values to \u0027/data/recovery/.twrps\u0027\nPerhaps this is due to the extra slash-\nhttps://github.com/brigudav/bootable_recovery_twrp/commit/1ac60d551ed155e31c902283b43150b676bfc1d0\nTry to fix this too","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"d050521243c67bfdad21e908d8e1ecef976b2cf2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5de57af6_84e0e236","in_reply_to":"8bf2b8ed_0b2ffc77","updated":"2023-11-20 05:41:20.000000000","message":"\u003e With this change, on sdm660 with disabled crypto support, settings are saved.\n\u003e \n\u003e But : \n\u003e - if internal SD is the selected storage before booting to recovery, i can select external SD and use it.\n\u003e \n\u003e - if external SD is the selected storage before booting to recovery, external sdcard can\u0027t be mounted.\n\u003e In dmesg : \n\u003e [   83.959657] FAT-fs (mmcblk1p1): bogus number of reserved sectors\n\u003e [   83.959668] FAT-fs (mmcblk1p1): Can\u0027t find a valid FAT filesystem\n\u003e \n\u003e In fstab external sd fs is set to \"auto\".\n\u003e https://github.com/pix106/android_device_xiaomi_clover/blob/fox_12.1-4.19/recovery/root/system/etc/twrp.flags#L36\n\nIn /tmp/recovery.log : \n\nI:Unable to mount \u0027/sdcard1\u0027\nI:Unable to mount \u0027/sdcard1\u0027\nI:Actual block device: \u0027/dev/block/mmcblk1p1\u0027, current file system: \u0027vfat\u0027\nI:cmd: /system/bin/exfat-fuse -o big_writes,max_read\u003d131072,max_write\u003d131072 /dev/block/mmcblk1p1 /sdcard1\nfuse: mountpoint is not empty\nfuse: if you are sure this is safe, use the \u0027nonempty\u0027 mount option","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":336,"name":"brigudav","display_name":"brigudav","username":"brigudav"},"change_message_id":"1b309523163c4c2ebb54b4fbe378200d4134a0b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18c949eb_a1692b59","in_reply_to":"9983b642_4d6c7b34","updated":"2023-11-22 10:03:30.000000000","message":"I might add that I have already seen a similar problem. This problem occurred on my device after this commit - \nhttps://gerrit.twrp.me/c/android_bootable_recovery/+/6289\nPerhaps this happens when an empty file is created on an external card, and then the recovery simply cannot mount it. I did not analyze this commit, it is not particularly necessary, it does not affect the work in any way, so I simply did not apply it.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"351330a12b0e6e7c44148acba8ac60786697b9fd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d16a4ec4_328ae8f5","in_reply_to":"a2c94445_21a98583","updated":"2023-11-21 00:18:11.000000000","message":"I uploaded a new version of the patch with a small change, unfortunately in the USB-OTG I couldn\u0027t simulate your error, so I would like you to test it to see if just this change already solves the problem.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"d73f9c38ce98281b243fd7053f35ef3410d54a4a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9983b642_4d6c7b34","in_reply_to":"a2cf46e4_b258bc5f","updated":"2023-11-22 00:45:09.000000000","message":"@Pix106 Investigating more calmly, I’m understanding that the error is not caused by this patch, the patch is just showing that there is a issue. Explaining: Without the patch, you can’t save your settings and if you select the external card when you reboot to recovery, the settings won’t be saved and the internal storage will be always selected, right? Then you can select the external card, but resbooting will always be this way, the sdcard1 is only mounted after the reboot.\n\nWith this patch, the selection of the external card will be maintained and then when you reboot it presents the mounting problem. To be sure of this, you mention that you only have the TWRP folder created, but what if you include other files and create new folders before the reboot and only delete the TWRP folder when you reboot, can you mount the external card? If you haven’t done this test, please do.\n\nBecause as my USB storage has a similar operation and with this patch doesn\u0027t present any mounting problem, having several other folders included, including TWRP, everything leads me to believe that the error is either in the mounting of the external sdcard, or in your own setup (device or SDcard or both). Either way, I could be wrong, so ideally other people who have devices with external SDcard and who have TW_INCLUDE_CRYPTO set could test with and without this patch to see if they have the same problem.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"5f49ad2a12e6304732603cf7394d97cb24c003a0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"379f32fb_cf38c0fb","in_reply_to":"c71f2ab6_9ae4c15e","updated":"2023-11-20 14:28:30.000000000","message":"Do you have any other patch from Gerrit included locally? Like perhaps the updated exfat patch? That one is known to cause issues with exfat-fuse.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"b6f733e74c98652dfd3378c3f71e5dcae027dc07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"242279bb_4a5826ee","in_reply_to":"cde0645d_57279e08","updated":"2023-11-22 20:01:58.000000000","message":"Everything is acting normal on my side with this new patch 👍","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":1200,"name":"pix106","display_name":"Pix106","username":"pix106"},"change_message_id":"657bd90c12d62c1506c6edd1330dd352ba18977a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2cf46e4_b258bc5f","in_reply_to":"d16a4ec4_328ae8f5","updated":"2023-11-21 02:24:08.000000000","message":"Thanks. Patchset4 does not solve the problem.","commit_id":"ad734afaed550a6dd1341d1cf6d0d784cec388c9"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"2f3399e71be3f6a86431c0f9b26595075bfe9245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82e9f4e2_d757c45c","updated":"2023-11-24 20:00:15.000000000","message":"I managed to find the extra slash and was also able to simulate the issue. Can you try this new patch?","commit_id":"bbd81a6be39021c77501aaa06e2dcddd15df6cea"},{"author":{"_account_id":336,"name":"brigudav","display_name":"brigudav","username":"brigudav"},"change_message_id":"6d159d34c98351a0da607f59141cedc2efbb892b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"47a8b67c_3864856a","in_reply_to":"82e9f4e2_d757c45c","updated":"2023-11-25 04:02:41.000000000","message":"Now everything is fine. The settings are saved and applied after reboot.","commit_id":"bbd81a6be39021c77501aaa06e2dcddd15df6cea"}],"partition.cpp":[{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"e031be505c9d58fef3cb9123d2155e6102cd8f5a","unresolved":true,"context_lines":[{"line_number":1275,"context_line":"\t\t\tStorage_Path \u003d Mount_Point + \"/media/0\";"},{"line_number":1276,"context_line":"\t\t\tSymlink_Path \u003d Storage_Path;"},{"line_number":1277,"context_line":"\t\t\tDataManager::SetValue(TW_INTERNAL_PATH, Mount_Point + \"/media/0\");"},{"line_number":1278,"context_line":"\t\t\t//Devices without encryption do not run the Post_Decrypt function so the \"data/recovery\" folder was not being created on these devices"},{"line_number":1279,"context_line":"\t\t\tDataManager::SetValue(\"tw_settings_path\", TW_STORAGE_PATH);"},{"line_number":1280,"context_line":"\t\t\tUnMount(true);"},{"line_number":1281,"context_line":"\t\t}"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"f9b26ff4_3abe24bc","line":1278,"updated":"2023-11-25 18:48:11.000000000","message":"Do we need this comment? I am not sure if it serves a purpose as long as it\u0027s in the commit message.","commit_id":"bbd81a6be39021c77501aaa06e2dcddd15df6cea"},{"author":{"_account_id":751,"name":"Fernando Oliveira","display_name":"faoliveira78","email":"fernandoaju78@gmail.com","username":"faoliveira78"},"change_message_id":"f2d27b995f4740f6676afc738663ecb4841f3f2f","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"\t\t\tStorage_Path \u003d Mount_Point + \"/media/0\";"},{"line_number":1276,"context_line":"\t\t\tSymlink_Path \u003d Storage_Path;"},{"line_number":1277,"context_line":"\t\t\tDataManager::SetValue(TW_INTERNAL_PATH, Mount_Point + \"/media/0\");"},{"line_number":1278,"context_line":"\t\t\t//Devices without encryption do not run the Post_Decrypt function so the \"data/recovery\" folder was not being created on these devices"},{"line_number":1279,"context_line":"\t\t\tDataManager::SetValue(\"tw_settings_path\", TW_STORAGE_PATH);"},{"line_number":1280,"context_line":"\t\t\tUnMount(true);"},{"line_number":1281,"context_line":"\t\t}"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5ba831c4_09cb95c0","line":1278,"in_reply_to":"f9b26ff4_3abe24bc","updated":"2023-11-25 19:23:58.000000000","message":"Ok, comments removed","commit_id":"bbd81a6be39021c77501aaa06e2dcddd15df6cea"}]}