)]}'
{"partition.cpp":[{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"85a36ac4035a7037f080dac0a8854893e0e0d0bb","unresolved":true,"context_lines":[{"line_number":2980,"context_line":"\t\tif (TWFunc::Path_Exists(Actual_Block_Device) \u0026\u0026 Find_Partition_Size()) {"},{"line_number":2981,"context_line":"\t\t\tUsed \u003d Size;"},{"line_number":2982,"context_line":"\t\t\tBackup_Size \u003d Size;"},{"line_number":2983,"context_line":"\t\t\tgoto success;"},{"line_number":2984,"context_line":"\t\t}"},{"line_number":2985,"context_line":"\t\tgoto fail;"},{"line_number":2986,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"60ae3baa_a5b5017e","line":2983,"updated":"2022-08-02 23:32:57.000000000","message":"I feel like it would be better to return directly rather than using a goto to short circuit the return. Does anyone have comments?","commit_id":"daa4c55407609e63d589ab870c987e1160ddf799"},{"author":{"_account_id":938,"name":"me-cafebabe","email":"me_cafebabe@hotmail.com","username":"me-cafebabe"},"change_message_id":"d5398171259fa5e0b45f1fd06ff370426db9aad1","unresolved":true,"context_lines":[{"line_number":2980,"context_line":"\t\tif (TWFunc::Path_Exists(Actual_Block_Device) \u0026\u0026 Find_Partition_Size()) {"},{"line_number":2981,"context_line":"\t\t\tUsed \u003d Size;"},{"line_number":2982,"context_line":"\t\t\tBackup_Size \u003d Size;"},{"line_number":2983,"context_line":"\t\t\tgoto success;"},{"line_number":2984,"context_line":"\t\t}"},{"line_number":2985,"context_line":"\t\tgoto fail;"},{"line_number":2986,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"c18a83b4_7afa9289","line":2983,"in_reply_to":"60ae3baa_a5b5017e","updated":"2022-08-05 14:16:46.000000000","message":"This would leave the partition read-only, even if it was read-write. because Mount_Read_Only flag doesn\u0027t get restored","commit_id":"daa4c55407609e63d589ab870c987e1160ddf799"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"113b943d063b7499354bc8c4c51d165d9bf08686","unresolved":false,"context_lines":[{"line_number":2980,"context_line":"\t\tif (TWFunc::Path_Exists(Actual_Block_Device) \u0026\u0026 Find_Partition_Size()) {"},{"line_number":2981,"context_line":"\t\t\tUsed \u003d Size;"},{"line_number":2982,"context_line":"\t\t\tBackup_Size \u003d Size;"},{"line_number":2983,"context_line":"\t\t\tgoto success;"},{"line_number":2984,"context_line":"\t\t}"},{"line_number":2985,"context_line":"\t\tgoto fail;"},{"line_number":2986,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"8d5649d5_b7dfaaea","line":2983,"in_reply_to":"c18a83b4_7afa9289","updated":"2022-09-10 19:15:04.000000000","message":"Done","commit_id":"daa4c55407609e63d589ab870c987e1160ddf799"}]}
