)]}'
{"id":"android_bootable_recovery~4762","triplet_id":"android_bootable_recovery~android-11~I00263757b5b6ed881165e65795ef849d86763165","project":"android_bootable_recovery","branch":"android-11","topic":"erofs_mount_support","attention_set":{},"removed_from_attention_set":{"1":{"account":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"last_update":"2021-12-09 00:18:42.000000000","reason":"removed on reply"},"780":{"account":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"last_update":"2021-12-09 00:18:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I00263757b5b6ed881165e65795ef849d86763165","subject":"libblkid: add erofs filesystem support","status":"MERGED","created":"2021-11-22 15:17:04.000000000","updated":"2022-08-23 22:31:08.000000000","submitted":"2021-12-09 00:18:46.000000000","submitter":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"4762-erofs_mount_support","meta_rev_id":"e153c5d38670fb53c986d436a5699144d65e5925","_number":4762,"virtual_id_number":4762,"owner":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"all":[{"value":2,"date":"2021-12-09 00:18:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"value":1,"date":"2022-08-23 22:31:08.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},{"value":1,"date":"2022-08-23 22:31:08.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-22 15:25:09.000000000","updated_by":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"reviewer":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"state":"REVIEWER"},{"updated":"2021-12-07 16:32:23.000000000","updated_by":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"reviewer":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"state":"REVIEWER"}],"messages":[{"id":"aef54dfc1be7e04a254dfbeec7fb575dfb5f5b08","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"date":"2021-11-22 15:17:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f0f68300aea250b8452b7b8e4ee8a75f608ae612","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"date":"2021-11-22 15:21:00.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e7cc11e28cc1cb971e3aa558b29dcece32de7119","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"date":"2021-11-22 15:21:35.000000000","message":"Topic set to erofs_mount_support","accounts_in_message":[],"_revision_number":2},{"id":"44b7bbc7c25be77fbb599da9bde1803e69831f4b","author":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"date":"2021-11-22 15:25:09.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f332981c89fc1993393e08cdd524ecbb16d128fd","author":{"_account_id":238,"name":"Nebrassy","email":"nebras30@gmail.com","username":"nebrassy"},"date":"2021-12-07 16:32:23.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"66ca76e5a8363e36bf1a460f5bb5b597dd9be602","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2021-12-09 00:18:38.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"daa9576cdb8e12f66e1be5a08751921205f63d74","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2021-12-09 00:18:42.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"a6984051be026a36ac24e0d38aec32c36f992bc0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2021-12-09 00:18:46.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"70b83292d623b48d83cf49a59ebddf21e16ab768","revisions":{"9578f02b99c5bf7ff54b9c8ad8497f7d025080bc":{"kind":"REWORK","_number":1,"created":"2021-11-22 15:17:04.000000000","uploader":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"ref":"refs/changes/62/4762/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/62/4762/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/1 \u0026\u0026 git checkout -b change-4762 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/1","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d0b854b31daeda7f0bdce24a4171821a4fa82707","subject":"Add EROFS to file system check list"}],"author":{"name":"Gao Xiang","email":"hsiangkao@redhat.com","date":"2021-11-22 14:46:43.000000000","tz":480},"committer":{"name":"GarfieldHan","email":"2652609017@qq.com","date":"2021-11-22 15:16:17.000000000","tz":480},"subject":"libblkid: add erofs filesystem support","message":"libblkid: add erofs filesystem support\n\nEnhanced Read-Only File System (EROFS) has been included in Linux\nkernel, many Linux distributions, buildroot and Android AOSP for\na while. Plus, nowadays, it\u0027s known that EROFS has been commercially\nused by several Android vendors for their system partitions.\n\nThis patch adds support for detecting EROFS filesystem to libblkid.\n\nSince util-linux/util-linux@cd129b7 introduced blkid_probe_set_block_size\nfunction to report filesystem block size, TWRP is using blkid 2.25.0, which\nmeans blkid_probe_set_block_size wasn\u0027t supported and required, so remove\nthe blkszbits judgement and blkid_probe_set_block_size for fixing building.\n\nSigned-off-by: Gao Xiang \u003chsiangkao@redhat.com\u003e\n[@pomelohan: Adapt for TWRP\u0027s libblkid version and add erofs.c to build]\nCo-authored-by: GarfieldHan \u003c2652609017@qq.com\u003e\nSigned-off-by: GarfieldHan \u003c2652609017@qq.com\u003e\nChange-Id: I00263757b5b6ed881165e65795ef849d86763165\n"},"branch":"refs/heads/android-11"},"3dc7ea8401bc6b17e15b2f97205842939ff9e504":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-11-22 15:21:00.000000000","uploader":{"_account_id":780,"name":"garfieldhan","email":"2652609017@qq.com","username":"pomelohan"},"ref":"refs/changes/62/4762/2","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/62/4762/2","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/2 \u0026\u0026 git checkout -b change-4762 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/2","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d0b854b31daeda7f0bdce24a4171821a4fa82707","subject":"Add EROFS to file system check list"}],"author":{"name":"Gao Xiang","email":"hsiangkao@redhat.com","date":"2021-11-22 14:46:43.000000000","tz":480},"committer":{"name":"garfieldhan","email":"2652609017@qq.com","date":"2021-11-22 15:21:00.000000000","tz":0},"subject":"libblkid: add erofs filesystem support","message":"libblkid: add erofs filesystem support\n\nEnhanced Read-Only File System (EROFS) has been included in Linux\nkernel, many Linux distributions, buildroot and Android AOSP for\na while. Plus, nowadays, it\u0027s known that EROFS has been commercially\nused by several Android vendors for their system partitions.\n\nThis patch adds support for detecting EROFS filesystem to libblkid.\n\nSince util-linux/util-linux@cd129b7 introduced blkid_probe_set_block_size\nfunction to report filesystem block size, TWRP is using blkid 2.25.0, which\nmeans blkid_probe_set_block_size wasn\u0027t supported and required, so remove\nthe blkszbits judgement and blkid_probe_set_block_size for fixing building.\n\nTest: Add erofs mount point to twrp.flags, build and boot\nOP4A7A:/ # logcat | grep erofs\nI (6)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (6)[571:recovery]erofs: (device dm-9): mounted with opts: , root inode @ nid 43.\nI (6)[571:recovery]erofs: (device dm-1): mounted with opts: , root inode @ nid 52.\nI (6)[571:recovery]erofs: (device dm-10): mounted with opts: , root inode @ nid 45.\nI (6)[571:recovery]erofs: (device dm-8): mounted with opts: , root inode @ nid 42.\nI (0)[571:recovery]erofs: (device dm-12): mounted with opts: , root inode @ nid 38.\nI (3)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (3)[571:recovery]erofs: (device dm-1): mounted with opts: , root inode @ nid 52.\nI (3)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (3)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (3)[571:recovery]erofs: (device dm-9): mounted with opts: , root inode @ nid 43.\nI (2)[571:recovery]erofs: (device dm-1): mounted with opts: , root inode @ nid 52.\nI (2)[571:recovery]erofs: (device dm-10): mounted with opts: , root inode @ nid 45.\nI (2)[571:recovery]erofs: (device dm-8): mounted with opts: , root inode @ nid 42.\nI (2)[571:recovery]erofs: (device dm-12): mounted with opts: , root inode @ nid 38.\nI (6)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (6)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\n\nOP4A7A:/ # cat /tmp/recovery.log | grep erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n\nNow TWRP can recognize the EROFS filesystem perfectly after setting fs in twrp.flags\n\nSigned-off-by: Gao Xiang \u003chsiangkao@redhat.com\u003e\n[@pomelohan: Adapt for TWRP\u0027s libblkid version and add erofs.c to build]\nCo-authored-by: GarfieldHan \u003c2652609017@qq.com\u003e\nSigned-off-by: GarfieldHan \u003c2652609017@qq.com\u003e\nChange-Id: I00263757b5b6ed881165e65795ef849d86763165\n"},"branch":"refs/heads/android-11","description":"Edit commit message"},"70b83292d623b48d83cf49a59ebddf21e16ab768":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-12-09 00:18:38.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/62/4762/3","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/62/4762/3","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/3 \u0026\u0026 git checkout -b change-4762 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/3","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/62/4762/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cdc031971795bfe79d6e552b4dc38d9dc88bedc8","subject":"twrpinstall: Remove unnecessary CloseArchive() calls"}],"author":{"name":"Gao Xiang","email":"hsiangkao@redhat.com","date":"2021-11-22 14:46:43.000000000","tz":480},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2021-12-09 00:18:38.000000000","tz":0},"subject":"libblkid: add erofs filesystem support","message":"libblkid: add erofs filesystem support\n\nEnhanced Read-Only File System (EROFS) has been included in Linux\nkernel, many Linux distributions, buildroot and Android AOSP for\na while. Plus, nowadays, it\u0027s known that EROFS has been commercially\nused by several Android vendors for their system partitions.\n\nThis patch adds support for detecting EROFS filesystem to libblkid.\n\nSince util-linux/util-linux@cd129b7 introduced blkid_probe_set_block_size\nfunction to report filesystem block size, TWRP is using blkid 2.25.0, which\nmeans blkid_probe_set_block_size wasn\u0027t supported and required, so remove\nthe blkszbits judgement and blkid_probe_set_block_size for fixing building.\n\nTest: Add erofs mount point to twrp.flags, build and boot\nOP4A7A:/ # logcat | grep erofs\nI (6)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (6)[571:recovery]erofs: (device dm-9): mounted with opts: , root inode @ nid 43.\nI (6)[571:recovery]erofs: (device dm-1): mounted with opts: , root inode @ nid 52.\nI (6)[571:recovery]erofs: (device dm-10): mounted with opts: , root inode @ nid 45.\nI (6)[571:recovery]erofs: (device dm-8): mounted with opts: , root inode @ nid 42.\nI (0)[571:recovery]erofs: (device dm-12): mounted with opts: , root inode @ nid 38.\nI (3)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (3)[571:recovery]erofs: (device dm-1): mounted with opts: , root inode @ nid 52.\nI (3)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (3)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (3)[571:recovery]erofs: (device dm-9): mounted with opts: , root inode @ nid 43.\nI (2)[571:recovery]erofs: (device dm-1): mounted with opts: , root inode @ nid 52.\nI (2)[571:recovery]erofs: (device dm-10): mounted with opts: , root inode @ nid 45.\nI (2)[571:recovery]erofs: (device dm-8): mounted with opts: , root inode @ nid 42.\nI (2)[571:recovery]erofs: (device dm-12): mounted with opts: , root inode @ nid 38.\nI (6)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\nI (6)[571:recovery]erofs: (device dm-0): mounted with opts: , root inode @ nid 58.\n\nOP4A7A:/ # cat /tmp/recovery.log | grep erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n   Current_File_System: erofs\n   Fstab_File_System: erofs\n\nNow TWRP can recognize the EROFS filesystem perfectly after setting fs in twrp.flags\n\nSigned-off-by: Gao Xiang \u003chsiangkao@redhat.com\u003e\n[@pomelohan: Adapt for TWRP\u0027s libblkid version and add erofs.c to build]\nCo-authored-by: GarfieldHan \u003c2652609017@qq.com\u003e\nSigned-off-by: GarfieldHan \u003c2652609017@qq.com\u003e\nChange-Id: I00263757b5b6ed881165e65795ef849d86763165\n"},"branch":"refs/heads/android-11","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}