)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"change_message_id":"8dfdaf46839386a807db6db2445761ac83f390ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cabb1c00_542f13a7","updated":"2021-01-24 03:29:17.000000000","message":"The XML approach used by patch set 1 works only for extensions, such as .apk.\n\nIf we want to catch the common names used by the Magisk Manager app, we\u0027ll need some actual code.\n\nThe list of possible app names should probably be externalised somewhere.","commit_id":"7887e4103a64487e5f62676c5f137be63e245a91"},{"author":{"_account_id":539,"name":"Mohammad Afaneh","display_name":"afaneh92","username":"mohammad92"},"change_message_id":"7b88ea1002d135adc476329f06892ce189473797","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5532f560_dd149f7b","updated":"2021-01-25 08:13:25.000000000","message":"In case of old magisk app release or user fault rename. It wont be flashable.","commit_id":"966042fe5672a74c0f48240c03265737d73af38d"},{"author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"change_message_id":"a5d8a7f3e4e392a2b7b8ca643144dd5ccede7033","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0a8eb78_78dab2a0","updated":"2021-01-24 18:26:53.000000000","message":"Patch set 3 looks for Magisk.apk instead of MagiskManager*.apk, as this is evidently the new non-canary name.","commit_id":"966042fe5672a74c0f48240c03265737d73af38d"},{"author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"change_message_id":"9aba0885494dc460dcc95c1c1c90f5fc6d01a21e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be21ffcc_45cf8ca2","updated":"2021-01-25 08:21:40.000000000","message":"Yes, Captain Throwback felt it was safer to be restrictive.\n\nOtherwise, we can just allow *.apk, which was the approach taken by patch set 1.\n\nI don\u0027t have a strong feeling about it, but I do foresee that a lot of users will rename the canary .apk from app-debug.apk, since that name includes no version information and doesn\u0027t even identify the app.","commit_id":"966042fe5672a74c0f48240c03265737d73af38d"},{"author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"change_message_id":"e716552e189992bb5c65d8285ed4e4fd9f0c0d74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee9bd7d8_1f42b978","updated":"2021-01-25 10:05:52.000000000","message":"Patch set 4 reverts to the XML approach, which avoids hard-coding the filenames in C++.\n\nInstead, the extension handling code is minimally altered to allow an extension to match a full filename. This allows us to simply list allowable exceptions in the list of extensions. ","commit_id":"17fc2c4cae478e2989c80feaefae1536d16d7640"},{"author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"change_message_id":"99f0ce0c2e75e8d41e78d4e9936487f1f1f0437f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4c1be45_23ba0d86","updated":"2021-01-25 11:34:25.000000000","message":"There\u0027s still an issue, however.\n\nWhen one actually tries to flash a Magisk .apk, it fails and complains that the digest file can\u0027t be found. I need to look into that.","commit_id":"17fc2c4cae478e2989c80feaefae1536d16d7640"},{"author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"change_message_id":"15ffb820349d372b5f704e0c2a0b351f0092e7ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ea9ca84_ad1352bf","updated":"2021-01-25 14:12:37.000000000","message":"The digest code assumed that a ZIP file would always have the extension .zip, the logic of which returned a false positive, thereby triggering digest verification.\n\nPatch set 5 fixes this. I have verified that everything works as expected now.","commit_id":"3c2b73b1f0e8110c4aa6dc04e3786626c86547a4"},{"author":{"_account_id":224,"name":"Ian Macdonald","email":"ian@caliban.org","username":"ianmacd"},"change_message_id":"745a61f90c56ea15e51bce43cb3ce1370399f909","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fec61e35_f1e623aa","updated":"2021-01-26 17:00:49.000000000","message":"Patch set 6 introduces a prefix filter, so that filenames like Magisk-* can now be matched. This will be important when the new, single-file form of Magisk packaging makes its way from canary to beta and stable.\n\nAll of the existing Magisk-related filter strings have now been moved to the prefix filter, and Magisk-* has been added as a new filter.\n\n","commit_id":"36ed36a6a66eaee6afcbac3de80a53f564cbed69"},{"author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"change_message_id":"115a4c25fc505a6e08c2a2a3ff8803529ec2ce87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23772eeb_4e094eef","updated":"2021-01-30 20:28:08.000000000","message":"Working for me.","commit_id":"36ed36a6a66eaee6afcbac3de80a53f564cbed69"}]}