)]}'
{"id":"android_bootable_recovery~2440","triplet_id":"android_bootable_recovery~android-10.0~I69cd2eba3693a9914e00213d4943229635d0cdae","project":"android_bootable_recovery","branch":"android-10.0","hashtags":[],"change_id":"I69cd2eba3693a9914e00213d4943229635d0cdae","subject":"decrypt: AOSP 10 requires the use of fscrypt","status":"MERGED","created":"2020-06-09 00:12:33.000000000","updated":"2020-06-22 16:27:55.000000000","submitted":"2020-06-22 16:27:55.000000000","submitter":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"2440-1592843275190-b816baa9","meta_rev_id":"5128a99cbe097683074b1517177faca8a7c981c4","_number":2440,"virtual_id_number":2440,"owner":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"all":[{"value":2,"date":"2020-06-22 16:27:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"value":1,"date":"2020-06-22 13:00:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"}],"REVIEWER":[{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-15 19:11:16.000000000","updated_by":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"reviewer":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"state":"CC"},{"updated":"2020-06-22 10:27:01.000000000","updated_by":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"reviewer":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"state":"REVIEWER"}],"messages":[{"id":"0311c8232d38fd3a5ea3994db0b17860f14e7f36","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-09 00:12:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4e673ddcefba6dd5067343d100c136ea6ef9b431","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-09 00:13:41.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"335d9e4b172fb208e5b01b25acb86e25c640f125","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-10 22:36:05.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2b2dea3592808bb61bdf9e230eba5dd061d1a4c0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-10 22:57:10.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.","accounts_in_message":[],"_revision_number":4},{"id":"d48d2de84264073d36ef11b75f9e4e946b877624","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-15 19:11:16.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nBut even with metadata wiped, it could still not boot after wipe.","accounts_in_message":[],"_revision_number":4},{"id":"25354bcec4d907d3707ca2b1f3023230377d6fe5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-22 10:27:01.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"60908a2e964c3c840b9f209017eb4021e97b2de1","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-22 13:00:09.000000000","message":"Patch Set 5: Code-Review+1\n\nThere are some things that should be managed better (i get 3 errors before decryption success) but i think we can push this and then we have to push others minor fixes","accounts_in_message":[],"_revision_number":5},{"id":"483b762c677270aa84263485752254b5a1c3ec5c","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-22 16:27:49.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"5128a99cbe097683074b1517177faca8a7c981c4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-22 16:27:55.000000000","message":"Change has been successfully merged by bigbiff","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"7ba7500953cb70ff750a3c918d85d8f9be0ad7e2","revisions":{"70cb5aa0d9a8f7f9af63025e6d9a8cea5317ffd6":{"kind":"REWORK","_number":1,"created":"2020-06-09 00:12:33.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/40/2440/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/40/2440/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/1 \u0026\u0026 git checkout -b change-2440 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/1","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"325e0a2cca35f904fbed4fa79db26dcf43b9b3cb","subject":"ext4crypt: fix include location for recovery-twrp in lineage"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-04-12 00:47:09.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-09 00:12:19.000000000","tz":-240},"subject":"decrypt: AOSP 10 requires the use of fscrypt","message":"decrypt: AOSP 10 requires the use of fscrypt\n\nfscrypt aosp doc: https://source.android.com/security/encryption/file-based\nkernel fscrypt doc: https://www.kernel.org/doc/html/v4.18/filesystems/fscrypt.html\n\nThis commit implements the ability for TWRP to use fscrypt to decrypt\nfiles on the fscrypt implementation. It has been implemented mostly\nin a new successor library to e4crypt called libtwrpfscrypt. Most of the\ncode was ported from AOSP vold.\n\nNotable updates include:\n - updated policy storage by libtar\n - lookup of fbe policies by libtwrpfscrypt\n - threaded keystore operations\n\nBig thanks to Dees_Troy for the initial trailblazing\nof encryption in TWRP.\nChange-Id: Iba5167a02dcd855526c4acf350053865b8a1df86\n\nChange-Id: I69cd2eba3693a9914e00213d4943229635d0cdae\n"},"branch":"refs/heads/android-10.0"},"e1fa3cef40aa7e2818ae3cf15c2ccd57ba9cad34":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-06-09 00:13:41.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/40/2440/2","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/40/2440/2","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/2 \u0026\u0026 git checkout -b change-2440 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/2","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"325e0a2cca35f904fbed4fa79db26dcf43b9b3cb","subject":"ext4crypt: fix include location for recovery-twrp in lineage"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-04-12 00:47:09.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-09 00:13:29.000000000","tz":-240},"subject":"decrypt: AOSP 10 requires the use of fscrypt","message":"decrypt: AOSP 10 requires the use of fscrypt\n\nfscrypt aosp doc: https://source.android.com/security/encryption/file-based\nkernel fscrypt doc: https://www.kernel.org/doc/html/v4.18/filesystems/fscrypt.html\n\nThis commit implements the ability for TWRP to use fscrypt to decrypt\nfiles on the fscrypt implementation. It has been implemented mostly\nin a new successor library to e4crypt called libtwrpfscrypt. Most of the\ncode was ported from AOSP vold.\n\nNotable updates include:\n - updated policy storage by libtar\n - lookup of fbe policies by libtwrpfscrypt\n - threaded keystore operations\n\nBig thanks to Dees_Troy for the initial trailblazing\nof encryption in TWRP.\n\nChange-Id: I69cd2eba3693a9914e00213d4943229635d0cdae\n"},"branch":"refs/heads/android-10.0"},"1a4c966e60d2bb602d4dace4435622cf7967ba6d":{"kind":"REWORK","_number":3,"created":"2020-06-10 22:36:05.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/40/2440/3","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/40/2440/3","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/3 \u0026\u0026 git checkout -b change-2440 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/3","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d3bf891c4b6368279dc7cd0bc47a181acf037b7","subject":"Add ozip decryption for Oppo/Realme device"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-04-12 00:47:09.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-10 22:35:52.000000000","tz":-240},"subject":"decrypt: AOSP 10 requires the use of fscrypt","message":"decrypt: AOSP 10 requires the use of fscrypt\n\nfscrypt aosp doc: https://source.android.com/security/encryption/file-based\nkernel fscrypt doc: https://www.kernel.org/doc/html/v4.18/filesystems/fscrypt.html\n\nThis commit implements the ability for TWRP to use fscrypt to decrypt\nfiles on the fscrypt implementation. It has been implemented mostly\nin a new successor library to e4crypt called libtwrpfscrypt. Most of the\ncode was ported from AOSP vold.\n\nNotable updates include:\n - updated policy storage by libtar\n - lookup of fbe policies by libtwrpfscrypt\n - threaded keystore operations\n\nBig thanks to Dees_Troy for the initial trailblazing\nof encryption in TWRP.\n\nChange-Id: I69cd2eba3693a9914e00213d4943229635d0cdae\n"},"branch":"refs/heads/android-10.0"},"91f3dc5084b73430adab0a2c1289c23e8a2ea266":{"kind":"NO_CHANGE","_number":4,"created":"2020-06-10 22:57:10.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/40/2440/4","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/40/2440/4","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/4 \u0026\u0026 git checkout -b change-2440 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/4","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d3bf891c4b6368279dc7cd0bc47a181acf037b7","subject":"Add ozip decryption for Oppo/Realme device"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-04-12 00:47:09.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-10 22:57:00.000000000","tz":-240},"subject":"decrypt: AOSP 10 requires the use of fscrypt","message":"decrypt: AOSP 10 requires the use of fscrypt\n\nfscrypt aosp doc: https://source.android.com/security/encryption/file-based\nkernel fscrypt doc: https://www.kernel.org/doc/html/v4.18/filesystems/fscrypt.html\n\nThis commit implements the ability for TWRP to use fscrypt to decrypt\nfiles on the fscrypt implementation. It has been implemented mostly\nin a new successor library to e4crypt called libtwrpfscrypt. Most of the\ncode was ported from AOSP vold.\n\nNotable updates include:\n - updated policy storage by libtar\n - lookup of fbe policies by libtwrpfscrypt\n - threaded keystore operations\n\nBig thanks to Dees_Troy for the initial trailblazing\nof encryption in TWRP.\n\nChange-Id: I69cd2eba3693a9914e00213d4943229635d0cdae\n"},"branch":"refs/heads/android-10.0"},"7ba7500953cb70ff750a3c918d85d8f9be0ad7e2":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2020-06-22 10:27:01.000000000","uploader":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"ref":"refs/changes/40/2440/5","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/40/2440/5","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/5 \u0026\u0026 git checkout -b change-2440 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/5","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/40/2440/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f4c155378901d60481b41b4ff919ddfb28fd1dde","subject":"super: emmc shouldn\u0027t be mount-only."}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-04-12 00:47:09.000000000","tz":-240},"committer":{"name":"mauronofrio","email":"poronofrio@gmail.com","date":"2020-06-22 10:17:22.000000000","tz":120},"subject":"decrypt: AOSP 10 requires the use of fscrypt","message":"decrypt: AOSP 10 requires the use of fscrypt\n\nfscrypt aosp doc: https://source.android.com/security/encryption/file-based\nkernel fscrypt doc: https://www.kernel.org/doc/html/v4.18/filesystems/fscrypt.html\n\nThis commit implements the ability for TWRP to use fscrypt to decrypt\nfiles on the fscrypt implementation. It has been implemented mostly\nin a new successor library to e4crypt called libtwrpfscrypt. Most of the\ncode was ported from AOSP vold.\n\nNotable updates include:\n - updated policy storage by libtar\n - lookup of fbe policies by libtwrpfscrypt\n - threaded keystore operations\n\nBig thanks to Dees_Troy for the initial trailblazing\nof encryption in TWRP.\n\nChange-Id: I69cd2eba3693a9914e00213d4943229635d0cdae\n"},"branch":"refs/heads/android-10.0"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}