)]}'
{"id":"android_bootable_recovery~2296","triplet_id":"android_bootable_recovery~android-10.0~Icc1d895dcf96ad5ba03989c9bf759419d83673a3","project":"android_bootable_recovery","branch":"android-10.0","hashtags":[],"change_id":"Icc1d895dcf96ad5ba03989c9bf759419d83673a3","subject":"super partition: mount super partitions using fs_mgr","status":"MERGED","created":"2020-05-27 01:04:30.000000000","updated":"2020-10-02 07:23:49.000000000","submitted":"2020-06-08 20:37:43.000000000","submitter":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"total_comment_count":15,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"2296-1591648663472-d4b45f5f","meta_rev_id":"6c90fe033019ee50bf782ec9b7e3546e93a9543c","_number":2296,"virtual_id_number":2296,"owner":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"all":[{"value":0,"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},{"value":2,"date":"2020-06-08 20:37:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"value":0,"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-31 18:46:49.000000000","updated_by":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"reviewer":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"state":"CC"},{"updated":"2020-06-01 17:44:38.000000000","updated_by":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"reviewer":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"state":"REVIEWER"},{"updated":"2020-06-04 03:34:56.000000000","updated_by":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"reviewer":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"state":"REVIEWER"}],"messages":[{"id":"e839f7b2ffd907aed5efd97ffbab36ca4ea53e80","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-27 01:04:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"742a748388eb7ccaec5020eeeb039855df1767e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-27 18:58:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2bd8e6c88bdbaaf0f74be4bf96381ce68f5a7f22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-27 19:22:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3375e0755e357f808de96c0c862472c4133431b7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-30 01:19:07.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"168980c57d1dbc8bb2023f2b07a0c58e4e1d9af6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-30 20:06:33.000000000","message":"Patch Set 5: Patch Set 4 was rebased","accounts_in_message":[],"_revision_number":5},{"id":"4cc54534a54dcf43b6808b721bf3fedec07a9fbc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-30 20:14:29.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"f2b4ec438494e07da621d7250f740742cca2237e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-30 20:15:15.000000000","message":"Uploaded patch set 7: Commit message was updated.","accounts_in_message":[],"_revision_number":7},{"id":"73ee0325bd0910f19d16a8d3cf65506a3e22f0a0","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-30 20:16:53.000000000","message":"Patch Set 7: Code-Review+2\n\nI will probably merge this in the next few days if no issues are raised.","accounts_in_message":[],"_revision_number":7},{"id":"d70e97c155739ce631c188008a1a992c8b2f084c","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-05-31 18:46:49.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"3fd40ab87a5e627ccb19344496d55d3dba066cdc","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-05-31 18:51:19.000000000","message":"Patch Set 7:\n\nMaybe hide \"Mount system partition read-only\" checkbox at the mount page at the sametime? This will make users confuse.","accounts_in_message":[],"_revision_number":7},{"id":"e0339412cfe6f0319ccedf9c99043661a4fada57","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-31 20:09:02.000000000","message":"Patch Set 7:\n\n(1 comment)\n\n\u003e Patch Set 7:\n\u003e \n\u003e Maybe hide \"Mount system partition read-only\" checkbox at the mount page at the sametime? This will make users confuse.\n\nThe if condition in twrp.cpp only shows the mount read only dialogue if the device has no super partition.","accounts_in_message":[],"_revision_number":7},{"id":"b054ec19d7668e091d7060f6f18c4bd9eab53900","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-01 01:30:16.000000000","message":"Patch Set 7:\n\n(1 comment)\n\n\u003e Patch Set 7:\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e \u003e Patch Set 7:\n\u003e \u003e \n\u003e \u003e Maybe hide \"Mount system partition read-only\" checkbox at the mount page at the sametime? This will make users confuse.\n\u003e \n\u003e The if condition in twrp.cpp only shows the mount read only dialogue if the device has no super partition.\n\nThe beginning GUI mount system rw page is gone, but I could still see the checkbox at mount page. I\u0027m testing this commit with Mi 10 which has super partition.","accounts_in_message":[],"_revision_number":7},{"id":"86d0fc850a8b387c55bb76b8fb4a9b0384b8812a","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-01 06:22:30.000000000","message":"Patch Set 7:\n\n(1 comment)\n\nMaybe add AB_OTA_UPDATER check for it?","accounts_in_message":[],"_revision_number":7},{"id":"9708b86b21ff99c84fc67f204c6eb3063ff9d77e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 14:12:35.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"a4d0432c0bee2a997a10bee829800e9866c91c6e","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 14:19:13.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"80a5beca411318c1fb4ef9abd802992f58b0420a","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 14:23:30.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 7:\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e \u003e Patch Set 7:\n\u003e \u003e \n\u003e \u003e (1 comment)\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 7:\n\u003e \u003e \u003e \n\u003e \u003e \u003e Maybe hide \"Mount system partition read-only\" checkbox at the mount page at the sametime? This will make users confuse.\n\u003e \u003e \n\u003e \u003e The if condition in twrp.cpp only shows the mount read only dialogue if the device has no super partition.\n\u003e \n\u003e The beginning GUI mount system rw page is gone, but I could still see the checkbox at mount page. I\u0027m testing this commit with Mi 10 which has super partition.\n\nI added a tw_is_super condition for showing this checkbox in data.cpp and modified the conditions accordingly.","accounts_in_message":[],"_revision_number":8},{"id":"c218e0d7ff97919dead0ec66a4eb71dcaa75419e","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 17:44:38.000000000","message":"Patch Set 8: Code-Review-1\n\nI can confirm that it is not working properly on a-only devices","accounts_in_message":[],"_revision_number":8},{"id":"76b8765febcf1a6072c466dd2c9dbee5d075be9b","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 17:52:12.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8: Code-Review-1\n\u003e \n\u003e I can confirm that it is not working properly on a-only devices\n\nPlease define not working properly.","accounts_in_message":[],"_revision_number":8},{"id":"519b557ed861c2fefc6990dc4916aae6103f2c42","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 18:07:07.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8: Code-Review-1\n\u003e \u003e \n\u003e \u003e I can confirm that it is not working properly on a-only devices\n\u003e \n\u003e Please define not working properly.\n\nThe TWRP try to mount the partitions as they are a/b so it is trying to select the active slot partition","accounts_in_message":[],"_revision_number":8},{"id":"ddeacce209471fd840bef7b0cc05856309a29587","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 18:12:52.000000000","message":"Patch Set 8:\n\n06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address","accounts_in_message":[],"_revision_number":8},{"id":"79ce6c656dee4cef9ca19bf0c6c361d5808b7922","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 18:23:48.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\nCan you post the entire recovery.log for tracing?","accounts_in_message":[],"_revision_number":8},{"id":"9d0c44c7908aee541415bb0966cd9b3b1e46ad04","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 18:34:39.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \n\u003e Can you post the entire recovery.log for tracing?\n\nhttps://pastebin.com/VZVjvHZY","accounts_in_message":[],"_revision_number":8},{"id":"06c8628c07081c56c1b91b5d9d2ceeac92b08c46","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 18:50:10.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \n\u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \n\u003e https://pastebin.com/VZVjvHZY\n\nCan you make sure the super partitions are formatted as follows in your fstab v2:\n\nhttps://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\nsystem                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\nvendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\nproduct                                                 /product               ext4    ro,barrier\u003d1   \n\nAlso remove the super_partition emmc partition. It will be setup automatically in TWRP.","accounts_in_message":[],"_revision_number":8},{"id":"e61d9ce608ba13b342d4f3666de97b640eeffb42","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 18:52:14.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \u003e \n\u003e \u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \u003e \n\u003e \u003e https://pastebin.com/VZVjvHZY\n\u003e \n\u003e Can you make sure the super partitions are formatted as follows in your fstab v2:\n\u003e \n\u003e https://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\u003e \n\u003e system                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\n\u003e vendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\n\u003e product                                                 /product               ext4    ro,barrier\u003d1   \n\u003e \n\u003e Also remove the super_partition emmc partition. It will be setup automatically in TWRP.\n\nHere you can see the fstab:\n\nhttps://github.com/mauronofrio/android_device_xiaomi_curtana/blob/android-10.0/recovery/root/etc/twrp.fstab","accounts_in_message":[],"_revision_number":8},{"id":"c98226ea8c3b88c42da2729a4fb71647ece2af57","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 18:54:18.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \u003e \u003e \n\u003e \u003e \u003e https://pastebin.com/VZVjvHZY\n\u003e \u003e \n\u003e \u003e Can you make sure the super partitions are formatted as follows in your fstab v2:\n\u003e \u003e \n\u003e \u003e https://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\u003e \u003e \n\u003e \u003e system                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\n\u003e \u003e vendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\n\u003e \u003e product                                                 /product               ext4    ro,barrier\u003d1   \n\u003e \u003e \n\u003e \u003e Also remove the super_partition emmc partition. It will be setup automatically in TWRP.\n\u003e \n\u003e Here you can see the fstab:\n\u003e \n\u003e https://github.com/mauronofrio/android_device_xiaomi_curtana/blob/android-10.0/recovery/root/etc/twrp.fstab\n\nWe are dropping support for twrp.fstab. It needs to be v2 recovery.fstab and twrp.flags","accounts_in_message":[],"_revision_number":8},{"id":"46a2ad421bc6bc6da2c2c272401f82288671a695","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 18:57:56.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e https://pastebin.com/VZVjvHZY\n\u003e \u003e \u003e \n\u003e \u003e \u003e Can you make sure the super partitions are formatted as follows in your fstab v2:\n\u003e \u003e \u003e \n\u003e \u003e \u003e https://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\u003e \u003e \u003e \n\u003e \u003e \u003e system                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\n\u003e \u003e \u003e vendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\n\u003e \u003e \u003e product                                                 /product               ext4    ro,barrier\u003d1   \n\u003e \u003e \u003e \n\u003e \u003e \u003e Also remove the super_partition emmc partition. It will be setup automatically in TWRP.\n\u003e \u003e \n\u003e \u003e Here you can see the fstab:\n\u003e \u003e \n\u003e \u003e https://github.com/mauronofrio/android_device_xiaomi_curtana/blob/android-10.0/recovery/root/etc/twrp.fstab\n\u003e \n\u003e We are dropping support for twrp.fstab. It needs to be v2 recovery.fstab and twrp.flags\n\nthe logical partitions are in v2 fstab","accounts_in_message":[],"_revision_number":8},{"id":"c496b689f1575c19afb626270db5a151a785525b","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 19:01:19.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e https://pastebin.com/VZVjvHZY\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Can you make sure the super partitions are formatted as follows in your fstab v2:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e https://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e system                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\n\u003e \u003e \u003e \u003e vendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\n\u003e \u003e \u003e \u003e product                                                 /product               ext4    ro,barrier\u003d1   \n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Also remove the super_partition emmc partition. It will be setup automatically in TWRP.\n\u003e \u003e \u003e \n\u003e \u003e \u003e Here you can see the fstab:\n\u003e \u003e \u003e \n\u003e \u003e \u003e https://github.com/mauronofrio/android_device_xiaomi_curtana/blob/android-10.0/recovery/root/etc/twrp.fstab\n\u003e \u003e \n\u003e \u003e We are dropping support for twrp.fstab. It needs to be v2 recovery.fstab and twrp.flags\n\u003e \n\u003e the logical partitions are in v2 fstab\n\nBetter the fstab have 2 different structure, the first is v2 for logical partitions and the second one in v1 for others partitions","accounts_in_message":[],"_revision_number":8},{"id":"7474bd0aa1425da09500f1fdc6b809cc893e89e7","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-01 20:29:02.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e https://pastebin.com/VZVjvHZY\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Can you make sure the super partitions are formatted as follows in your fstab v2:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e https://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e system                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\n\u003e \u003e \u003e \u003e vendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\n\u003e \u003e \u003e \u003e product                                                 /product               ext4    ro,barrier\u003d1   \n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Also remove the super_partition emmc partition. It will be setup automatically in TWRP.\n\u003e \u003e \u003e \n\u003e \u003e \u003e Here you can see the fstab:\n\u003e \u003e \u003e \n\u003e \u003e \u003e https://github.com/mauronofrio/android_device_xiaomi_curtana/blob/android-10.0/recovery/root/etc/twrp.fstab\n\u003e \u003e \n\u003e \u003e We are dropping support for twrp.fstab. It needs to be v2 recovery.fstab and twrp.flags\n\u003e \n\u003e the logical partitions are in v2 fstab\n\nThe whole file should be v2 fstab, and move all twrp related stuff to /etc/twrp.flags\nRemove any twrp flag from the v2 fstab and add it to /etc/twrp.flags.\nAlso can you post your logcat results.","accounts_in_message":[],"_revision_number":8},{"id":"6374477334e5e619f13756d512cfaf9cc836aaf1","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 21:12:26.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e https://pastebin.com/VZVjvHZY\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Can you make sure the super partitions are formatted as follows in your fstab v2:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e https://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e system                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\n\u003e \u003e \u003e \u003e \u003e vendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\n\u003e \u003e \u003e \u003e \u003e product                                                 /product               ext4    ro,barrier\u003d1   \n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Also remove the super_partition emmc partition. It will be setup automatically in TWRP.\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Here you can see the fstab:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e https://github.com/mauronofrio/android_device_xiaomi_curtana/blob/android-10.0/recovery/root/etc/twrp.fstab\n\u003e \u003e \u003e \n\u003e \u003e \u003e We are dropping support for twrp.fstab. It needs to be v2 recovery.fstab and twrp.flags\n\u003e \u003e \n\u003e \u003e the logical partitions are in v2 fstab\n\u003e \n\u003e The whole file should be v2 fstab, and move all twrp related stuff to /etc/twrp.flags\n\u003e Remove any twrp flag from the v2 fstab and add it to /etc/twrp.flags.\n\u003e Also can you post your logcat results.\n\nThere is nothing in logcat except the part i reported before, the others thing are sepolicy missing","accounts_in_message":[],"_revision_number":8},{"id":"c39ae052a1b0424098234d8ddc81af62cacdf720","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-06-01 21:23:18.000000000","message":"Patch Set 8:\n\n\u003e Patch Set 8:\n\u003e \n\u003e \u003e Patch Set 8:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 8:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.358   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition product on device /dev/block/dm-0\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 I /sbin/recovery: [libfs_mgr]Created logical partition system on device /dev/block/dm-2\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.359   535   535 W /sbin/recovery: DM_DEV_STATUS failed for system_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e 06-01 17:23:27.360   535   535 W /sbin/recovery: DM_DEV_STATUS failed for vendor_b: No such device or address\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Can you post the entire recovery.log for tracing?\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e https://pastebin.com/VZVjvHZY\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Can you make sure the super partitions are formatted as follows in your fstab v2:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e https://github.com/bigbiff/android_device_google_coral/blob/android-10.0/fstab.hardware\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e system                                                  /system                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta_system,logical,first_stage_mount\n\u003e \u003e \u003e \u003e \u003e \u003e vendor                                                  /vendor                ext4    ro,barrier\u003d1                                         wait,slotselect,avb\u003dvbmeta,logical,first_stage_mount\n\u003e \u003e \u003e \u003e \u003e \u003e product                                                 /product               ext4    ro,barrier\u003d1   \n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Also remove the super_partition emmc partition. It will be setup automatically in TWRP.\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Here you can see the fstab:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e https://github.com/mauronofrio/android_device_xiaomi_curtana/blob/android-10.0/recovery/root/etc/twrp.fstab\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e We are dropping support for twrp.fstab. It needs to be v2 recovery.fstab and twrp.flags\n\u003e \u003e \u003e \n\u003e \u003e \u003e the logical partitions are in v2 fstab\n\u003e \u003e \n\u003e \u003e The whole file should be v2 fstab, and move all twrp related stuff to /etc/twrp.flags\n\u003e \u003e Remove any twrp flag from the v2 fstab and add it to /etc/twrp.flags.\n\u003e \u003e Also can you post your logcat results.\n\u003e \n\u003e There is nothing in logcat except the part i reported before, the others thing are sepolicy missing\n\nBut if you want to be sure: https://pastebin.com/u2Fk9M2S","accounts_in_message":[],"_revision_number":8},{"id":"95ea13acb7eb477f6ae87ee1d212f79fcb28b170","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-02 03:05:18.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"5a50cdbb377c4aa19bdaca3e28bbf34ac95b6f52","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-02 15:13:42.000000000","message":"Patch Set 8:\n\n(2 comments)","accounts_in_message":[],"_revision_number":8},{"id":"6cb8a45a119098f5714af23b6d4beb9c135f1968","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-02 23:41:43.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"5a71c0f3c112aa4affe18965e380187728e1a743","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-02 23:47:43.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"207ee3c9520ab3976c1faf06db95888507429218","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-02 23:49:44.000000000","message":"Patch Set 10: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":10},{"id":"5fbffbce197ae60f345e4494ad2782b26412d451","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-02 23:50:11.000000000","message":"Patch Set 10:\n\n\u003e Patch Set 8: Code-Review-1\n\u003e \n\u003e I can confirm that it is not working properly on a-only devices\n\nPlease try the newest patchset.","accounts_in_message":[],"_revision_number":10},{"id":"19d20d9cb31657b28e32a155391c3f3b43e7c7ab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-03 00:00:24.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.","accounts_in_message":[],"_revision_number":11},{"id":"fce59a180b22d5dac927fd0ee4a1bdddca96a19a","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-03 00:34:16.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"92301ba6503de01801d43ab5f0a1c83bd6e12d03","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-03 04:02:06.000000000","message":"Patch Set 11:\n\nThe device will hang for a little bit of time at main page.\nThere are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\nLogs:\nI:Trying to prepare odm from super partition\nFailed to mount \u0027/odm\u0027 (Permission denied)\nI:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\nFailed to mount \u0027/odm\u0027 (Permission denied)\nI:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n/odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n   Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n   Primary_Block_Device: /dev/block/dm-3\n   Display_Name: odm\n   Storage_Name: odm\n   Backup_Path: /odm\n   Backup_Name: odm\n   Backup_Display_Name: odm\n   Storage_Path: /odm\n   Current_File_System: ext4\n   Fstab_File_System: ext4\n   Backup_Method: files\n   Mount_Flags: 0, Mount_Options: logical","accounts_in_message":[],"_revision_number":11},{"id":"62ac6fc0d73899a7fea68fdba06f1a5a7e670115","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-03 14:47:15.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"467bb58d9245caac57752cb56aa017606b557a81","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-03 14:49:00.000000000","message":"Patch Set 11:\n\n\u003e Patch Set 11:\n\u003e \n\u003e The device will hang for a little bit of time at main page.\n\u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \n\u003e Logs:\n\u003e I:Trying to prepare odm from super partition\n\u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e    Display_Name: odm\n\u003e    Storage_Name: odm\n\u003e    Backup_Path: /odm\n\u003e    Backup_Name: odm\n\u003e    Backup_Display_Name: odm\n\u003e    Storage_Path: /odm\n\u003e    Current_File_System: ext4\n\u003e    Fstab_File_System: ext4\n\u003e    Backup_Method: files\n\u003e    Mount_Flags: 0, Mount_Options: logical\n\nCan you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro","accounts_in_message":[],"_revision_number":11},{"id":"7a3636f72b40ce480791eeea28f59fe6cd9bfc43","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-03 16:34:29.000000000","message":"Patch Set 12:\n\n\u003e Patch Set 11:\n\u003e \n\u003e \u003e Patch Set 11:\n\u003e \u003e \n\u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \n\u003e \u003e Logs:\n\u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e    Display_Name: odm\n\u003e \u003e    Storage_Name: odm\n\u003e \u003e    Backup_Path: /odm\n\u003e \u003e    Backup_Name: odm\n\u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e    Storage_Path: /odm\n\u003e \u003e    Current_File_System: ext4\n\u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e    Backup_Method: files\n\u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \n\u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\nMy device is A-only if that matters.\nlogcat: https://pastebin.com/6nwFGurT\nrecovery.log: https://pastebin.com/v8huw14e\nHow to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.","accounts_in_message":[],"_revision_number":12},{"id":"19c917e3cf6573d02313cf82109e0452ad98454b","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-03 16:40:17.000000000","message":"Patch Set 12:\n\n\u003e Patch Set 12:\n\u003e \n\u003e \u003e Patch Set 11:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \n\u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \n\u003e \u003e \u003e Logs:\n\u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \n\u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \n\u003e My device is A-only if that matters.\n\u003e logcat: https://pastebin.com/6nwFGurT\n\u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\nAnd here is the source code I use.\nhttps://github.com/simonsmh/android_device_xiaomi_umi/commits/android-10.0\nhttps://github.com/simonsmh/android_bootable_recovery/commits/android-10.0","accounts_in_message":[],"_revision_number":12},{"id":"a949d0fc24d3364eba38c2a5c279b2b91b132430","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-03 17:40:47.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"70781a6067b80246bd80ccc487c2c37a83e160e5","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-03 18:02:23.000000000","message":"Patch Set 13:\n\n(1 comment)\n\n\u003e Patch Set 12:\n\u003e \n\u003e \u003e Patch Set 11:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \n\u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \n\u003e \u003e \u003e Logs:\n\u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \n\u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \n\u003e My device is A-only if that matters.\n\u003e logcat: https://pastebin.com/6nwFGurT\n\u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\nWhat mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.","accounts_in_message":[],"_revision_number":13},{"id":"c9bb6b9649f921cf64e1351307cc5fe218a868bc","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-03 18:03:25.000000000","message":"Patch Set 13: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"a52b7810c4d394f16c8057f8a3a4fd6fb61f2816","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-03 19:07:00.000000000","message":"Uploaded patch set 14: Patch Set 13 was rebased.","accounts_in_message":[],"_revision_number":14},{"id":"034a69f99effd9351fad75fd4a8f63c90a7e4444","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-04 03:17:42.000000000","message":"Patch Set 14:\n\n\u003e Patch Set 13:\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e \u003e Patch Set 12:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Logs:\n\u003e \u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \u003e \n\u003e \u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \u003e \n\u003e \u003e My device is A-only if that matters.\n\u003e \u003e logcat: https://pastebin.com/6nwFGurT\n\u003e \u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e \u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\u003e \n\u003e What mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.\n\nYes.\ndmesg.log: https://pastebin.com/Z8N3s1UU","accounts_in_message":[],"_revision_number":14},{"id":"234bc21221d7c91c6f0c89e0f5569490181e799d","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-04 03:34:51.000000000","message":"Patch Set 14:\n\n\u003e Patch Set 14:\n\u003e \n\u003e \u003e Patch Set 13:\n\u003e \u003e \n\u003e \u003e (1 comment)\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 12:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Logs:\n\u003e \u003e \u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \u003e \u003e \n\u003e \u003e \u003e My device is A-only if that matters.\n\u003e \u003e \u003e logcat: https://pastebin.com/6nwFGurT\n\u003e \u003e \u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e \u003e \u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\u003e \u003e \n\u003e \u003e What mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.\n\u003e \n\u003e Yes.\n\u003e dmesg.log: https://pastebin.com/Z8N3s1UU\n\nAfter I disabled ReadFstabFromDt at ReadDefaultFstab at fs_mgr_fstab.cpp the problem is gone but I\u0027m not sure since the dts are not avaliable for my device. It should be a device specific device tree issue.","accounts_in_message":[],"_revision_number":14},{"id":"d1e680c83b2c6b55a7b7b7afd8cdba917bc1a4d7","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-04 03:34:56.000000000","message":"Patch Set 14: Code-Review+1","accounts_in_message":[],"_revision_number":14},{"id":"b6f3b2c1da2e4e8d4396cc5080a55787972f48c3","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-04 14:39:04.000000000","message":"Patch Set 14:\n\n\u003e Patch Set 14:\n\u003e \n\u003e \u003e Patch Set 14:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 13:\n\u003e \u003e \u003e \n\u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 12:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e \u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Logs:\n\u003e \u003e \u003e \u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e \u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e \u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e \u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e \u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e My device is A-only if that matters.\n\u003e \u003e \u003e \u003e logcat: https://pastebin.com/6nwFGurT\n\u003e \u003e \u003e \u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e \u003e \u003e \u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\u003e \u003e \u003e \n\u003e \u003e \u003e What mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.\n\u003e \u003e \n\u003e \u003e Yes.\n\u003e \u003e dmesg.log: https://pastebin.com/Z8N3s1UU\n\u003e \n\u003e After I disabled ReadFstabFromDt at ReadDefaultFstab at fs_mgr_fstab.cpp the problem is gone but I\u0027m not sure since the dts are not avaliable for my device. It should be a device specific device tree issue.\n\nOK, so to be sure I understand, you just needed to add the fstab v2 to your device tree to make it work?","accounts_in_message":[],"_revision_number":14},{"id":"5e899ce8d0fced7974cf16541eeda0a037dd4202","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-04 17:37:19.000000000","message":"Patch Set 14: -Code-Review\n\n\u003e Patch Set 14:\n\u003e \n\u003e \u003e Patch Set 14:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 13:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 12:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Logs:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e My device is A-only if that matters.\n\u003e \u003e \u003e \u003e \u003e logcat: https://pastebin.com/6nwFGurT\n\u003e \u003e \u003e \u003e \u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e \u003e \u003e \u003e \u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e What mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.\n\u003e \u003e \u003e \n\u003e \u003e \u003e Yes.\n\u003e \u003e \u003e dmesg.log: https://pastebin.com/Z8N3s1UU\n\u003e \u003e \n\u003e \u003e After I disabled ReadFstabFromDt at ReadDefaultFstab at fs_mgr_fstab.cpp the problem is gone but I\u0027m not sure since the dts are not avaliable for my device. It should be a device specific device tree issue.\n\u003e \n\u003e OK, so to be sure I understand, you just needed to add the fstab v2 to your device tree to make it work?\n\nI replaced these logical partition lines to fstab v2 format because I don\u0027t know how to write a twrp.flags file. I tried to disable the ability of init and fs_mgr that read fstab from dt.\nWell I just rebased the commits again (on your decrypt11) and it seems that it is still reporting Permission denied for /product and /odm so dt may not be the issue. It could be mount later by hand though, so it\u0027s hard to say if it is a problem.\nlogcat: https://paste.ubuntu.com/p/ncSJTK8tMb/\nrecovery: https://paste.ubuntu.com/p/rdvmQzcd4p/\ndmesg: https://paste.ubuntu.com/p/rxvQsmZmBx/","accounts_in_message":[],"_revision_number":14},{"id":"09940999e1411ed9e171d1d0198f70bf622b5a6c","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-04 18:20:31.000000000","message":"Patch Set 14:\n\n\u003e Patch Set 14: -Code-Review\n\u003e \n\u003e \u003e Patch Set 14:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 13:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 12:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Logs:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e My device is A-only if that matters.\n\u003e \u003e \u003e \u003e \u003e \u003e logcat: https://pastebin.com/6nwFGurT\n\u003e \u003e \u003e \u003e \u003e \u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e \u003e \u003e \u003e \u003e \u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e What mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Yes.\n\u003e \u003e \u003e \u003e dmesg.log: https://pastebin.com/Z8N3s1UU\n\u003e \u003e \u003e \n\u003e \u003e \u003e After I disabled ReadFstabFromDt at ReadDefaultFstab at fs_mgr_fstab.cpp the problem is gone but I\u0027m not sure since the dts are not avaliable for my device. It should be a device specific device tree issue.\n\u003e \u003e \n\u003e \u003e OK, so to be sure I understand, you just needed to add the fstab v2 to your device tree to make it work?\n\u003e \n\u003e I replaced these logical partition lines to fstab v2 format because I don\u0027t know how to write a twrp.flags file. I tried to disable the ability of init and fs_mgr that read fstab from dt.\n\u003e Well I just rebased the commits again (on your decrypt11) and it seems that it is still reporting Permission denied for /product and /odm so dt may not be the issue. It could be mount later by hand though, so it\u0027s hard to say if it is a problem.\n\u003e logcat: https://paste.ubuntu.com/p/ncSJTK8tMb/\n\u003e recovery: https://paste.ubuntu.com/p/rdvmQzcd4p/\n\u003e dmesg: https://paste.ubuntu.com/p/rxvQsmZmBx/\n\nJust rename your original v1 fstab to twrp.flags and make sure it gets into etc in the ramdisk should suffice. Then have your super partitions in recovery.fstab in v2 format.\n\nStill working on decrypt, if you use this on the android-10.0 branch does that work?","accounts_in_message":[],"_revision_number":14},{"id":"7d45e32dcb9d5550450ed259604a1448bcd91064","author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"date":"2020-06-05 10:21:40.000000000","message":"Patch Set 14:\n\n(1 comment)\n\n\u003e Patch Set 14:\n\u003e \n\u003e \u003e Patch Set 14: -Code-Review\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 13:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 12:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Logs:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e My device is A-only if that matters.\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e logcat: https://pastebin.com/6nwFGurT\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e What mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Yes.\n\u003e \u003e \u003e \u003e \u003e dmesg.log: https://pastebin.com/Z8N3s1UU\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e After I disabled ReadFstabFromDt at ReadDefaultFstab at fs_mgr_fstab.cpp the problem is gone but I\u0027m not sure since the dts are not avaliable for my device. It should be a device specific device tree issue.\n\u003e \u003e \u003e \n\u003e \u003e \u003e OK, so to be sure I understand, you just needed to add the fstab v2 to your device tree to make it work?\n\u003e \u003e \n\u003e \u003e I replaced these logical partition lines to fstab v2 format because I don\u0027t know how to write a twrp.flags file. I tried to disable the ability of init and fs_mgr that read fstab from dt.\n\u003e \u003e Well I just rebased the commits again (on your decrypt11) and it seems that it is still reporting Permission denied for /product and /odm so dt may not be the issue. It could be mount later by hand though, so it\u0027s hard to say if it is a problem.\n\u003e \u003e logcat: https://paste.ubuntu.com/p/ncSJTK8tMb/\n\u003e \u003e recovery: https://paste.ubuntu.com/p/rdvmQzcd4p/\n\u003e \u003e dmesg: https://paste.ubuntu.com/p/rxvQsmZmBx/\n\u003e \n\u003e Just rename your original v1 fstab to twrp.flags and make sure it gets into etc in the ramdisk should suffice. Then have your super partitions in recovery.fstab in v2 format.\n\u003e \n\u003e Still working on decrypt, if you use this on the android-10.0 branch does that work?\n\nSwitching to twrp.flags solved super partitons\u0027 problem. (although twrp.flags caused more data partition related problem which is not present on twrp.fstab, but it is not related to this commit)","accounts_in_message":[],"_revision_number":14},{"id":"a597d16f2927345bd2090df86349315edadfe6ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-06 00:59:39.000000000","message":"Uploaded patch set 15.","accounts_in_message":[],"_revision_number":15},{"id":"3f437d93c307bff1b2003ac146b0e88ad9297756","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-06 01:11:43.000000000","message":"Patch Set 15:\n\n\u003e Patch Set 14:\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e \u003e Patch Set 14:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 14: -Code-Review\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Patch Set 14:\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 13:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e (1 comment)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 12:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Patch Set 11:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e The device will hang for a little bit of time at main page.\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e There are logs reporting: Failed to mount \u0027/\u003cpartition name\u003e\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Logs:\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Trying to prepare odm from super partition\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Failed to mount \u0027/odm\u0027 (Permission denied)\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e I:Actual block device: \u0027/dev/block/dm-3\u0027, current file system: \u0027ext4\u0027\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e /odm | /dev/block/dm-3 | Size: 0MB Used: 0MB Free: 0MB Backup Size: 0MB\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Flags: Can_Be_Mounted Can_Be_Wiped IsPresent Mount_Read_Only \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Primary_Block_Device: /dev/block/dm-3\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Display_Name: odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Storage_Path: /odm\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Current_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Fstab_File_System: ext4\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Backup_Method: files\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e    Mount_Flags: 0, Mount_Options: logical\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e Can you provide logcat as well for debugging why fs_mgr? Also can you see if the following command in adb shell mounts odm: mount /dev/block/dm-3 /odm -o ro\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e My device is A-only if that matters.\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e logcat: https://pastebin.com/6nwFGurT\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e recovery.log: https://pastebin.com/v8huw14e\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \u003e How to debug it? Also there is one wierd thing is that I can mount it manually on my side but some of the other users cannot not.\n\u003e \u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e \u003e What mount command did you use? The one I suggested? Also can you provide dmesg after it tries to mount? I am not sure why there is an issue with some of the super volumes not mounting.\n\u003e \u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e \u003e Yes.\n\u003e \u003e \u003e \u003e \u003e \u003e dmesg.log: https://pastebin.com/Z8N3s1UU\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e After I disabled ReadFstabFromDt at ReadDefaultFstab at fs_mgr_fstab.cpp the problem is gone but I\u0027m not sure since the dts are not avaliable for my device. It should be a device specific device tree issue.\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e OK, so to be sure I understand, you just needed to add the fstab v2 to your device tree to make it work?\n\u003e \u003e \u003e \n\u003e \u003e \u003e I replaced these logical partition lines to fstab v2 format because I don\u0027t know how to write a twrp.flags file. I tried to disable the ability of init and fs_mgr that read fstab from dt.\n\u003e \u003e \u003e Well I just rebased the commits again (on your decrypt11) and it seems that it is still reporting Permission denied for /product and /odm so dt may not be the issue. It could be mount later by hand though, so it\u0027s hard to say if it is a problem.\n\u003e \u003e \u003e logcat: https://paste.ubuntu.com/p/ncSJTK8tMb/\n\u003e \u003e \u003e recovery: https://paste.ubuntu.com/p/rdvmQzcd4p/\n\u003e \u003e \u003e dmesg: https://paste.ubuntu.com/p/rxvQsmZmBx/\n\u003e \u003e \n\u003e \u003e Just rename your original v1 fstab to twrp.flags and make sure it gets into etc in the ramdisk should suffice. Then have your super partitions in recovery.fstab in v2 format.\n\u003e \u003e \n\u003e \u003e Still working on decrypt, if you use this on the android-10.0 branch does that work?\n\u003e \n\u003e Switching to twrp.flags solved super partitons\u0027 problem. (although twrp.flags caused more data partition related problem which is not present on twrp.fstab, but it is not related to this commit)\n\nThanks for pointing that out. I ended up not using the flag for logical, so I removed it from this patchset.","accounts_in_message":[],"_revision_number":15},{"id":"59ece3e501bebaf0ea424ec6c7ee5f9e0bec1b75","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-08 20:37:29.000000000","message":"Patch Set 16: Patch Set 15 was rebased","accounts_in_message":[],"_revision_number":16},{"id":"f52f4d1fe9f4cf9f95cff949a219b43923362805","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-08 20:37:38.000000000","message":"Patch Set 16: Code-Review+2","accounts_in_message":[],"_revision_number":16},{"id":"6bd8396b395c3a758bd1dcef3606888061e3af60","tag":"autogenerated:gerrit:merged","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-06-08 20:37:43.000000000","message":"Change has been successfully merged by bigbiff","accounts_in_message":[],"_revision_number":16},{"id":"6c90fe033019ee50bf782ec9b7e3546e93a9543c","tag":"autogenerated:gerrit:revert","author":{"_account_id":558,"name":"Jua-creator","username":"Jua-creator"},"date":"2020-10-02 07:23:49.000000000","message":"Created a revert of this change as I916aad63ef5db1b9d19fa4998b149e835a3aa0dc","accounts_in_message":[],"_revision_number":16}],"current_revision_number":16,"current_revision":"ee7b7ffba41e1ac16b22f4742c301ffff14bc3da","revisions":{"05326759f88bcc9386a4aaea72c6553fdefdea85":{"kind":"REWORK","_number":1,"created":"2020-05-27 01:04:30.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/1 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/1","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0b25b1d79b79bc4d45dfff2aaf575e10bd24ef2d","subject":"Add support for multi-user decryption"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-27 01:04:18.000000000","tz":-240},"subject":"super partition WIP: mount super partitions from fs_mgr","message":"super partition WIP: mount super partitions from fs_mgr\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"0b25b1d79b79bc4d45dfff2aaf575e10bd24ef2d","is_merged_in_target_branch":true,"change_id":"Id2681bc2b1012a0571417f7a6e0b980b1b25c61c","change_number":2269,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"44867e8c46f37808f74f92d83647cc578e888ac9":{"kind":"REWORK","_number":2,"created":"2020-05-27 18:58:42.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/2","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/2","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/2 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/2","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0b25b1d79b79bc4d45dfff2aaf575e10bd24ef2d","subject":"Add support for multi-user decryption"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-27 18:58:15.000000000","tz":-240},"subject":"super partition WIP: mount super partitions from fs_mgr","message":"super partition WIP: mount super partitions from fs_mgr\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"0b25b1d79b79bc4d45dfff2aaf575e10bd24ef2d","is_merged_in_target_branch":true,"change_id":"Id2681bc2b1012a0571417f7a6e0b980b1b25c61c","change_number":2269,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"0645c22bd8e1e350e15b8fff923c1be8b6dd58ca":{"kind":"REWORK","_number":3,"created":"2020-05-27 19:22:59.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/3","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/3","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/3 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/3","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0b25b1d79b79bc4d45dfff2aaf575e10bd24ef2d","subject":"Add support for multi-user decryption"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-27 19:22:50.000000000","tz":-240},"subject":"super partition WIP: mount super partitions from fs_mgr","message":"super partition WIP: mount super partitions from fs_mgr\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"0b25b1d79b79bc4d45dfff2aaf575e10bd24ef2d","is_merged_in_target_branch":true,"change_id":"Id2681bc2b1012a0571417f7a6e0b980b1b25c61c","change_number":2269,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"72522d6d45fededd97f336771f147be08e02d995":{"kind":"REWORK","_number":4,"created":"2020-05-30 01:19:07.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/4","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/4","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/4 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/4","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fb62b1806ef930aa0e159f3cf182ebdf7f7421b3","subject":"crypto: Update crypto fde"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-30 01:18:54.000000000","tz":-240},"subject":"super partition WIP: mount super partitions from fs_mgr","message":"super partition WIP: mount super partitions from fs_mgr\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"fb62b1806ef930aa0e159f3cf182ebdf7f7421b3","is_merged_in_target_branch":true,"change_id":"Ia66be6917c4690f0d70ba89ea33ebfa2fcb6974a","change_number":2317,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"50eb8bab21b48465f8bbc970623b64c67a87c6a2":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2020-05-30 20:06:33.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/5","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/5","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/5 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/5","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","subject":"partitionmanager: magisk update sytnax as per new binaries"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-30 20:06:33.000000000","tz":0},"subject":"super partition WIP: mount super partitions from fs_mgr","message":"super partition WIP: mount super partitions from fs_mgr\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","is_merged_in_target_branch":true,"change_id":"I51994b991472cf103de067b9856ff3df1bf35a90","change_number":2319,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0","description":"Rebase"},"0541026eefcee482a6b019925ea27f26314c4960":{"kind":"REWORK","_number":6,"created":"2020-05-30 20:14:29.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/6","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/6","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/6 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/6","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","subject":"partitionmanager: magisk update sytnax as per new binaries"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-30 20:11:52.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab2 for android-10+ trees. You can specify\ntwrp flags using /etc/twrp.flags to label and annotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","is_merged_in_target_branch":true,"change_id":"I51994b991472cf103de067b9856ff3df1bf35a90","change_number":2319,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"bb94fbe35d8a1c3d2e690a18caa4525a1fc0ad62":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2020-05-30 20:15:15.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/7","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/7","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/7 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/7","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","subject":"partitionmanager: magisk update sytnax as per new binaries"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-30 20:15:12.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","is_merged_in_target_branch":true,"change_id":"I51994b991472cf103de067b9856ff3df1bf35a90","change_number":2319,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"36322feaba6e9c1f6fedd101a5fa3616859f9c21":{"kind":"REWORK","_number":8,"created":"2020-06-01 14:12:35.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/8","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/8","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/8 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/8","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"95e51eb21bfde07ff098d88418ecc689ae568f74","subject":"relink: use relinked files as required modules"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-01 14:12:22.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"95e51eb21bfde07ff098d88418ecc689ae568f74","is_merged_in_target_branch":false,"change_id":"I18bffa454ad64d70c5efedbf174887571e95b734","change_number":2344,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"80edb09099234789e9cce490cc242375a5f61eed":{"kind":"REWORK","_number":9,"created":"2020-06-02 23:41:43.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/9","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/9","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/9 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/9","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","subject":"partitionmanager: magisk update sytnax as per new binaries"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-02 23:41:30.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","is_merged_in_target_branch":true,"change_id":"I51994b991472cf103de067b9856ff3df1bf35a90","change_number":2319,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"2c1d8c5d758a45f67cd960b25faedf4fc05eb6ce":{"kind":"REWORK","_number":10,"created":"2020-06-02 23:47:43.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/10","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/10","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/10 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/10","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","subject":"partitionmanager: magisk update sytnax as per new binaries"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-02 23:47:39.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","is_merged_in_target_branch":true,"change_id":"I51994b991472cf103de067b9856ff3df1bf35a90","change_number":2319,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"e3b488603f34a036f76757fbc911f4abf4da22d8":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2020-06-03 00:00:24.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/11","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/11","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/11 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/11","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e08c5c6a38c359ceb65e173ef6a85baee3149370","subject":"relink: use relinked files as required modules"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-02 23:54:56.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"e08c5c6a38c359ceb65e173ef6a85baee3149370","is_merged_in_target_branch":false,"change_id":"I18bffa454ad64d70c5efedbf174887571e95b734","change_number":2344,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"e0b5bfea89600f72dba9ca44ea5b6a0ea9d250ee":{"kind":"REWORK","_number":12,"created":"2020-06-03 14:47:15.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/12","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/12","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/12 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/12","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","subject":"partitionmanager: magisk update sytnax as per new binaries"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-03 14:47:02.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","is_merged_in_target_branch":true,"change_id":"I51994b991472cf103de067b9856ff3df1bf35a90","change_number":2319,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"b6fa44493cd99fb3f9095ed9fc70259cfe2c64eb":{"kind":"REWORK","_number":13,"created":"2020-06-03 17:40:47.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/13","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/13","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/13 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/13","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/13 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","subject":"partitionmanager: magisk update sytnax as per new binaries"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-03 17:40:36.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"b98b4f7b96bda331a5b661a5dc9b295dc48a4bd3","is_merged_in_target_branch":true,"change_id":"I51994b991472cf103de067b9856ff3df1bf35a90","change_number":2319,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"975dcad27bf98fb4bcafa19db547b05bc8a37bcf":{"kind":"TRIVIAL_REBASE","_number":14,"created":"2020-06-03 19:07:00.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/14","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/14","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/14 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/14","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/14 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"de734ffa68c9c262ea8e0dee6ac592604090862f","subject":"relink: use relinked files as required modules"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-03 18:12:31.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"de734ffa68c9c262ea8e0dee6ac592604090862f","is_merged_in_target_branch":false,"change_id":"I18bffa454ad64d70c5efedbf174887571e95b734","change_number":2344,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"67a1f95ee666f5386d3efe205adc47ff86702cc2":{"kind":"REWORK","_number":15,"created":"2020-06-06 00:59:39.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/15","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/15","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/15 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/15","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/15 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa09c483e079715c3fff8f58d17d386e61c0b2a3","subject":"relink: use relinked files as required modules"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-06 00:59:28.000000000","tz":-240},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"aa09c483e079715c3fff8f58d17d386e61c0b2a3","is_merged_in_target_branch":false,"change_id":"I18bffa454ad64d70c5efedbf174887571e95b734","change_number":2344,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0"},"ee7b7ffba41e1ac16b22f4742c301ffff14bc3da":{"kind":"TRIVIAL_REBASE","_number":16,"created":"2020-06-08 20:37:29.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/96/2296/16","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/96/2296/16","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/16 \u0026\u0026 git checkout -b change-2296 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/16 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/16 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/16 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/16","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/96/2296/16 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a299dcc322a21802e555da9a4ab51d00ced6ee0","subject":"relink: use relinked files as required modules"}],"author":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-23 19:08:27.000000000","tz":-240},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-06-08 20:37:29.000000000","tz":0},"subject":"super partition: mount super partitions using fs_mgr","message":"super partition: mount super partitions using fs_mgr\n\nWe are now requiring fstab v2 for android-10+ trees. You can\nspecify twrp flags using /etc/twrp.flags to label and\nannotate partitions.\n\nThis patchset uses fs_mgr to load the super partition and build\ndevice mapper blocks off vendor and system depending on the slot\nin use. These are mapped to partitions in TWRP and allowed to\nbe mounted read-only. The super partition is also mapped into a\nTWRP partition in order to backup the entire partition. You cannot\nbackup individual device mapper blocks due to the device can only\nbe read-only. Therefore you cannot write back to the device mapper.\n\nChange-Id: Icc1d895dcf96ad5ba03989c9bf759419d83673a3\n"},"parents_data":[{"branch_name":"refs/heads/android-10.0","commit_id":"3a299dcc322a21802e555da9a4ab51d00ced6ee0","is_merged_in_target_branch":true,"change_id":"I18bffa454ad64d70c5efedbf174887571e95b734","change_number":2344,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/android-10.0","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}