)]}'
{"data.cpp":[{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"d70e97c155739ce631c188008a1a992c8b2f084c","unresolved":true,"context_lines":[{"line_number":779,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/system;/data;\");"},{"line_number":780,"context_line":"#else"},{"line_number":781,"context_line":"#ifdef PRODUCT_USE_DYNAMIC_PARTITIONS"},{"line_number":782,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/data;\");"},{"line_number":783,"context_line":"#else"},{"line_number":784,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/system;/data;/boot;\");"},{"line_number":785,"context_line":"#endif"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"93c32f82_0498018e","line":782,"updated":"2020-05-31 18:46:49.000000000","message":"Why is boot also ignored?","commit_id":"bb94fbe35d8a1c3d2e690a18caa4525a1fc0ad62"},{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"b054ec19d7668e091d7060f6f18c4bd9eab53900","unresolved":false,"context_lines":[{"line_number":779,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/system;/data;\");"},{"line_number":780,"context_line":"#else"},{"line_number":781,"context_line":"#ifdef PRODUCT_USE_DYNAMIC_PARTITIONS"},{"line_number":782,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/data;\");"},{"line_number":783,"context_line":"#else"},{"line_number":784,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/system;/data;/boot;\");"},{"line_number":785,"context_line":"#endif"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"403728de_d6b8a66f","line":782,"in_reply_to":"87aca46b_37816d59","updated":"2020-06-01 01:30:16.000000000","message":"Done","commit_id":"bb94fbe35d8a1c3d2e690a18caa4525a1fc0ad62"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"e0339412cfe6f0319ccedf9c99043661a4fada57","unresolved":true,"context_lines":[{"line_number":779,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/system;/data;\");"},{"line_number":780,"context_line":"#else"},{"line_number":781,"context_line":"#ifdef PRODUCT_USE_DYNAMIC_PARTITIONS"},{"line_number":782,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/data;\");"},{"line_number":783,"context_line":"#else"},{"line_number":784,"context_line":"\tmPersist.SetValue(\"tw_backup_list\", \"/system;/data;/boot;\");"},{"line_number":785,"context_line":"#endif"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"87aca46b_37816d59","line":782,"in_reply_to":"93c32f82_0498018e","updated":"2020-05-31 20:09:02.000000000","message":"Because with dynamic partitions it doesn\u0027t exist until after fs_mgr loads the logical volumes from the super partition. Without setting the default to just /data, it will select boot and system without the gui updated. This allows the user to select them after the partitions are created if they want to back them up.","commit_id":"bb94fbe35d8a1c3d2e690a18caa4525a1fc0ad62"}],"partition.cpp":[{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"5a50cdbb377c4aa19bdaca3e28bbf34ac95b6f52","unresolved":true,"context_lines":[{"line_number":462,"context_line":"\t\t\tBackup_Name \u003d \"system\";"},{"line_number":463,"context_line":"\t\t\tBackup_Display_Name \u003d Display_Name;"},{"line_number":464,"context_line":"\t\t\tStorage_Name \u003d Display_Name;"},{"line_number":465,"context_line":"\t\t\tWipe_Available_in_GUI \u003d true;"},{"line_number":466,"context_line":"\t\t\tCan_Be_Backed_Up \u003d true;"},{"line_number":467,"context_line":"\t\t\tMount_Read_Only \u003d true;"},{"line_number":468,"context_line":"\t\t} else if (Mount_Point \u003d\u003d \"/data\") {"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"8763dd6f_0dd0cca3","line":465,"updated":"2020-06-02 15:13:42.000000000","message":"Maybe check for if Is_Super?","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"70781a6067b80246bd80ccc487c2c37a83e160e5","unresolved":false,"context_lines":[{"line_number":462,"context_line":"\t\t\tBackup_Name \u003d \"system\";"},{"line_number":463,"context_line":"\t\t\tBackup_Display_Name \u003d Display_Name;"},{"line_number":464,"context_line":"\t\t\tStorage_Name \u003d Display_Name;"},{"line_number":465,"context_line":"\t\t\tWipe_Available_in_GUI \u003d true;"},{"line_number":466,"context_line":"\t\t\tCan_Be_Backed_Up \u003d true;"},{"line_number":467,"context_line":"\t\t\tMount_Read_Only \u003d true;"},{"line_number":468,"context_line":"\t\t} else if (Mount_Point \u003d\u003d \"/data\") {"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"dda234a7_7ebeb0f8","line":465,"in_reply_to":"2427b65d_b00cf15f","updated":"2020-06-03 18:02:23.000000000","message":"Added ability to have super partitions set to Can_Be_Backed_Up to false.","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"fce59a180b22d5dac927fd0ee4a1bdddca96a19a","unresolved":false,"context_lines":[{"line_number":462,"context_line":"\t\t\tBackup_Name \u003d \"system\";"},{"line_number":463,"context_line":"\t\t\tBackup_Display_Name \u003d Display_Name;"},{"line_number":464,"context_line":"\t\t\tStorage_Name \u003d Display_Name;"},{"line_number":465,"context_line":"\t\t\tWipe_Available_in_GUI \u003d true;"},{"line_number":466,"context_line":"\t\t\tCan_Be_Backed_Up \u003d true;"},{"line_number":467,"context_line":"\t\t\tMount_Read_Only \u003d true;"},{"line_number":468,"context_line":"\t\t} else if (Mount_Point \u003d\u003d \"/data\") {"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"2427b65d_b00cf15f","line":465,"in_reply_to":"635408e7_3d3b4029","updated":"2020-06-03 00:34:16.000000000","message":"There might be no need to wipe or backup logical partitions.","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"207ee3c9520ab3976c1faf06db95888507429218","unresolved":false,"context_lines":[{"line_number":462,"context_line":"\t\t\tBackup_Name \u003d \"system\";"},{"line_number":463,"context_line":"\t\t\tBackup_Display_Name \u003d Display_Name;"},{"line_number":464,"context_line":"\t\t\tStorage_Name \u003d Display_Name;"},{"line_number":465,"context_line":"\t\t\tWipe_Available_in_GUI \u003d true;"},{"line_number":466,"context_line":"\t\t\tCan_Be_Backed_Up \u003d true;"},{"line_number":467,"context_line":"\t\t\tMount_Read_Only \u003d true;"},{"line_number":468,"context_line":"\t\t} else if (Mount_Point \u003d\u003d \"/data\") {"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"635408e7_3d3b4029","line":465,"in_reply_to":"8763dd6f_0dd0cca3","updated":"2020-06-02 23:49:44.000000000","message":"Check what? we are doing checks elsewhere for various processing.","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"c9bb6b9649f921cf64e1351307cc5fe218a868bc","unresolved":false,"context_lines":[{"line_number":462,"context_line":"\t\t\tBackup_Name \u003d \"system\";"},{"line_number":463,"context_line":"\t\t\tBackup_Display_Name \u003d Display_Name;"},{"line_number":464,"context_line":"\t\t\tStorage_Name \u003d Display_Name;"},{"line_number":465,"context_line":"\t\t\tWipe_Available_in_GUI \u003d true;"},{"line_number":466,"context_line":"\t\t\tCan_Be_Backed_Up \u003d true;"},{"line_number":467,"context_line":"\t\t\tMount_Read_Only \u003d true;"},{"line_number":468,"context_line":"\t\t} else if (Mount_Point \u003d\u003d \"/data\") {"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"6fd54308_62524280","line":465,"in_reply_to":"dda234a7_7ebeb0f8","updated":"2020-06-03 18:03:25.000000000","message":"The last patchset should resolve this issue.","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"7d45e32dcb9d5550450ed259604a1448bcd91064","unresolved":true,"context_lines":[{"line_number":987,"context_line":"\t\tcase TWFLAG_KEYDIRECTORY:"},{"line_number":988,"context_line":"\t\t\tKey_Directory \u003d str;"},{"line_number":989,"context_line":"\t\t\tbreak;"},{"line_number":990,"context_line":"\t\tdefault:"},{"line_number":991,"context_line":"\t\t\t// Should not get here"},{"line_number":992,"context_line":"\t\t\tLOGINFO(\"Flag identified for processing, but later unmatched: %i\\n\", flag);"},{"line_number":993,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-c++src","patch_set":14,"id":"f413d156_be7d96a8","line":990,"updated":"2020-06-05 10:21:40.000000000","message":"case TWFLAG_LOGICAL:\n    break;","commit_id":"975dcad27bf98fb4bcafa19db547b05bc8a37bcf"}],"partitionmanager.cpp":[{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"86d0fc850a8b387c55bb76b8fb4a9b0384b8812a","unresolved":true,"context_lines":[{"line_number":3256,"context_line":"\t\tbare_partition_name \u003d TWFunc::Remove_Beginning_Slash(twrpPart-\u003eGet_Mount_Point());"},{"line_number":3257,"context_line":""},{"line_number":3258,"context_line":"\tFstabEntry fstabEntry \u003d {"},{"line_number":3259,"context_line":"        .blk_device \u003d bare_partition_name + PartitionManager.Get_Active_Slot_Suffix() ,"},{"line_number":3260,"context_line":"        .mount_point \u003d twrpPart-\u003eGet_Mount_Point(),"},{"line_number":3261,"context_line":"        .fs_type \u003d twrpPart-\u003eCurrent_File_System,"},{"line_number":3262,"context_line":"        .fs_mgr_flags.logical \u003d twrpPart-\u003eIs_Super,"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"4c5aefb1_bb6ff495","line":3259,"updated":"2020-06-01 06:22:30.000000000","message":"This should support both A-only \u0026 A/B device at the same time, not only for A/B.","commit_id":"bb94fbe35d8a1c3d2e690a18caa4525a1fc0ad62"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"a4d0432c0bee2a997a10bee829800e9866c91c6e","unresolved":false,"context_lines":[{"line_number":3256,"context_line":"\t\tbare_partition_name \u003d TWFunc::Remove_Beginning_Slash(twrpPart-\u003eGet_Mount_Point());"},{"line_number":3257,"context_line":""},{"line_number":3258,"context_line":"\tFstabEntry fstabEntry \u003d {"},{"line_number":3259,"context_line":"        .blk_device \u003d bare_partition_name + PartitionManager.Get_Active_Slot_Suffix() ,"},{"line_number":3260,"context_line":"        .mount_point \u003d twrpPart-\u003eGet_Mount_Point(),"},{"line_number":3261,"context_line":"        .fs_type \u003d twrpPart-\u003eCurrent_File_System,"},{"line_number":3262,"context_line":"        .fs_mgr_flags.logical \u003d twrpPart-\u003eIs_Super,"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"20031405_d955e610","line":3259,"in_reply_to":"4c5aefb1_bb6ff495","updated":"2020-06-01 14:19:13.000000000","message":"I don\u0027t have any non a/b device that has a super partition. This will have to be tweaked in the future but I feel shouldn\u0027t block this patch being merged.","commit_id":"bb94fbe35d8a1c3d2e690a18caa4525a1fc0ad62"},{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"95ea13acb7eb477f6ae87ee1d212f79fcb28b170","unresolved":true,"context_lines":[{"line_number":3276,"context_line":""},{"line_number":3277,"context_line":"bool TWPartitionManager::Is_Super_Partition(const char* fstab_line) {"},{"line_number":3278,"context_line":"\tbool isSuper \u003d false;"},{"line_number":3279,"context_line":"\tif (strncmp(fstab_line, \"system\", strlen(\"system\")) \u003d\u003d 0 || strncmp(fstab_line, \"vendor\", strlen(\"vendor\")) \u003d\u003d 0"},{"line_number":3280,"context_line":"\t|| strncmp(fstab_line, \"data\", strlen(\"data\")) \u003d\u003d 0) {"},{"line_number":3281,"context_line":"\t\tisSuper \u003d true;"},{"line_number":3282,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"0a73b234_1e8f5c99","line":3279,"updated":"2020-06-02 03:05:18.000000000","message":"It should have odm, product and system_ext according to the document.","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"207ee3c9520ab3976c1faf06db95888507429218","unresolved":false,"context_lines":[{"line_number":3276,"context_line":""},{"line_number":3277,"context_line":"bool TWPartitionManager::Is_Super_Partition(const char* fstab_line) {"},{"line_number":3278,"context_line":"\tbool isSuper \u003d false;"},{"line_number":3279,"context_line":"\tif (strncmp(fstab_line, \"system\", strlen(\"system\")) \u003d\u003d 0 || strncmp(fstab_line, \"vendor\", strlen(\"vendor\")) \u003d\u003d 0"},{"line_number":3280,"context_line":"\t|| strncmp(fstab_line, \"data\", strlen(\"data\")) \u003d\u003d 0) {"},{"line_number":3281,"context_line":"\t\tisSuper \u003d true;"},{"line_number":3282,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"c6bd911a_4eb7fefc","line":3279,"in_reply_to":"0a73b234_1e8f5c99","updated":"2020-06-02 23:49:44.000000000","message":"Done","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":176,"name":"Simon Shi","email":"simonsmh@gmail.com","username":"simonsmh"},"change_message_id":"5a50cdbb377c4aa19bdaca3e28bbf34ac95b6f52","unresolved":true,"context_lines":[{"line_number":3303,"context_line":"\tsuperPartition-\u003eCan_Be_Backed_Up \u003d true;"},{"line_number":3304,"context_line":"\tsuperPartition-\u003eIs_Present \u003d true;"},{"line_number":3305,"context_line":"\tsuperPartition-\u003eIs_SubPartition \u003d false;"},{"line_number":3306,"context_line":"\tAdd_Partition(superPartition);"},{"line_number":3307,"context_line":"\tPartitionManager.Output_Partition(superPartition);"},{"line_number":3308,"context_line":"\tUpdate_System_Details();"},{"line_number":3309,"context_line":"}"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"0ef6aa52_065266d5","line":3306,"updated":"2020-06-02 15:13:42.000000000","message":"Maybe we should make super flashable?\n\nsuperPartition-\u003eCan_Flash_Img \u003d true;","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"207ee3c9520ab3976c1faf06db95888507429218","unresolved":false,"context_lines":[{"line_number":3303,"context_line":"\tsuperPartition-\u003eCan_Be_Backed_Up \u003d true;"},{"line_number":3304,"context_line":"\tsuperPartition-\u003eIs_Present \u003d true;"},{"line_number":3305,"context_line":"\tsuperPartition-\u003eIs_SubPartition \u003d false;"},{"line_number":3306,"context_line":"\tAdd_Partition(superPartition);"},{"line_number":3307,"context_line":"\tPartitionManager.Output_Partition(superPartition);"},{"line_number":3308,"context_line":"\tUpdate_System_Details();"},{"line_number":3309,"context_line":"}"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"de1ca8fa_066a129f","line":3306,"in_reply_to":"0ef6aa52_065266d5","updated":"2020-06-02 23:49:44.000000000","message":"Done","commit_id":"36322feaba6e9c1f6fedd101a5fa3616859f9c21"}]}