)]}'
{"id":"android_bootable_recovery~1882","triplet_id":"android_bootable_recovery~android-9.0~I7f531d113b07c31b39d8f87edac76a7fc79075e7","project":"android_bootable_recovery","branch":"android-9.0","topic":"sar-fixes","hashtags":[],"change_id":"I7f531d113b07c31b39d8f87edac76a7fc79075e7","subject":"Create/Remove system_root/system bind mount, when mounting System","status":"MERGED","created":"2020-01-26 20:15:02.000000000","updated":"2022-08-23 22:31:08.000000000","submitted":"2020-05-10 20:20:43.000000000","submitter":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1882-1589142043467-7cb2ecb0","meta_rev_id":"2206f4cc09a0db43ba9bf99970023ea804c4d493","_number":1882,"virtual_id_number":1882,"owner":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"all":[{"value":0,"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},{"value":2,"date":"2022-08-23 22:31:08.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"value":1,"date":"2022-08-23 22:31:08.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},{"value":0,"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":25,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao"}],"reviewers":{"CC":[{"_account_id":124,"name":"Mohd Faraz","email":"androiabledroid@gmail.com","username":"AndroiableDroid"},{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},{"_account_id":443,"name":"fgl27","username":"fgl27"}],"REVIEWER":[{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"_account_id":25,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao"},{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-01 21:15:54.000000000","updated_by":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"reviewer":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"state":"REVIEWER"},{"updated":"2020-02-07 07:58:39.000000000","updated_by":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"reviewer":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"state":"CC"},{"updated":"2020-03-08 22:50:39.000000000","updated_by":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"reviewer":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"state":"REVIEWER"},{"updated":"2020-03-09 06:57:23.000000000","updated_by":{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},"reviewer":{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},"state":"CC"},{"updated":"2020-04-27 22:56:14.000000000","updated_by":{"_account_id":124,"name":"Mohd Faraz","email":"androiabledroid@gmail.com","username":"AndroiableDroid"},"reviewer":{"_account_id":124,"name":"Mohd Faraz","email":"androiabledroid@gmail.com","username":"AndroiableDroid"},"state":"CC"},{"updated":"2020-05-01 04:30:55.000000000","updated_by":{"_account_id":25,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao"},"reviewer":{"_account_id":25,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao"},"state":"REVIEWER"},{"updated":"2020-05-03 05:45:11.000000000","updated_by":{"_account_id":443,"name":"fgl27","username":"fgl27"},"reviewer":{"_account_id":443,"name":"fgl27","username":"fgl27"},"state":"CC"},{"updated":"2020-05-06 06:28:12.000000000","updated_by":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"reviewer":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"state":"REVIEWER"}],"messages":[{"id":"3f6135b46b6c3a6e1a1849515640e46e2d74aff4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-26 20:15:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a8bce59efebd34fb0cef151fbd57c76b81b8a145","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-26 23:20:39.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"1ab89d18801cd8fb0d1f5df2120f5e8431ee8c8f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-26 23:23:25.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"fecde8e5187b3bb56d6d1906f87237fe1d0d9cdd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-26 23:47:49.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.","accounts_in_message":[],"_revision_number":4},{"id":"6692fc18ba41b3ece871f3f6498e143d29591dc0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-27 01:34:10.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"52b2d6dd20b7b731e8a1ff22e3fc63b82ca79fcc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-27 13:50:44.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"533a75e29fe3cc09e27f20d25800a404243fb187","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-27 13:54:36.000000000","message":"Patch Set 7: Commit message was updated.","accounts_in_message":[],"_revision_number":7},{"id":"97bf2956afe509245b2188ea0f97977b20bba6af","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-27 14:16:45.000000000","message":"Patch Set 8: Commit message was updated.","accounts_in_message":[],"_revision_number":8},{"id":"b66d6cb60d61a4fb56c8ec42fcba12f32e43dd2c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-27 16:09:46.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"968afcff59e3202023a7345482882cc6c43858dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-01-28 01:05:49.000000000","message":"Uploaded patch set 10: Patch Set 9 was rebased.","accounts_in_message":[],"_revision_number":10},{"id":"ebb1adb4a5cbcfad4e7b395177eb0c85f23bbf0f","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-02-01 02:23:42.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"e540532612a18d77628718e9c22471927aedc79a","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2020-02-01 21:15:54.000000000","message":"Patch Set 10: Code-Review+1\n\nGood for me. This will help standardize TWRP\u0027s handling of SAR across all devices and types. Tested and builds/functions fine even in 5.1 tree.","accounts_in_message":[],"_revision_number":10},{"id":"5372492791c4f7c93b4e04df45342069c95a940d","author":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"date":"2020-02-07 07:58:39.000000000","message":"Patch Set 10:\n\nthis is a good idea, maybe solve some mount problems.\n\nI will test","accounts_in_message":[],"_revision_number":10},{"id":"af278411673c7a9905a86586154858707d69f448","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-02-07 19:01:06.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.","accounts_in_message":[],"_revision_number":11},{"id":"01a0552679f44714d381844f4acc7bf6325d3542","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"date":"2020-02-12 17:43:03.000000000","message":"Patch Set 12: Published edit on patch set 11.","accounts_in_message":[],"_revision_number":12},{"id":"8de6cb1029c281c669cbda45e7beaa4e872244e6","author":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"date":"2020-02-12 17:46:53.000000000","message":"Patch Set 12:\n\numount2 /system MNT_DETACH when device(/system) is busy.","accounts_in_message":[],"_revision_number":12},{"id":"a4f5f2ac87e64aee7b9b2eb5955d7f4dc2e1fccc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-02-15 18:11:55.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"9b7ad18827d19ed0addedd63165c7262b2dbec17","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2020-02-21 19:26:19.000000000","message":"Uploaded patch set 14: Patch Set 13 was rebased.","accounts_in_message":[],"_revision_number":14},{"id":"ec3db38d7e506008e9ff8ef7d7d37889ffaf745c","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-03-08 22:50:39.000000000","message":"Patch Set 14: Code-Review+2","accounts_in_message":[],"_revision_number":14},{"id":"7452d1b73932e6be5e5022548bc243caf1e72a90","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-03-10 00:19:41.000000000","message":"Uploaded patch set 15: Patch Set 14 was rebased.","accounts_in_message":[],"_revision_number":15},{"id":"ddb4baa7535d29daa40b5d1873a92c5dd2657f86","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2020-04-02 14:52:14.000000000","message":"Uploaded patch set 16: Patch Set 15 was rebased.","accounts_in_message":[],"_revision_number":16},{"id":"94c31bb3b9c8898d0730bee338f5a76aac0c9f25","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-04-09 21:26:01.000000000","message":"Patch Set 16: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":16},{"id":"daab6ab35a2c1786312ff679af6cc4266647445d","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-04-09 21:42:35.000000000","message":"Patch Set 16:\n\n(1 comment)","accounts_in_message":[],"_revision_number":16},{"id":"8d6d8a2d9d129fa85efedbfd27a1528ae05597c1","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-04-09 22:19:01.000000000","message":"Patch Set 16:\n\nOK, thanks I forgot about BOARD_BUILD_SYSTEM_ROOT_IMAGE which isn\u0027t in flame/coral\u0027s device configuration now. Could we just ifdef this code on BOARD_BUILD_SYSTEM_ROOT_IMAGE?","accounts_in_message":[],"_revision_number":16},{"id":"85b42db40b2401176edaed0776d3ecdf462d4cb8","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-04-09 22:22:32.000000000","message":"Patch Set 16:\n\n\u003e Patch Set 16:\n\u003e \n\u003e OK, thanks I forgot about BOARD_BUILD_SYSTEM_ROOT_IMAGE which isn\u0027t in flame/coral\u0027s device configuration now. Could we just ifdef this code on BOARD_BUILD_SYSTEM_ROOT_IMAGE?\n\nI feel it\u0027s better to just let it silently fail if /system isn\u0027t a symlink.\nIf it\u0027s a symlink even though BOARD_BUILD_SYSTEM_ROOT_IMAGE is not set, (possibly because a rogue script created it), mounting would fail otherwise.\nI don\u0027t see any harm in just always trying to unlink first.","accounts_in_message":[],"_revision_number":16},{"id":"ce4715a6b869bdf8ebc780263821b125f492160b","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-04-09 22:38:47.000000000","message":"Patch Set 16:\n\n\u003e Patch Set 16:\n\u003e \n\u003e \u003e Patch Set 16:\n\u003e \u003e \n\u003e \u003e OK, thanks I forgot about BOARD_BUILD_SYSTEM_ROOT_IMAGE which isn\u0027t in flame/coral\u0027s device configuration now. Could we just ifdef this code on BOARD_BUILD_SYSTEM_ROOT_IMAGE?\n\u003e \n\u003e I feel it\u0027s better to just let it silently fail if /system isn\u0027t a symlink.\n\u003e If it\u0027s a symlink even though BOARD_BUILD_SYSTEM_ROOT_IMAGE is not set, (possibly because a rogue script created it), mounting would fail otherwise.\n\u003e I don\u0027t see any harm in just always trying to unlink first.\n\nI still think if we limit side-effects with the ifdef, I would be more comfortable.","accounts_in_message":[],"_revision_number":16},{"id":"5bfcc41c30c23ff3dcaef59577175ed8f3177400","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-04-09 22:52:49.000000000","message":"Patch Set 16:\n\n\u003e Patch Set 16:\n\u003e \n\u003e \u003e Patch Set 16:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 16:\n\u003e \u003e \u003e \n\u003e \u003e \u003e OK, thanks I forgot about BOARD_BUILD_SYSTEM_ROOT_IMAGE which isn\u0027t in flame/coral\u0027s device configuration now. Could we just ifdef this code on BOARD_BUILD_SYSTEM_ROOT_IMAGE?\n\u003e \u003e \n\u003e \u003e I feel it\u0027s better to just let it silently fail if /system isn\u0027t a symlink.\n\u003e \u003e If it\u0027s a symlink even though BOARD_BUILD_SYSTEM_ROOT_IMAGE is not set, (possibly because a rogue script created it), mounting would fail otherwise.\n\u003e \u003e I don\u0027t see any harm in just always trying to unlink first.\n\u003e \n\u003e I still think if we limit side-effects with the ifdef, I would be more comfortable.\n\nWhat side-effects?\nThis way, we can be sure mounting works.\nalternatively we could check if /system is a symlink before unlinking (though I don\u0027t think it\u0027s necessary)\nI think using ifdef may introduce more room for errors.","accounts_in_message":[],"_revision_number":16},{"id":"b7d2860e9038a0291925b515f02715b746f770c5","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-04-09 23:22:51.000000000","message":"Patch Set 16:\n\n\u003e Patch Set 16:\n\u003e \n\u003e \u003e Patch Set 16:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 16:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 16:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e OK, thanks I forgot about BOARD_BUILD_SYSTEM_ROOT_IMAGE which isn\u0027t in flame/coral\u0027s device configuration now. Could we just ifdef this code on BOARD_BUILD_SYSTEM_ROOT_IMAGE?\n\u003e \u003e \u003e \n\u003e \u003e \u003e I feel it\u0027s better to just let it silently fail if /system isn\u0027t a symlink.\n\u003e \u003e \u003e If it\u0027s a symlink even though BOARD_BUILD_SYSTEM_ROOT_IMAGE is not set, (possibly because a rogue script created it), mounting would fail otherwise.\n\u003e \u003e \u003e I don\u0027t see any harm in just always trying to unlink first.\n\u003e \u003e \n\u003e \u003e I still think if we limit side-effects with the ifdef, I would be more comfortable.\n\u003e \n\u003e What side-effects?\n\u003e This way, we can be sure mounting works.\n\u003e alternatively we could check if /system is a symlink before unlinking (though I don\u0027t think it\u0027s necessary)\n\u003e I think using ifdef may introduce more room for errors.\n\nIt is a side-effect since we weren\u0027t doing it before.","accounts_in_message":[],"_revision_number":16},{"id":"8f9f1e09a7fdc814b188edc85211d3c3aca44929","author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"date":"2020-04-09 23:28:11.000000000","message":"Patch Set 16:\n\n\u003e Patch Set 16:\n\u003e \n\u003e \u003e Patch Set 16:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 16:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 16:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e Patch Set 16:\n\u003e \u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e \u003e OK, thanks I forgot about BOARD_BUILD_SYSTEM_ROOT_IMAGE which isn\u0027t in flame/coral\u0027s device configuration now. Could we just ifdef this code on BOARD_BUILD_SYSTEM_ROOT_IMAGE?\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e I feel it\u0027s better to just let it silently fail if /system isn\u0027t a symlink.\n\u003e \u003e \u003e \u003e If it\u0027s a symlink even though BOARD_BUILD_SYSTEM_ROOT_IMAGE is not set, (possibly because a rogue script created it), mounting would fail otherwise.\n\u003e \u003e \u003e \u003e I don\u0027t see any harm in just always trying to unlink first.\n\u003e \u003e \u003e \n\u003e \u003e \u003e I still think if we limit side-effects with the ifdef, I would be more comfortable.\n\u003e \u003e \n\u003e \u003e What side-effects?\n\u003e \u003e This way, we can be sure mounting works.\n\u003e \u003e alternatively we could check if /system is a symlink before unlinking (though I don\u0027t think it\u0027s necessary)\n\u003e \u003e I think using ifdef may introduce more room for errors.\n\u003e \n\u003e It is a side-effect since we weren\u0027t doing it before.\n\nBefore most maintainers removed the symlink during init, this just ensures there will be a directory for bind-mounting system.\nI just don\u0027t see what harm there is in trying (and failing) to remove a non-existent symlink.","accounts_in_message":[],"_revision_number":16},{"id":"9118bbaa27ce4ea6589ddafef3a62d84c99b59e1","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-04-10 21:05:57.000000000","message":"Patch Set 16: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":16},{"id":"ab450897110d2737eba86a809f6dc182caeb724f","author":{"_account_id":124,"name":"Mohd Faraz","email":"androiabledroid@gmail.com","username":"AndroiableDroid"},"date":"2020-04-27 22:56:14.000000000","message":"Patch Set 16:\n\n(1 comment)","accounts_in_message":[],"_revision_number":16},{"id":"d2ad33256b0de0b6f2fdde59cd9f80a5e079f9b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":25,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao"},"date":"2020-05-01 04:30:55.000000000","message":"Uploaded patch set 17: Patch Set 16 was rebased.","accounts_in_message":[],"_revision_number":17},{"id":"cb8549da3e917035b94b01ab0be160ea69db4d6e","author":{"_account_id":443,"name":"fgl27","username":"fgl27"},"date":"2020-05-03 05:45:11.000000000","message":"Patch Set 17:\n\nBackwards compatibility of zip that try to Mount system as must \u0027/system\u0027 didn\u0027t worked for me.\n\nAfter using all of latest sar changes, I tested like this, on android 10 backup then restore all OK, wipe system and data of android 10 sar and tried to flash android 9, it fails trying to Mount \u0027/system\u0027...\n\nIf I tried via adb to Mount I get a error \u0027/system not in fstab\u0027 or something like that.\n\nI know is all wip, maybe I missing a change or is something in the works already, if not is something to look for.","accounts_in_message":[],"_revision_number":17},{"id":"ec50a6a70c22dd2083436e6fbd131478a8f06dcb","author":{"_account_id":443,"name":"fgl27","username":"fgl27"},"date":"2020-05-03 05:50:07.000000000","message":"Patch Set 17:\n\n\u003e Patch Set 17:\n\u003e \n\u003e Backwards compatibility of zip that try to Mount system as must \u0027/system\u0027 didn\u0027t worked for me.\n\u003e \nAuto corrector...\nI mean \"just\" not \"must\u0027... \u0027mount /system\u0027","accounts_in_message":[],"_revision_number":17},{"id":"f41d82645c2d248a393d875281aea880080ed23f","author":{"_account_id":25,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao"},"date":"2020-05-04 05:15:00.000000000","message":"Patch Set 17:\n\n\u003e Patch Set 17:\n\u003e \n\u003e Backwards compatibility of zip that try to Mount system as must \u0027/system\u0027 didn\u0027t worked for me.\n\u003e \n\u003e After using all of latest sar changes, I tested like this, on android 10 backup then restore all OK, wipe system and data of android 10 sar and tried to flash android 9, it fails trying to Mount \u0027/system\u0027...\n\u003e \n\u003e If I tried via adb to Mount I get a error \u0027/system not in fstab\u0027 or something like that.\n\u003e \n\u003e I know is all wip, maybe I missing a change or is something in the works already, if not is something to look for.\n\nYes a common scenario is I have 10 installed and want to rollback to 9. /system is a symlink thus pre-10 backuptool would fail to mount system. A possible fix might be always making /system a directory and bind mount when appropriate.","accounts_in_message":[],"_revision_number":17},{"id":"6cc6bf1f604cf20754938a02f602dcc1fbb1918d","author":{"_account_id":443,"name":"fgl27","username":"fgl27"},"date":"2020-05-05 22:27:28.000000000","message":"Patch Set 17:\n\n\u003e Patch Set 17:\n\u003e \n\u003e \u003e Patch Set 17:\n\u003e \u003e \n\u003e \u003e Backwards compatibility of zip that try to Mount system as must \u0027/system\u0027 didn\u0027t worked for me.\n\u003e \u003e \n\u003e \u003e After using all of latest sar changes, I tested like this, on android 10 backup then restore all OK, wipe system and data of android 10 sar and tried to flash android 9, it fails trying to Mount \u0027/system\u0027...\n\u003e \u003e \n\u003e \u003e If I tried via adb to Mount I get a error \u0027/system not in fstab\u0027 or something like that.\n\u003e \u003e \n\u003e \u003e I know is all wip, maybe I missing a change or is something in the works already, if not is something to look for.\n\u003e \n\u003e Yes a common scenario is I have 10 installed and want to rollback to 9. /system is a symlink thus pre-10 backuptool would fail to mount system. A possible fix might be always making /system a directory and bind mount when appropriate.\n\nNot just that, I have many zips that I use and they work on any TWRP that I have used on past 5 years and those zip even work on Android 10 on a old TWRP (pre this SAR changes), now with this changes they are all obsolete and need changes, yes I can fix some, but we can\u0027t expect that users will have update for all they zips or know how to fix them, so the \"Backwards compatibility\" is a must on my opinion as the day this new TWRP is released to all old devices user will complain.\n\nI assume is probably something simple to do (not for me as I don\u0027t work on TWRP code regularly) but for you guys that are working regularly on TWRP code probably is.\n\nAlso this changes that you guys are working are need, I just wanna to share my personal idea of use and improves.","accounts_in_message":[],"_revision_number":17},{"id":"379bfe94a52f2bf5962aa79b8509bdcfaa1c0532","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-05-06 06:28:12.000000000","message":"Patch Set 17: Code-Review+1\n\nWorks great.\n\nI think in TWRP 10.0 there shouldn\u0027t be any backwards compatibility, since google forces SAR on 10 and newer.\n\nBut for 9.0, I\u0027m not sure, since SAR was optional before.","accounts_in_message":[],"_revision_number":17},{"id":"450a5010719cf9958a81914fc41590e3c4a09132","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-10 19:48:45.000000000","message":"Uploaded patch set 18: Patch Set 17 was rebased.","accounts_in_message":[],"_revision_number":18},{"id":"c7770a0a656a4e7e6ee420738b11581393aafa82","tag":"autogenerated:gerrit:merged","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-05-10 20:20:43.000000000","message":"Change has been successfully merged by bigbiff","accounts_in_message":[],"_revision_number":18}],"current_revision_number":18,"current_revision":"da974805672e53c334b71480c5a6bc08f3e16109","revisions":{"a4b49b2d3c43ab6971d9c0f43689f85b4f97ea8a":{"kind":"REWORK","_number":1,"created":"2020-01-26 20:15:02.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/1 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/1","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b0fe5201e0dde6dc63eb4ed5ac244270858f953b","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"subject":"Create/Remove system_root symlink when mounting/unmounting System","message":"Create/Remove system_root symlink when mounting/unmounting System\n\nThis will automatically create and remove a symlink\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"746187430d1fb6982825c10b930e18ce363adeee":{"kind":"NO_CHANGE","_number":2,"created":"2020-01-26 23:20:39.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/2","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/2","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/2 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/2","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a019b2580eb7cfaf0772f5a93b0db3a85aa57271","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:41:14.000000000","tz":60},"subject":"Create/Remove system_root symlink when mounting/unmounting System","message":"Create/Remove system_root symlink when mounting/unmounting System\n\nThis will automatically create and remove a symlink\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"d3ca9c811653c6c118bed8fcafee074d5c4eaa93":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-01-26 23:23:25.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/3","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/3","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/3 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/3","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a019b2580eb7cfaf0772f5a93b0db3a85aa57271","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 23:23:25.000000000","tz":0},"subject":"Create/Remove system_root symlink when mounting/unmounting System","message":"Create/Remove system_root symlink when mounting/unmounting System\n\nThis will automatically create and remove a symlink\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nNote: /system must be an empty directory.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0","description":"Edit commit message"},"4641a18517f13466ec867abeafd2485d20525f62":{"kind":"NO_CHANGE","_number":4,"created":"2020-01-26 23:47:49.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/4","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/4","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/4 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/4","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7a089c49ca8576d563e1eec96e677fa12d629d0f","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 23:41:47.000000000","tz":60},"subject":"Create/Remove system_root symlink when mounting/unmounting System","message":"Create/Remove system_root symlink when mounting/unmounting System\n\nThis will automatically create and remove a symlink\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nNote: /system must be an empty directory.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"7a6b9b18f89bc36a1c136b2e1ecbc70a135269a8":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2020-01-27 01:34:10.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/5","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/5","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/5 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/5","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc2fd618e7b6e3b0be8a0b29ba7715781d495bd7","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-27 01:28:04.000000000","tz":60},"subject":"Create/Remove system_root symlink when mounting/unmounting System","message":"Create/Remove system_root symlink when mounting/unmounting System\n\nThis will automatically create and remove a symlink\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nNote: /system must be an empty directory.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"a46da460f239ef5dd4c80f39b262ed1647edc1ae":{"kind":"REWORK","_number":6,"created":"2020-01-27 13:50:44.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/6","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/6","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/6 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/6","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc2fd618e7b6e3b0be8a0b29ba7715781d495bd7","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-27 13:47:13.000000000","tz":60},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a symlink\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nNote: /system must be an empty directory.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"635854ac2fcda11a3b570a9fdd8ed50c2baa9e0a":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2020-01-27 13:54:36.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/7","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/7","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/7 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/7","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc2fd618e7b6e3b0be8a0b29ba7715781d495bd7","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-27 13:54:36.000000000","tz":0},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nNote: /system must be an empty directory.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0","description":"Edit commit message"},"ffe5244e98ebde36de5cb50ce578b3d907aabffb":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2020-01-27 14:16:45.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/8","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/8","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/8 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/8","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc2fd618e7b6e3b0be8a0b29ba7715781d495bd7","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-27 14:16:45.000000000","tz":0},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0","description":"Edit commit message"},"e653cbef90ae8a2e039b41d3f4f60cddff0e0427":{"kind":"REWORK","_number":9,"created":"2020-01-27 16:09:46.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/9","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/9","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/9 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/9","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a4053c4da5ac3f27165a16d6e3df4256896f5b8b","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-27 15:51:00.000000000","tz":60},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"569f8dfde4dff3dbe6a7b494ac822d20df593159":{"kind":"TRIVIAL_REBASE","_number":10,"created":"2020-01-28 01:05:49.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/10","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/10","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/10 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/10","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a18d54f769f96295a96335aac5d80536254c8e5","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-28 00:51:01.000000000","tz":60},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"4751ad08d221b1140dc6af3b4887356aca5affa3":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2020-02-07 19:01:06.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/11","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/11","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/11 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/11","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36144605ee327729f0332336b071535e5c13fda1","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-02-07 19:00:39.000000000","tz":60},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"37295382372a392d4a9509cc9f3fed5a0c4653aa":{"kind":"REWORK","_number":12,"created":"2020-02-12 17:43:03.000000000","uploader":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"ref":"refs/changes/82/1882/12","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/12","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/12 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/12","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36144605ee327729f0332336b071535e5c13fda1","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"wzsx150","email":"wzsx150@163.com","date":"2020-02-12 17:42:45.000000000","tz":0},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"1e29000acf1daa0691fff5a40915d755c6a55e5a":{"kind":"REWORK","_number":13,"created":"2020-02-15 18:11:55.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/13","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/13","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/13 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/13","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/13 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36144605ee327729f0332336b071535e5c13fda1","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-02-15 15:14:53.000000000","tz":60},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"6495a2c8772a409ccd20e7bb3f3019d5f45d9316":{"kind":"TRIVIAL_REBASE","_number":14,"created":"2020-02-21 19:26:19.000000000","uploader":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"ref":"refs/changes/82/1882/14","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/14","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/14 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/14","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/14 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"789c9330bcf37c5dd388f2cf70b228e234011387","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Captain Throwback","email":"captainthrowback@hotmail.com","date":"2020-02-21 19:22:41.000000000","tz":-300},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"d2e967daaad2dc335712e27a40a07fe639dcf1c2":{"kind":"TRIVIAL_REBASE","_number":15,"created":"2020-03-10 00:19:41.000000000","uploader":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"ref":"refs/changes/82/1882/15","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/15","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/15 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/15","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/15 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ef491e17c5316ec257301c98ac6a34bfca61bc1","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-03-10 00:16:03.000000000","tz":60},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"b09a69577bf11fa1b96f7ca0d38cd5ac926ab7f4":{"kind":"TRIVIAL_REBASE","_number":16,"created":"2020-04-02 14:52:14.000000000","uploader":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"ref":"refs/changes/82/1882/16","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/16","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/16 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/16 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/16 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/16 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/16","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/16 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1e27647420016865361664b07cc1e307bda38c6","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"Captain Throwback","email":"captainthrowback@hotmail.com","date":"2020-04-02 14:51:26.000000000","tz":-240},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"82eb60f57ac339e4cc3baf1dc43a2f1570220922":{"kind":"TRIVIAL_REBASE","_number":17,"created":"2020-05-01 04:30:55.000000000","uploader":{"_account_id":25,"name":"dianlujitao","email":"dianlujitao@lineageos.org","username":"dianlujitao"},"ref":"refs/changes/82/1882/17","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/17","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/17 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/17 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/17 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/17 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/17","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/17 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c696b5cc12e3eb3d4375191c2be9ebec723bbcf3","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"dianlujitao","email":"dianlujitao@lineageos.org","date":"2020-04-30 08:42:03.000000000","tz":480},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"},"da974805672e53c334b71480c5a6bc08f3e16109":{"kind":"TRIVIAL_REBASE","_number":18,"created":"2020-05-10 19:48:45.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/82/1882/18","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/82/1882/18","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/18 \u0026\u0026 git checkout -b change-1882 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/18 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/18 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/18 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/18","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/82/1882/18 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ff4f958182e710c64143d876b8ccc40259d2bea8","subject":"Add option to automatically unmount system before installing ZIP"}],"author":{"name":"Chaosmaster","email":"chaosmaster@chaosv.de","date":"2020-01-26 20:09:28.000000000","tz":60},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-05-10 19:43:55.000000000","tz":-240},"subject":"Create/Remove system_root/system bind mount, when mounting System","message":"Create/Remove system_root/system bind mount, when mounting System\n\nThis will automatically create and remove a bind mount\n/system -\u003e /system_root/system\neverytime \"System\" is mounted via the GUI or ORS.\nThis should get rid of issues with ZIPs trying to mount\nthe system-partition to /system on SAR-devices, while keeping\nthe filesystem-layout in sync with AOSP from a user-perspective.\n\nChange-Id: I7f531d113b07c31b39d8f87edac76a7fc79075e7\n"},"branch":"refs/heads/android-9.0"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}