)]}'
{"partition.cpp":[{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"94c31bb3b9c8898d0730bee338f5a76aac0c9f25","unresolved":true,"context_lines":[{"line_number":1530,"context_line":"\t}"},{"line_number":1531,"context_line":""},{"line_number":1532,"context_line":"\tif (Mount_Point \u003d\u003d \"/system_root\") {"},{"line_number":1533,"context_line":"\t\tunlink(\"/system\");"},{"line_number":1534,"context_line":"\t\tmkdir(\"/system\", 0755);"},{"line_number":1535,"context_line":"\t\tmount(\"/system_root/system\", \"/system\", \"auto\", MS_BIND, NULL);"},{"line_number":1536,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"8f27fbeb_50a2c753","line":1533,"updated":"2020-04-09 21:26:01.000000000","message":"We don\u0027t need to unlink system unless it\u0027s a symbolic link. I think this logic would be good for android-10.0","commit_id":"b09a69577bf11fa1b96f7ca0d38cd5ac926ab7f4"},{"author":{"_account_id":370,"name":"Chaosmaster","email":"chaosmaster@chaosv.de","username":"chaosmaster"},"change_message_id":"daab6ab35a2c1786312ff679af6cc4266647445d","unresolved":true,"context_lines":[{"line_number":1530,"context_line":"\t}"},{"line_number":1531,"context_line":""},{"line_number":1532,"context_line":"\tif (Mount_Point \u003d\u003d \"/system_root\") {"},{"line_number":1533,"context_line":"\t\tunlink(\"/system\");"},{"line_number":1534,"context_line":"\t\tmkdir(\"/system\", 0755);"},{"line_number":1535,"context_line":"\t\tmount(\"/system_root/system\", \"/system\", \"auto\", MS_BIND, NULL);"},{"line_number":1536,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"b3a84e2c_e131d28b","line":1533,"in_reply_to":"8f27fbeb_50a2c753","updated":"2020-04-09 21:42:35.000000000","message":"It will just silently fail, if it\u0027s a directory already.\nIt will be a symlink when built with BOARD_BUILD_SYSTEM_ROOT_IMAGE set to true.\nIf we don\u0027t unlink and create a directory in its place mounting will fail.","commit_id":"b09a69577bf11fa1b96f7ca0d38cd5ac926ab7f4"},{"author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"change_message_id":"9118bbaa27ce4ea6589ddafef3a62d84c99b59e1","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"\t}"},{"line_number":1531,"context_line":""},{"line_number":1532,"context_line":"\tif (Mount_Point \u003d\u003d \"/system_root\") {"},{"line_number":1533,"context_line":"\t\tunlink(\"/system\");"},{"line_number":1534,"context_line":"\t\tmkdir(\"/system\", 0755);"},{"line_number":1535,"context_line":"\t\tmount(\"/system_root/system\", \"/system\", \"auto\", MS_BIND, NULL);"},{"line_number":1536,"context_line":"\t}"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"918900b5_fe4daecc","line":1533,"in_reply_to":"b3a84e2c_e131d28b","updated":"2020-04-10 21:05:57.000000000","message":"I missed that in UnMount it will put the symlink back.","commit_id":"b09a69577bf11fa1b96f7ca0d38cd5ac926ab7f4"},{"author":{"_account_id":124,"name":"Mohd Faraz","email":"androiabledroid@gmail.com","username":"AndroiableDroid"},"change_message_id":"ab450897110d2737eba86a809f6dc182caeb724f","unresolved":true,"context_lines":[{"line_number":1531,"context_line":""},{"line_number":1532,"context_line":"\tif (Mount_Point \u003d\u003d \"/system_root\") {"},{"line_number":1533,"context_line":"\t\tunlink(\"/system\");"},{"line_number":1534,"context_line":"\t\tmkdir(\"/system\", 0755);"},{"line_number":1535,"context_line":"\t\tmount(\"/system_root/system\", \"/system\", \"auto\", MS_BIND, NULL);"},{"line_number":1536,"context_line":"\t}"},{"line_number":1537,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":16,"id":"82d25d4e_bda55547","line":1534,"updated":"2020-04-27 22:56:14.000000000","message":"When we are having system already created either it is sar or not. https://github.com/TeamWin/android_bootable_recovery/blob/android-9.0/partition.cpp#L1075\nThen why unlinking and making again?","commit_id":"b09a69577bf11fa1b96f7ca0d38cd5ac926ab7f4"}]}