)]}'
{"id":"android_bootable_recovery~1757","triplet_id":"android_bootable_recovery~android-9.0~I19741c29cda65ce051b7c167a946d551ce149f7b","project":"android_bootable_recovery","branch":"android-9.0","hashtags":[],"change_id":"I19741c29cda65ce051b7c167a946d551ce149f7b","subject":"Fix \u0027system/etc/ld.config.txt\u0027 not found error","status":"MERGED","created":"2019-12-31 12:39:17.000000000","updated":"2022-08-23 22:31:08.000000000","submitted":"2020-03-14 21:15:00.000000000","submitter":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1757-1584220500714-6712572b","meta_rev_id":"676f4c16e39e0b449bc9666fa4b41792d5ad5473","_number":1757,"virtual_id_number":1757,"owner":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"all":[{"value":0,"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},{"value":2,"date":"2022-08-23 22:31:08.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"value":1,"date":"2022-08-23 22:31:08.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},{"value":0,"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},{"value":0,"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"}],"REVIEWER":[{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-31 12:42:00.000000000","updated_by":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"reviewer":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"state":"REVIEWER"},{"updated":"2019-12-31 12:44:52.000000000","updated_by":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"reviewer":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"state":"REVIEWER"},{"updated":"2020-01-06 15:56:07.000000000","updated_by":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"reviewer":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"state":"CC"},{"updated":"2020-02-15 14:40:52.000000000","updated_by":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"reviewer":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"state":"CC"},{"updated":"2020-03-09 07:26:05.000000000","updated_by":{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},"reviewer":{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},"state":"REVIEWER"},{"updated":"2020-03-11 20:20:16.000000000","updated_by":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"reviewer":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"state":"REVIEWER"}],"messages":[{"id":"a601feccc942f0366a5b0bfc438cefbcd1714784","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2019-12-31 12:39:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1bc2e4a1d1011430b64ba9c48982477a5a4d2639","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2019-12-31 12:42:00.000000000","message":"Patch Set 1: Code-Review+1\n\nWorks here with a pure AOSP compatible device tree generating the ld.config.txt with the AOSP build system.\n(Sony Open Devices Project)","accounts_in_message":[],"_revision_number":1},{"id":"84f3200458679003096239dfa9bc618592752db2","author":{"_account_id":37,"name":"mauronofrio","email":"poronofrio@gmail.com","username":"mauronofrio"},"date":"2020-01-06 15:56:07.000000000","message":"Patch Set 1:\n\nBut this is not a problem if we have a twrp that supports more android version? for example if we build the twrp under android-9.0 and we are using it on an android 10 device vnd version in twrp will be always 28 so it will report an error.","accounts_in_message":[],"_revision_number":1},{"id":"e4cd8f69788e8f6197a5207a3b0fb45fb071f486","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-01-27 23:40:03.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e But this is not a problem if we have a twrp that supports more android version? for example if we build the twrp under android-9.0 and we are using it on an android 10 device vnd version in twrp will be always 28 so it will report an error.\n\nThe fix is for the build system.\nRegardles on which device we will boot the compiled twrp, we have always \"$(TARGET_RECOVERY_ROOT_OUT)/sbin/ld.config.txt\".\nBut the compiled ld.config.txt depends in which android environment we build twrp.\n\nIf we build it in AOSP 9.0 it generates ld.config.28.txt\nIf we build it in AOSP 10.0 it generates ld.config.29.txt\n\nIn the boot.img file it will always be ld.config.txt","accounts_in_message":[],"_revision_number":1},{"id":"6dd5b96a89c62fbd0a5ef19e3bd0799b73b7da74","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-01-27 23:48:01.000000000","message":"Patch Set 1:\n\nPS: Sorry for not replying for so long.\nI didn\u0027t got a notification email. :S","accounts_in_message":[],"_revision_number":1},{"id":"4f751ccf1aff4a2c58a68cd593febb4d1bff5a71","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2020-02-05 18:23:25.000000000","message":"Patch Set 1: Code-Review-1\n\nBreaks build in 8.1 tree. Your build only seems to apply to certain build trees, so it needs to be properly qualified.\n\nsed: can\u0027t read /data/Android/build/omni/android-8.1/out/target/product/hima/system/etc/ld.config..txt: No such file or directory","accounts_in_message":[],"_revision_number":1},{"id":"ab88b11510705ae81d0281d698bb35a0af02d197","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-02-15 11:57:34.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"ea6bf2ed06178cb50d4f904f22fc13cd63531800","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-02-15 12:06:50.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"09a704e4eea65e49eab8fcc189e059477e254752","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-02-15 12:08:48.000000000","message":"Patch Set 3: Code-Review+1\n\nI\u0027m sorry, now I set a guard to only apply if you have android 9.0 or newer.\nThis behaviour got introduced in Android 9.0.\nI forgot to look into the 8.0 AOSP code and I also forgot the fact, that TWRP 9.0 gets used in older android versions as well.","accounts_in_message":[],"_revision_number":3},{"id":"c212b4f315390125336c6e11426d74a7d1ba696e","author":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"date":"2020-02-15 14:40:52.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 3: Code-Review+1\n\u003e \n\u003e I\u0027m sorry, now I set a guard to only apply if you have android 9.0 or newer.\n\u003e This behaviour got introduced in Android 9.0.\n\u003e I forgot to look into the 8.0 AOSP code and I also forgot the fact, that TWRP 9.0 gets used in older android versions as well.\n\nI think the ld.config.txt will be replaced by ld.config.${PLATFORM_VNDK_VERSION}.txt when \nPRODUCT_SHIPPING_API_LEVEL :\u003d 28 or BOARD_VNDK_VERSION :\u003d current ... in device tree.\n\nif your device tree do not config vndk version, here should be ld.config.txt.","accounts_in_message":[],"_revision_number":3},{"id":"146e36be6c77c20ef770d509c601160181e77510","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-02-15 17:28:18.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f348ef2c5bb6912eaa26582f2d6012d6f6d865b5","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-02-15 17:29:37.000000000","message":"Patch Set 4: Code-Review+1\n\nOh yes, thank you.\nI added a \"ifdef BOARD_VNDK_VERSION\" guard to it. 😊\nLike it\u0027s used in the AOSP code.","accounts_in_message":[],"_revision_number":4},{"id":"5662dbe0adc3c663bd453044f69e45462973587b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-02-15 17:31:56.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"22122245291e9877639135af4f6ccb1f2002fa32","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},"date":"2020-03-09 07:26:05.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"20ae67cdbd5cf791552ed68d6c569199c2a5e326","author":{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},"date":"2020-03-09 07:28:06.000000000","message":"Patch Set 6: Code-Review+1\n\nThis looks fine for me. However I\u0027ve fixed the indentation (tabs vs spaces) and reformatted the commit message to match git standards.","accounts_in_message":[],"_revision_number":6},{"id":"0fff9dcb5e247c2657c4d3ad44006a6db68adca2","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-03-09 08:05:31.000000000","message":"Patch Set 6: Code-Review+1\n\nThank you!","accounts_in_message":[],"_revision_number":6},{"id":"44adead3a3979ad0a0f4f7119be8e219a60d5a0c","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-03-10 22:46:33.000000000","message":"Patch Set 6: Code-Review-1","accounts_in_message":[],"_revision_number":6},{"id":"89b8f2f4280ca9bad930a2231d6c58c7d8d3fe80","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-03-11 11:54:48.000000000","message":"Removed Code-Review-1 by bigbiff \u003cbigbiff@teamw.in\u003e\n","accounts_in_message":[],"_revision_number":6},{"id":"106964b1a054eccf1318166c1ff100fec7784aca","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2020-03-11 15:46:42.000000000","message":"Patch Set 6: Code-Review+1\n\nBuilds fine for me in 8.1 tree. Since it should only affect 9.0+ trees, it shouldn\u0027t be an issue on any older trees either.","accounts_in_message":[],"_revision_number":6},{"id":"7204000ca7f7e74a29ed0ea0c3b4836da1e4456f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"date":"2020-03-11 20:11:42.000000000","message":"Patch Set 7: Published edit on patch set 6.","accounts_in_message":[],"_revision_number":7},{"id":"49a60478433c59f2f83c80ebd465ca32255e284a","author":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"date":"2020-03-11 20:20:16.000000000","message":"Patch Set 7: Code-Review+1\n\nI think we just use ld.config*.txt instead of ld.config.txt | ld.config.vndk_lite.txt | ld.config.${PLATFORM_VNDK_VERSION}.txt.\n\nso it will be easier and better.","accounts_in_message":[],"_revision_number":7},{"id":"45f86bc0617107797277e5b9b127cfeb4e1b0476","author":{"_account_id":32,"name":"CaptainThrowback","email":"captainthrowback@hotmail.com","username":"CaptainThrowback"},"date":"2020-03-11 20:32:42.000000000","message":"Patch Set 7:\n\n\u003e Patch Set 7: Code-Review+1\n\u003e \n\u003e I think we just use ld.config*.txt instead of ld.config.txt | ld.config.vndk_lite.txt | ld.config.${PLATFORM_VNDK_VERSION}.txt.\n\u003e \n\u003e so it will be easier and better.\n\nWhat if there\u0027s more than one ldconfig file at that path?","accounts_in_message":[],"_revision_number":7},{"id":"8e089964e3b2d9971f9d825712729ff72aed53c2","author":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"date":"2020-03-12 09:30:17.000000000","message":"Patch Set 7: -Code-Review\n\n\u003e Patch Set 7:\n\u003e \n\u003e \u003e Patch Set 7: Code-Review+1\n\u003e \u003e \n\u003e \u003e I think we just use ld.config*.txt instead of ld.config.txt | ld.config.vndk_lite.txt | ld.config.${PLATFORM_VNDK_VERSION}.txt.\n\u003e \u003e \n\u003e \u003e so it will be easier and better.\n\u003e \n\u003e What if there\u0027s more than one ldconfig file at that path?\n\nwhen build twrp or system, there is usually only one ldconfig.\nyou can test this patch.","accounts_in_message":[],"_revision_number":7},{"id":"5ad7a0d7839386ffc4618d6653ad14850a96d9a3","author":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"date":"2020-03-12 11:13:46.000000000","message":"Patch Set 7: Code-Review+1\n\nThank you for the simplification of the code!\n\nIn my testenvironment it works.\n(Android 9.0 and AOSP device tree generating a ld.config.28.txt)","accounts_in_message":[],"_revision_number":7},{"id":"5a4ff2b163222667698116356fbb16e2eff7c512","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-03-14 21:14:49.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"75aa322d47ce8bed9f6d28bd0433e0327723aca7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-03-14 21:14:54.000000000","message":"Patch Set 8: Patch Set 7 was rebased","accounts_in_message":[],"_revision_number":8},{"id":"080a2c18f6ed6d894ef84e907b8c4b9b16e30fe4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"date":"2020-03-14 21:15:00.000000000","message":"Change has been successfully merged by bigbiff","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"c630b3864f9ad0a7fe0b88b4180f42eefe3301db","revisions":{"b5790c8e34c01d31aae225cbb859082c0bba7a94":{"kind":"REWORK","_number":1,"created":"2019-12-31 12:39:17.000000000","uploader":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"ref":"refs/changes/57/1757/1","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/1","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/1 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/1","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15434cdeec6fb512033de56bf016e7bc81857e68","subject":"Merge \"android-5.1: use char constructor for default on c++ streams\" into android-9.0"}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-31 12:39:07.000000000","tz":60},"subject":"fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to https://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260 the ld.config.txt gets generated with the vndk version as a suffix.\n\nThe issue seems to be exist since commit 8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0"},"2d8e2c8c73884db50e19bbe1801ad4cc33635774":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-02-15 11:57:34.000000000","uploader":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"ref":"refs/changes/57/1757/2","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/2","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/2 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/2","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"990168bec01ec9685ad9581b023dbf39f3068d52","subject":"bootable: read all asserts in case there are more than one."}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"nc-duenkekl3","email":"nc-duenkekl3@netcologne.de","date":"2020-02-15 11:57:34.000000000","tz":0},"subject":"fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to https://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260 the ld.config.txt gets generated with the vndk version as a suffix.\n\nThe issue seems to be exist since commit 8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0","description":"Rebase"},"b2a922ffd28cefa44a3dddfacc231aa97336725d":{"kind":"REWORK","_number":3,"created":"2020-02-15 12:06:50.000000000","uploader":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"ref":"refs/changes/57/1757/3","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/3","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/3 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/3","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"990168bec01ec9685ad9581b023dbf39f3068d52","subject":"bootable: read all asserts in case there are more than one."}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2020-02-15 12:01:37.000000000","tz":60},"subject":"fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to https://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260 the ld.config.txt gets generated with the vndk version as a suffix.\nThis behaviour exists since API level 28 (Android 9.0).\n\nThe issue seems to be exist since commit 8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0"},"64e5fc1455364acddae09407f27a21eaded3198c":{"kind":"REWORK","_number":4,"created":"2020-02-15 17:28:18.000000000","uploader":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"ref":"refs/changes/57/1757/4","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/4","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/4 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/4","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"990168bec01ec9685ad9581b023dbf39f3068d52","subject":"bootable: read all asserts in case there are more than one."}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2020-02-15 17:28:04.000000000","tz":60},"subject":"fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to https://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260\n  the ld.config.txt gets generated with the vndk version as a suffix.\nThis behaviour exists since API level 28 (Android 9.0), if BOARD_VNDK_VERSION is defined and BOARD_VNDK_RUNTIME_DISABLE not true.\n\nThe issue seems to be exist since commit 8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0"},"eee0d1ee3a1edaca3453f6a3fa918183413efa66":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2020-02-15 17:31:56.000000000","uploader":{"_account_id":178,"name":"MartinX3","email":"katzenlie@googlemail.com","username":"MartinX3"},"ref":"refs/changes/57/1757/5","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/5","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/5 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/5","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"990168bec01ec9685ad9581b023dbf39f3068d52","subject":"bootable: read all asserts in case there are more than one."}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2020-02-15 17:31:14.000000000","tz":60},"subject":"fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to https://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260\n  the ld.config.txt gets generated with the vndk version as a suffix.\nThis behaviour exists since API level 28 (Android 9.0), if BOARD_VNDK_VERSION is defined and BOARD_VNDK_RUNTIME_DISABLE is not true.\n\nThe issue seems to be exist since commit 8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0"},"35def2719e4a0314920367b99a2ac082ca13708c":{"kind":"REWORK","_number":6,"created":"2020-03-09 07:26:05.000000000","uploader":{"_account_id":403,"name":"Andreas Schneider","email":"asn@cryptomilk.org","username":"cryptomilk"},"ref":"refs/changes/57/1757/6","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/6","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/6 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/6","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a411c8d257bf37a31907fc44be7cedf447aad7f","subject":"Fix ORS backup and restore for system-as-root"}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"Andreas Schneider","email":"asn@cryptomilk.org","date":"2020-03-09 07:25:32.000000000","tz":60},"subject":"Fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"Fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to\n\nhttps://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260\n\nthe ld.config.txt gets generated with the vndk version as a suffix.\nThis behaviour exists since API level 28 (Android 9.0), if\nBOARD_VNDK_VERSION is defined and BOARD_VNDK_RUNTIME_DISABLE is not\ntrue.\n\nThe issue seems to be exist since commit\n8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0"},"6769acdc12870308a2568049b266f22d39d5ba0a":{"kind":"REWORK","_number":7,"created":"2020-03-11 20:11:42.000000000","uploader":{"_account_id":366,"name":"wzsx150","email":"wzsx150@163.com","username":"wzsx150"},"ref":"refs/changes/57/1757/7","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/7","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/7 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/7","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a411c8d257bf37a31907fc44be7cedf447aad7f","subject":"Fix ORS backup and restore for system-as-root"}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"wzsx150","email":"wzsx150@163.com","date":"2020-03-11 20:10:26.000000000","tz":0},"subject":"Fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"Fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to\n\nhttps://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260\n\nthe ld.config.txt gets generated with the vndk version as a suffix.\nThis behaviour exists since API level 28 (Android 9.0), if\nBOARD_VNDK_VERSION is defined and BOARD_VNDK_RUNTIME_DISABLE is not\ntrue.\n\nThe issue seems to be exist since commit\n8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0"},"c630b3864f9ad0a7fe0b88b4180f42eefe3301db":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2020-03-14 21:14:54.000000000","uploader":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"},"ref":"refs/changes/57/1757/8","fetch":{"anonymous http":{"url":"https://gerrit.twrp.me/android_bootable_recovery","ref":"refs/changes/57/1757/8","commands":{"Branch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/8 \u0026\u0026 git checkout -b change-1757 FETCH_HEAD","Checkout":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/8","Reset To":"git fetch https://gerrit.twrp.me/android_bootable_recovery refs/changes/57/1757/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"191a6948d9f1f627cc53c38d72d4bce2e7897753","subject":"crypto: fde: decrypt master key first"}],"author":{"name":"Martin Dünkelmann","email":"nc-duenkekl3@netcologne.de","date":"2019-12-30 14:19:03.000000000","tz":60},"committer":{"name":"bigbiff","email":"bigbiff@teamw.in","date":"2020-03-14 21:14:54.000000000","tz":0},"subject":"Fix \u0027system/etc/ld.config.txt\u0027 not found error","message":"Fix \u0027system/etc/ld.config.txt\u0027 not found error\n\nAccording to\n\nhttps://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r51/rootdir/Android.mk#260\n\nthe ld.config.txt gets generated with the vndk version as a suffix.\nThis behaviour exists since API level 28 (Android 9.0), if\nBOARD_VNDK_VERSION is defined and BOARD_VNDK_RUNTIME_DISABLE is not\ntrue.\n\nThe issue seems to be exist since commit\n8d70eb617ea2260ba7338169a61f7aa4f5269f61 in twrp.\n\nChange-Id: I19741c29cda65ce051b7c167a946d551ce149f7b\n"},"branch":"refs/heads/android-9.0","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1,"name":"bigbiff","email":"bigbiff@teamw.in","username":"bigbiff"}}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}